Re: [webkit-dev] Support for showModalDialog in WebKit

2010-06-03 Thread Prasad Tammana
Hi Darin - I have a tiny CL related to this, sitting around for a couple of days now - https://bugs.webkit.org/show_bug.cgi?id=40036. Would you be able to review it? Thanks, Prasad On Mon, May 24, 2010 at 10:29 AM, Prasad Tammana pras...@google.com wrote: On Fri, May 21, 2010 at 8:29 PM,

Re: [webkit-dev] Support for showModalDialog in WebKit

2010-05-21 Thread Prasad Tammana
On Wed, May 19, 2010 at 6:04 PM, Darin Adler da...@apple.com wrote: On May 19, 2010, at 3:00 PM, Prasad Tammana wrote: I'm trying to add support for testing scenarios in the presence of modal dialogs to DumpRenderTree (DRT) and I'm running into an apparent limitation of WebKit support for

Re: [webkit-dev] Support for showModalDialog in WebKit

2010-05-21 Thread Prasad Tammana
Darin, I tried your suggestion: 1) We already have DumpRenderTreeApplication deriving from NSApplication. So I added the nextEventMatchingMask method as you've listed above to that. 2) Added code to invoke abortModal from NSWindowWillCloseNotification notification. Now it works sometimes but

Re: [webkit-dev] Support for showModalDialog in WebKit

2010-05-21 Thread Darin Adler
On May 21, 2010, at 6:40 PM, Prasad Tammana wrote: 2) Added code to invoke abortModal from NSWindowWillCloseNotification notification. I didn’t tell you do do that, and I don’t know why you’re calling abortModal. -- Darin ___ webkit-dev

Re: [webkit-dev] Support for showModalDialog in WebKit

2010-05-19 Thread Darin Adler
On May 19, 2010, at 3:00 PM, Prasad Tammana wrote: I'm trying to add support for testing scenarios in the presence of modal dialogs to DumpRenderTree (DRT) and I'm running into an apparent limitation of WebKit support for showModalDialog JavaScript function. Here is what I'm trying to do: