Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Eric Seidel
That stack is confusing. It looks like it's in Mac._build_java_test_support: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py#L133 But that shouldn't be trying to execute run-webkit-tests? Perhaps make is missing? or the java directory its trying to build is

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Eric Seidel
This is Executive.run_command: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/executive.py#L378 I would suggest running test-webkitpy (which will go through and delete any orphaned .pyc files which could be confusing things). -eric On Wed, Oct 3, 2012 at 9:19 AM, Eric

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Alexey Proskuryakov
03.10.2012, в 9:19, Eric Seidel e...@webkit.org написал(а): Perhaps make is missing? or the java directory its trying to build is missing and it's just printing the wrong path? Isn't make part of Xcode command line utilities? If that's the issue indeed, the fix is to change the script to use

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Dirk Pranke
Think Eric and Alexey identified the problem here ... -- Dirk On Wed, Oct 3, 2012 at 9:44 AM, Alexey Proskuryakov a...@webkit.org wrote: 03.10.2012, в 9:19, Eric Seidel e...@webkit.org написал(а): Perhaps make is missing? or the java directory its trying to build is missing and it's just

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Darin Adler
On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Eric Seidel
I should note that webkit-patch does do some magic to find it's checkout. Its possible it's somehow confused by your svn setup? I don't personally use the svn codepaths very often. In case this is useful, here is some more context on what webkitpy is trying to do: Most webkitpy clients,

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Dirk Pranke
On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote: On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing that command? Looks like a path confusion. My WebKit source tree is in

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Dirk Pranke
On Wed, Oct 3, 2012 at 4:18 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Oct 3, 2012 at 3:39 PM, Darin Adler da...@apple.com wrote: On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa rn...@webkit.org wrote: Could you tell us what your directory structure look like and where you're executing

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

2012-10-03 Thread Darin Adler
On Oct 3, 2012, at 4:18 PM, Dirk Pranke dpra...@chromium.org wrote: it's trying to run /usr/bin/make, -C /Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/LayoutTests/java] (approximately). It's probably bad that it's hardcoded to look in /usr/bin; is that your problem?