Re: [webkit-dev] WebCorePrefix.h vs. config.h

On Wed, Dec 12, 2018 at 7:07 AM Darin Adler wrote: > > On Dec 9, 2018, at 10:34 PM, Fujii Hironori > wrote: > > > > MSVC has /FI option. > > > > /FI (Name Forced Include File) | Microsoft Docs > > > https://docs.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=vs-2017

Re: [webkit-dev] WebCorePrefix.h vs. config.h

> On Dec 9, 2018, at 10:34 PM, Fujii Hironori wrote: > > MSVC has /FI option. > > /FI (Name Forced Include File) | Microsoft Docs > > https://docs.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=vs-2017 > > Unfortunately, it seems that MSVC's precompiled header

Re: [webkit-dev] WebCorePrefix.h vs. config.h

Subject: Re: [webkit-dev] WebCorePrefix.h vs. config.h On Sun, Dec 9, 2018 at 8:22 AM Darin Adler mailto:da...@apple.com>> wrote: Best would be to eliminate “config.h”: Change “config.h” into an empty file first, then remove all “config.h” includes, and then remove the file. But to do th

Re: [webkit-dev] WebCorePrefix.h vs. config.h

On Sun, Dec 9, 2018 at 8:22 AM Darin Adler wrote: > Best would be to eliminate “config.h”: Change “config.h” into an empty > file first, then remove all “config.h” includes, and then remove the file. > But to do that, we need to make sure every build system for WebKit supports > prefix headers.

Re: [webkit-dev] WebCorePrefix.h vs. config.h

CMake on Mac should not affect the decision here. I added that as a hack in http://trac.webkit.org/r172346 as part of an experimental project that isn’t being used by anyone. If we decide to resume CMake on Mac development and that has moved, we will find a better way to solve the same build

Re: [webkit-dev] WebCorePrefix.h vs. config.h

OK, here’s my answer after thinking on it a bit: Best would be to eliminate “config.h”: Change “config.h” into an empty file first, then remove all “config.h” includes, and then remove the file. But to do that, we need to make sure every build system for WebKit supports prefix headers. I don’t

Re: [webkit-dev] WebCorePrefix.h vs. config.h

> On Dec 8, 2018, at 2:56 PM, Darin Adler wrote: > >> On Dec 7, 2018, at 2:44 PM, Alexey Proskuryakov wrote: >> >> only keep config.h just to include WebCorePrefix for the lone build scenario >> where that's needed, and to undef new/delete? > > I think the answer likely lies here: What is

Re: [webkit-dev] WebCorePrefix.h vs. config.h

Useful background exists in Wikipedia: https://en.wikipedia.org/wiki/Prefix_header and https://en.wikipedia.org/wiki/Precompiled_header are relevant. Alexey, perhaps you know all of this already,

Re: [webkit-dev] WebCorePrefix.h vs. config.h

> On Dec 7, 2018, at 2:44 PM, Alexey Proskuryakov wrote: > > only keep config.h just to include WebCorePrefix for the lone build scenario > where that's needed, and to undef new/delete? I think the answer likely lies here: What is this lone build scenario where config.h is needed? — Darin