Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Hajime Morrita
(From the right address again...) On Sun, Mar 11, 2012 at 9:34 AM, Alp Toker a...@nuanti.com wrote: On 09/03/2012 03:52, Ami Fischman wrote: Hi webkittens, The over-all question: how should webkit libraries declare which symbols they export? The trigger for the question: as described in 

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Ami Fischman
I'm inclined to give this thread one more business day and then call it Tuesday morning pacific time. On current showing I think the approach in the patch on the bug (incl. morrita@'s preference for WEBCORE_EXPORT_PRIVATE) is the way to go, at least for now. If you have strong concerns please

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Adam Barth
On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischman fisch...@chromium.org wrote: I'm inclined to give this thread one more business day and then call it Tuesday morning pacific time. On current showing I think the approach in the patch on the bug (incl. morrita@'s preference for

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Adam Barth
On Sun, Mar 11, 2012 at 11:13 AM, Adam Barth aba...@webkit.org wrote: On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischman fisch...@chromium.org wrote: I'm inclined to give this thread one more business day and then call it Tuesday morning pacific time. On current showing I think the approach in the

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Alp Toker
On 11/03/2012 18:13, Adam Barth wrote: On Sun, Mar 11, 2012 at 10:49 AM, Ami Fischmanfisch...@chromium.org wrote: I'm inclined to give this thread one more business day and then call it Tuesday morning pacific time. On current showing I think the approach in the patch on the bug (incl.

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Ami Fischman
Responding to several emails below. Adam wrote: I'm not sure I understand your proposal fully. Specifically, how would these macros work for, say, the Chromium, Apple-Mac, and Apple-Win ports, which export overlapping, but not identical, sets of symbols? I do not have a proposal to unify

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Hajime Morrita
I found some confusion here. There are two kinds of symbols which need to be exported from WebCore. - A. Symbols from WebCore to WebKit(API). This is basically what WebCore.exp.in covers. - B. Symbols from WebCore to Application. In principle, there should be no such symbols. But in reality

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Adam Barth
On Sun, Mar 11, 2012 at 5:16 PM, Ami Fischman fisch...@chromium.org wrote: Adam wrote: I'm not sure I understand your proposal fully.  Specifically, how would these macros work for, say, the Chromium, Apple-Mac, and Apple-Win ports, which export overlapping, but not identical, sets of symbols?

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-11 Thread Ami Fischman
Hajime I chatted and it became clear that we've been miscommunicating. I'm taking that conversation off webkit-dev and putting this thread on hold pending that resolving. Sorry for the noise. Cheers, -a On Sun, Mar 11, 2012 at 5:54 PM, Hajime Morrita morr...@chromium.orgwrote: I found some

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-10 Thread Alp Toker
On 09/03/2012 03:52, Ami Fischman wrote: Hi webkittens, The over-all question: how should webkit libraries declare which symbols they export? The trigger for the question: as described in bug 80062 https://bugs.webkit.org/show_bug.cgi?id=80062, the chromium shared-library-based build links

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-10 Thread Martin Robinson
On Sat, Mar 10, 2012 at 4:34 PM, Alp Toker a...@nuanti.com wrote: If we follow this to the logical conclusion, no unification of granular export lists is realistic with the current WebKit porting layer. If the strategy were adapted to define exported functionality at class granularity, it

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-09 Thread Ami Fischman
Thanks for your reply, Morrita! For ports on approach C, it doesn't matter which WebCore/JSC API is used from WebKit API layer because they are built in the same library. If you mean that nothing in WebCore/JSC needs to be annotated as exported then I don't think that's right, because

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-09 Thread Dirk Pranke
On Thu, Mar 8, 2012 at 7:52 PM, Ami Fischman fisch...@chromium.org wrote: Hi webkittens, The over-all question: how should webkit libraries declare which symbols they export? The trigger for the question: as described in bug 80062, the chromium shared-library-based build links test code into

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-09 Thread Ryosuke Niwa
On Thu, Mar 8, 2012 at 10:32 PM, Hajime Morrita morr...@chromium.orgwrote: My personal preference is to introduce WebCore version of export macros like WK_EXPORT_PRIVATE. In this way, we could use it to get rid of WebCore.exp.in in the future. That sounds like a good idea. I hate having to

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-08 Thread Hajime Morrita
(From the right address...) Hi Ami, I don't think there is a consensus about that. Here is my understanding of the current status of the export symbol management: At first, each port has different way to split libraries. For example, - A) Mac port (WebKit1) splits WebKit into three frameworks: