Re: [webkit-dev] [webkit-changes] [47592] trunk/JavaScriptCore

2009-08-21 Thread Yong Li
I remember it happens to VC6. Seems VS2005 doesn't have this problem. -Yong - Original Message - From: Darin Adler da...@apple.com To: Yong Li yong...@torchmobile.com Cc: WebKit Development webkit-dev@lists.webkit.org Sent: Thursday, August 20, 2009 6:12 PM Subject: Re:

Re: [webkit-dev] [webkit-changes] [47610] trunk/WebCore

2009-08-21 Thread Adam Roben
On Aug 20, 2009, at 8:07 PM, bweinst...@apple.com wrote: +static inline int adjustedScrollDelta(int beginningDelta) { +// This implemention matches Firefox's. +// http://mxr.mozilla.org/firefox/source/toolkit/content/widgets/browser.xml#856 . Firefox's implementation is in

Re: [webkit-dev] Bugzilla Data Loss

2009-08-21 Thread Ryan Leavengood
On Fri, Aug 21, 2009 at 1:54 AM, Peter Kastingpkast...@google.com wrote: but patches that were merely attached to bugs have vanished. Hopefully you still have local copies and can re-attach them! This sort of thing tends to put a kibosh on some people's workflow of using bugzilla as a source

Re: [webkit-dev] Bugzilla Data Loss

2009-08-21 Thread David Kilzer
On Friday, August 21, 2009 at 7:59:11 AM, Ryan Leavengood wrote: On Fri, Aug 21, 2009 at 1:54 AM, Peter Kastingwrote: but patches that were merely attached to bugs have vanished. Hopefully you still have local copies and can re-attach them! This sort of thing tends to put a kibosh on

[webkit-dev] Building release on Windows Vista

2009-08-21 Thread Anton Muhin
Dear WebKit gurus, is it possible to build WebKit on Windows Vista in Release configuration? Both build from Cygwin and VS dies with: c:\WebKit\WebKit\WebKitBuild\lib\WebCore.lib : fatal error LNK1106: invalid file or disk full: cannot seek to 0x44DA4146 Clean build (wiping off WebKitBuild)

Re: [webkit-dev] Bugzilla Data Loss

2009-08-21 Thread Adam Barth
On Fri, Aug 21, 2009 at 7:59 AM, Ryan Leavengoodleaveng...@gmail.com wrote: This sort of thing tends to put a kibosh on some people's workflow of using bugzilla as a source control tool (as recently read in #webkit.) Well at least abarth does this. Fortunately, the stuff I was working on

Re: [webkit-dev] Building release on Windows Vista

2009-08-21 Thread Yong Li
I guess you've enabled link time optimization. The lib file is too big. The solution suggested by MS is to split the project. - Original Message - From: Anton Muhin ant...@chromium.org To: webkit-dev Development webkit-dev@lists.webkit.org Sent: Friday, August 21, 2009 12:03 PM

[webkit-dev] r45939 broke my workflow

2009-08-21 Thread Geoffrey Garen
Hi. r45939 broke my workflow. Here's the related bugzilla bug: https://bugs.webkit.org/show_bug.cgi?id=26999 . Old Roll out a patch workflow: cd JavaScriptCore svn-create-patch patch.txt svn-unapply patch.txt Old Roll in a patch workflow: cd JavaScriptCore svn-apply patch.txt These old

Re: [webkit-dev] r45939 broke my workflow

2009-08-21 Thread David Kilzer
Is there an easy fix to svn-apply and svn-unapply that you can make? I believe there is an easy fix for this particular workflow, which is to make svn-apply and svn-unapply behave the same way as svn-create-patch. https://bugs.webkit.org/show_bug.cgi?id=28623 Dave

[webkit-dev] svn-* scripts

2009-08-21 Thread Darin Adler
I’m a little irritated that we’re changing our Subversion scripts, svn- create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced Subversion in a non-project-specific way. I used the

Re: [webkit-dev] svn-* scripts

2009-08-21 Thread Joseph Pecoraro
On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced

Re: [webkit-dev] svn-* scripts

2009-08-21 Thread Jeremy Orlow
On Fri, Aug 21, 2009 at 5:57 PM, Joseph Pecoraro joepec...@gmail.comwrote: On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were

Re: [webkit-dev] svn-* scripts

2009-08-21 Thread Maciej Stachowiak
On Aug 21, 2009, at 6:15 PM, Jeremy Orlow wrote: On Fri, Aug 21, 2009 at 5:57 PM, Joseph Pecoraro joepec...@gmail.com wrote: On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into

Re: [webkit-dev] svn-* scripts

2009-08-21 Thread David Kilzer
On Friday, August 21, 2009 at 5:32:14 PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that