[webkit-dev] ENABLE(INSPECTOR) check in Console::lastWMLErrorMessage
Hi, Looks like it should add ENABLE(INSPECTOR) check in Console::lastWMLErrorMessage() (/trunk/WebCore/page/Console.cpp) Thanks. Regards Ryan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Disabling the JIT
Just curious, how would you verify if JavaScript in your browser has JIT support or not? On Tue, Apr 27, 2010 at 3:10 PM, Nyx wrote: > > >> Another way would be to set export QMAKEARGS="$QMAKEARGS > DEFINES+=ENABLE_JIT=0" before building. > > Ok. I tried this approach. I have a build script that looks like this: > > QTDIR=/usr/share/qt4/ > export QMAKEARGS="$QMAKEARGS DEFINES+=ENABLE_JIT=0" > WebKit/WebKitTools/Scripts/build-webkit --qt > > It builds, but the JIT is not disabled. It seems that the new argument is > simply ignored. > > I also tried adding "#define ENABLE_JIT 0" at the top of the > Interpreter.cpp > file in JavaScriptCore. This builds, but produces a segmentation fault. > > I will try doing the "WebKit/WebKitTools/Scripts/build-webkit --qt > JAVASCRIPTCORE_JIT=no" with a fresh SVN checkout... Is there any equivalent > of make clean script, as a completment to build-webkit? > -- > View this message in context: > http://old.nabble.com/Disabling-the-JIT-tp28378562p28382091.html > Sent from the Webkit mailing list archive at Nabble.com. > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > -- -- chinmaya sn ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] policy on perf/memory regressions?
The policy has never been clearly defined but in most cases follow this rule. Upon discovering the perf. regression a P1 bug is filed. It is expected that the bug will be a top priority, and handled in a timely manner. With the exception of very large perf. regressions, we rarely roll patches out. With very few exceptions (heavily discussed), it is never acceptable to check in something that will regress performance with no expectations of fixing it. In general, when PLT regressions happen I often ask someone internally to look at it or work closely with the contributor to test. It is rather unfair to ask someone to fix a regression they can't test. While we strictly enforce the the zero regression policy internally, because many of the tests are painful to set up or not available externally we are not as strict with external contributions. If Chromium has perf. tests they would like to share with us, I'd be willing to work with someone to learn those tests. -- Stephanie On Apr 28, 2010, at 3:30 PM, Ojan Vafai wrote: > Do we have a policy on perf/memory regressions? I've been told that there's a > "zero-regression" policy for page load tests. Is that actually the case? What > about cases that are clear perf regressions that don't show up in PLT (e.g. > they show up in one of the Chromium page load tests and/or on a real-world > web page)? > > Perf and memory regressions seem much worse to me than test failures. Unlike > test failures, there's isn't a binary right or wrong. If a patch regresses > performance and then other patches come in that further improve/regress > performance, it becomes nearly impossible to tell if the fix for the original > patch actually addresses the entirety of the original regression. > > The only case I can think of where perf regressions might be ok are: > 1. The fix will be checked in reasonably soon (hours, not days/weeks). This > matches our policy with failing tests. > 2. We think there's no way to address the perf/memory regression and that the > new functionality justifies it. This is extremely rare. > > I'm asking because I've had considerable pushback dealing with a recent > perf/memory regression on OS X that's been sitting in the tree for 3 weeks. > I'm not linking to the bug in question because that issue is resolved. This > is forward looking. I'd like to see us have a written down policy. Ideally, > one day, we'll also have bots that run perf/memory tests and turn red when > there is a regression. > > Ojan > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] policy on perf/memory regressions?
Do we have a policy on perf/memory regressions? I've been told that there's a "zero-regression" policy for page load tests. Is that actually the case? What about cases that are clear perf regressions that don't show up in PLT (e.g. they show up in one of the Chromium page load tests and/or on a real-world web page)? Perf and memory regressions seem much worse to me than test failures. Unlike test failures, there's isn't a binary right or wrong. If a patch regresses performance and then other patches come in that further improve/regress performance, it becomes nearly impossible to tell if the fix for the original patch actually addresses the entirety of the original regression. The only case I can think of where perf regressions might be ok are: 1. The fix will be checked in reasonably soon (hours, not days/weeks). This matches our policy with failing tests. 2. We think there's no way to address the perf/memory regression and that the new functionality justifies it. This is extremely rare. I'm asking because I've had considerable pushback dealing with a recent perf/memory regression on OS X that's been sitting in the tree for 3 weeks. I'm not linking to the bug in question because that issue is resolved. This is forward looking. I'd like to see us have a written down policy. Ideally, one day, we'll also have bots that run perf/memory tests and turn red when there is a regression. Ojan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Function & Property Names
> However, this does not report the function names > correctly. What happens instead? Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Function & Property Names
I'm in the process of writing a program to analyze traces of JavaScript code.
This involves logging events that occur in the interpreter. Currently, I'm
trying to just log function calls and property accesses. However, I'm unsure
exactly how to go about getting the names (identifiers) associated with
functions (and properties).
I wrote the following piece of code just to test things out, which I
inserted in Interpreter.cpp, in the definition of the op_call opcode, after
the "vPC = newCodeBlock->instructions().begin();" line:
JSGlobalObject* globalObject = callFrame->scopeChain()->globalObject;
printf("Function call: %s\n",
asFunction(v)->name(globalObject->globalExec()).ascii());
printf("%s\n", newCodeBlock->ownerExecutable()->sourceURL().ascii());
printf("%i\n", newCodeBlock->ownerExecutable()->lineNo());
My goal was to report the name of the function being called each time an
op_call is executed. However, this does not report the function names
correctly. My guess is that I'm passing the wrong value to
InternalFunction::name(). Can anyone tell me what I'm doing wrong here? I'm
rather unfamiliar with the WebKit code.
--
View this message in context:
http://old.nabble.com/Function---Property-Names-tp28394250p28394250.html
Sent from the Webkit mailing list archive at Nabble.com.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] QtWebkit vs GtkWebkit
I am involved - as a user of webkit, helping find bugs that others may not have discovered. Unfortunately, I don't know my way around the innards of QtWebkit, so I am posting here in the hope that others who do, may have a solution. Thanks for your comments. Cheers, ---AK From: Evan Martin To: Phoenix Revived Cc: Chinmaya Sn ; webkit-dev@lists.webkit.org Sent: Tue, April 27, 2010 10:30:22 AM Subject: Re: [webkit-dev] QtWebkit vs GtkWebkit On Tue, Apr 27, 2010 at 9:14 AM, Phoenix Revived wrote: > Yes, I have tried this on several versions of Ubuntu, including Lucid. > I don't have Windows machine so I can't try that. There is not a single > instance of a QtWebKit browser (or my own snippet of QtWebKit code) that > works - and 100% of every GtkWebKit browsers (and my own snippet of > GtkWebKit code) that works on my Linux system. > > This is forcing me to create a hybrid application written in Qt, with the > webkit portion being handled in Gtk - which, I am sure I don't need to > inform anyone, is a royal pain in the ass. > > If I am missing something obvious, I would appreciate a hint. The best candidate for something obvious you overlooked is the "Getting Involved" heading on the webkit.org site! :) >From your diagnosis it sounds like perhaps either WebKitQt is lacking support for these plugins (or possibly there's a misconfiguration or something). Rather than the "royal pain" of working around it, why not fix WebKitQt? From a grep in the WebKitQt plugin code it does look like it has some preliminary bit of Gtk support. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
On Wed, Apr 28, 2010 at 3:53 PM, İsmail Dönmez wrote: > On Wed, Apr 28, 2010 at 5:52 PM, Alex Milowski wrote: >> >> On Wed, Apr 28, 2010 at 3:11 PM, İsmail Dönmez wrote: >> > >> > I wonder if it'll work fine since MathML also needs strong font support. >> >> Font support is still an issue on all platforms. The STIX fonts that I've >> gotten ahold of are terrible. Maybe when they ship they'll be better. >> > > Uh, they are supposed to be the best math fonts available :-) That's the rumor. I'll wait and see what they look like when they are officially released. So far, the fonts I've been playing with (beta versions) have some obvious errors for operators. It is unclear when they will be officially released. -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
On Wed, Apr 28, 2010 at 5:52 PM, Alex Milowski wrote: > On Wed, Apr 28, 2010 at 3:11 PM, İsmail Dönmez wrote: > > > > I wonder if it'll work fine since MathML also needs strong font support. > > Font support is still an issue on all platforms. The STIX fonts that I've > gotten ahold of are terrible. Maybe when they ship they'll be better. > > Uh, they are supposed to be the best math fonts available :-) > It is likely that the CSS will have to be customized on each > platform to pick the correct "expected" font from the system. Indeed this makes more sense for the short term. Regards, ismail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
On Wed, Apr 28, 2010 at 3:11 PM, İsmail Dönmez wrote: > > I wonder if it'll work fine since MathML also needs strong font support. Font support is still an issue on all platforms. The STIX fonts that I've gotten ahold of are terrible. Maybe when they ship they'll be better. It is likely that the CSS will have to be customized on each platform to pick the correct "expected" font from the system. -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] interesting "time-lapse" photo
Came across is an interesting pseudo time lapse of nightfall in the Hong Kong this morning: http://61226.com/share/hk.swf. Instead of a using a true time-lapse image sequence, this uses just two photos, a mask, and opacity manipulation for a fairly convincing effect. The author used Flash, but I am sure the same thing could be done with CSS. Could WebGL add something interesting? For the experimenters in the crowd, the images used are http://i71.photobucket.com/albums/i141/kyfung01/61226/day.jpg http://i71.photobucket.com/albums/i141/kyfung01/61226/night.jpg http://i71.photobucket.com/albums/i141/kyfung01/61226/shadow.jpg eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
On Wed, Apr 28, 2010 at 5:10 PM, Alex Milowski wrote: > On Wed, Apr 28, 2010 at 1:14 PM, İsmail Dönmez wrote: > > Did anyone tested it on Qt port? Just curious... > > No, not yet. I haven't setup a Qt build for myself quite yet (just > Mac & Gtk). > > That actually might be easier to do than Windows. :) > > I'll look into that today or tomorrow. I wonder if it'll work fine since MathML also needs strong font support. Regards, ismail ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
On Wed, Apr 28, 2010 at 1:14 PM, İsmail Dönmez wrote: > Did anyone tested it on Qt port? Just curious... No, not yet. I haven't setup a Qt build for myself quite yet (just Mac & Gtk). That actually might be easier to do than Windows. :) I'll look into that today or tomorrow. -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
Did anyone tested it on Qt port? Just curious... Regards, ismail On Wed, Apr 28, 2010 at 3:13 PM, Sausset François wrote: > I'm also involved in implementing MathML and I share the Alex advice. > MathML implementation has been asleep for too long. Turning it on by > default should accelerate the recent progress. > > François Sausset > > > Le 28 avr. 2010 à 14:40, Alex Milowski a écrit : > > > With the latest patch (37044) having been committed, I feel like we're at > > a point where I'd like the MathML implementation to be available in > > the nightly builds. The code has been built and tested successfully on > the > > Mac and Gtk builds. I intend to look at the windows build next. > > > > We have a growing community of developers and interested users and > > having a nightly build with MathML would allow testing, submission of > > issues, and receipt of fixes. > > > > What do others think? > > > > -- > > --Alex Milowski > > "The excellence of grammar as a guide is proportional to the paucity of > the > > inflexions, i.e. to the degree of analysis effected by the language > > considered." > > > > Bertrand Russell in a footnote of Principles of Mathematics > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Turning on MathML by Default?
I'm also involved in implementing MathML and I share the Alex advice. MathML implementation has been asleep for too long. Turning it on by default should accelerate the recent progress. François Sausset Le 28 avr. 2010 à 14:40, Alex Milowski a écrit : > With the latest patch (37044) having been committed, I feel like we're at > a point where I'd like the MathML implementation to be available in > the nightly builds. The code has been built and tested successfully on the > Mac and Gtk builds. I intend to look at the windows build next. > > We have a growing community of developers and interested users and > having a nightly build with MathML would allow testing, submission of > issues, and receipt of fixes. > > What do others think? > > -- > --Alex Milowski > "The excellence of grammar as a guide is proportional to the paucity of the > inflexions, i.e. to the degree of analysis effected by the language > considered." > > Bertrand Russell in a footnote of Principles of Mathematics > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Turning on MathML by Default?
With the latest patch (37044) having been committed, I feel like we're at a point where I'd like the MathML implementation to be available in the nightly builds. The code has been built and tested successfully on the Mac and Gtk builds. I intend to look at the windows build next. We have a growing community of developers and interested users and having a nightly build with MathML would allow testing, submission of issues, and receipt of fixes. What do others think? -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Trouble reviewing patches since the experimental commenting support went into bugs.webkit.org's action=review page
On 22.04.10 22.18, Andrew Scherkus wrote: On Thu, Apr 22, 2010 at 1:13 PM, Adam Roben mailto:aro...@apple.com>> wrote: On Apr 22, 2010, at 4:01 PM, Darin Adler wrote: > - The comments all cite only a single line of the patch and I almost never have a comment that's for a single line. So I have to do a lot of editing, pretending to comment on multiple lines. I think it would be nice if you could drag to select multiple lines of code. When you release the mouse button, the comment box would appear, and when you commit that comment all the lines you selected would be quoted. The other person who I was working with had this feature implemented, but I forget his name and didn't grab his email. I hope he reads webkit-dev :\ That would be me :) The quick-hack prototype [1] was based on jQuery, with the selectable plugin. Dunno if Prototype has something similar, I can have a look. What about the "draft" mode, do we want inline comments to be built up and then moved to the main comment field in one go when you're satisfied with the review and click some button, or instantly like now? Tor Arne [1] http://torarnv.github.com/review2/bar.html ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
