[webkit-dev] Gtk 32-bit Release Bot Wedged

2010-05-20 Thread Eric Seidel
The Gtk 32-bit Release bot has wedged itself. If someone could kick it that would be grand: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r59822%20(13001)/results.html Do we understand why this happens so we can prevent it in the future (this is not the first time)? -eric

Re: [webkit-dev] Gtk 32-bit Release Bot Wedged

2010-05-20 Thread Gustavo Noronha Silva
On Thu, 2010-05-20 at 00:20 -0700, Eric Seidel wrote: The Gtk 32-bit Release bot has wedged itself. If someone could kick it that would be grand: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r59822%20(13001)/results.html Do we understand why this happens so we can prevent

[webkit-dev] Bytecode Sequence for function.apply()

2010-05-20 Thread Nyx
I've been working on a tool to generate a trace of JavaScript executions, built on JavaScriptCore. I'm trying to log calls to all functions and their arguments. To do this, I've instrumented the op_call and op_call_varargs bytecodes in Interpreter.cpp. The problem I'm having is that if someone

Re: [webkit-dev] Table hit testing

2010-05-20 Thread Fady Samuel
So I have an implementation that seems to be working (still testing edge cases). I found that m_grid, in RenderTableSection, is a VectorRowStruct and each RowStruct contains a row which knows about the columns of that row. Thus this is effectively a dense 2D table of Cells. I use this for hit

Re: [webkit-dev] Bytecode Sequence for function.apply()

2010-05-20 Thread Oliver Hunt
If you have a debug build of jsc, you can run 'jsc -d' and that will dump the generated bytecode --Oliver On May 20, 2010, at 8:42 AM, Nyx wrote: I've been working on a tool to generate a trace of JavaScript executions, built on JavaScriptCore. I'm trying to log calls to all functions and

Re: [webkit-dev] Table hit testing

2010-05-20 Thread David Hyatt
You can't binary search if there are overflowing cells in any section. You have to go in order (from last to first) in that case, since you may hit test something. In general you won't find binary searches, etc. in most hit testing code because of overflow concerns.

Re: [webkit-dev] Gtk 32-bit Release Bot Wedged

2010-05-20 Thread Eric Seidel
Thank you. Maybe run-webkit-tests should check to make sure plusaudio is around before running? Or is that specific to that machine's config? Thank you for looking into it. -eric On Thu, May 20, 2010 at 7:12 AM, Gustavo Noronha Silva g...@gnome.org wrote: On Thu, 2010-05-20 at 00:20 -0700,

Re: [webkit-dev] Gtk 32-bit Release Bot Wedged

2010-05-20 Thread Adrian Perez
On Thu, 20 May 2010 11:12:01 -0300 Gustavo Noronha Silva g...@gnome.org wrote: On Thu, 2010-05-20 at 00:20 -0700, Eric Seidel wrote: The Gtk 32-bit Release bot has wedged itself. If someone could kick it that would be grand:

Re: [webkit-dev] Table hit testing

2010-05-20 Thread Fady Samuel
CSS is Awesome indeed :P So are you against fast paths? It seems if we don't have overflow, we can do binary searches for hit testing, right? Unless I'm yet again missing something fundamental? Sorry about that. :P Fady On Thu, May 20, 2010 at 2:56 PM, David Hyatt hy...@apple.com wrote: You

Re: [webkit-dev] Gtk 32-bit Release Bot Wedged

2010-05-20 Thread Eric Seidel
On Thu, May 20, 2010 at 12:54 PM, Eric Seidel esei...@google.com wrote: We have various other bot support tools checked in under: http://trac.webkit.org/browser/trunk/WebKitTools/BuildSlaveSupport/ and http://trac.webkit.org/browser/trunk/WebKitTools/EWSTools You should feel encouraged to

Re: [webkit-dev] Table hit testing

2010-05-20 Thread David Hyatt
On May 20, 2010, at 3:07 PM, David Hyatt wrote: If we could properly detect those degenerate cases, then you could probably get away with binary search, but until we do that, I don't think you can. Here's an example: STYLE TD:hover { color: green } /STYLE TABLE border=1 TRTD1 TD2 TD3 TRTD4

Re: [webkit-dev] Table hit testing

2010-05-20 Thread Fady Samuel
So what are the rules for stacking here? do the cells stack in the order in which they appear in the HTML? Cell 7 is defined after cell 5 and therefore it owns that position? Thanks, Fady On Thu, May 20, 2010 at 4:18 PM, David Hyatt hy...@apple.com wrote: On May 20, 2010, at 3:07 PM, David

Re: [webkit-dev] Table hit testing

2010-05-20 Thread Fady Samuel
I'm still confused about the proper ordering of painting/hit testing cells for a given grid position. In the example you provided, David, WHY does cell 7 have precedence over cell 5? Is it based on the order they're defined? Thanks, Fady On Thu, May 20, 2010 at 4:47 PM, Peter Kasting

Re: [webkit-dev] Table hit testing

2010-05-20 Thread David Hyatt
On May 20, 2010, at 3:52 PM, Fady Samuel wrote: I'm still confused about the proper ordering of painting/hit testing cells for a given grid position. In the example you provided, David, WHY does cell 7 have precedence over cell 5? Is it based on the order they're defined? Yes, it's

Re: [webkit-dev] Table hit testing

2010-05-20 Thread David Hyatt
On May 20, 2010, at 3:38 PM, Fady Samuel wrote: So what are the rules for stacking here? do the cells stack in the order in which they appear in the HTML? Correct, although note that backgrounds paint behind foregrounds, and hit testing works the same way, so it's not as simple as saying

[webkit-dev] Client side JavaScript i18n API proposal

2010-05-20 Thread Nebojša Ćirić
There are a number of areas where JavaScript i18n APIs are deficient. Our goal is to develop better client-side i18n API for JavaScript, and eliminate need for big JavaScript libraries or server side processing. Eventually, we want to make them a part of WebAPI (worked on by WebApp WG). Our

Re: [webkit-dev] Client side JavaScript i18n API proposal

2010-05-20 Thread Oliver Hunt
It seems like the majority of this belongs in EcmaScript directly rather than being restricted to web-oriented uses of ES. I'm also unsure of the relevance of CommonJS to either WebAPI or ES as CommonJS is not part of either standards body. For example the use of require implies making

[webkit-dev] Style question: static, protected, or public members

2010-05-20 Thread TAMURA, Kent
What's the naming rule for non-const static members? Some classes give s_ prefixes: WebCore/page/DOMTimer.h:static double s_minTimerInterval; WebCore/page/GeolocationPositionCache.h:static int s_instances; FrameView gives s prefix: WebCore/page/FrameView.h:static double