On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote:
I actually do not like the way the review flags are cleared today only in
order to make the tools and pending-xxx pages happier. IMO the review flags
give much about the history of the bug. In that matter, I dislike
webkit-patch's ways of
The arguments about abandoning PassRefPtr for arguments entirely are attacking
a straw man. We know PassRefPtr offers an important optimization and do not
want to drop that!
On Jun 18, 2011, at 10:58 PM, Maciej Stachowiak wrote:
(1) Use PassRefPtr for every parameter that takes ownership.
I
On Sun, Jun 19, 2011 at 12:48 PM, Darin Adler da...@apple.com wrote:
Con (of abandoning PassRefPtr for function arguments entirely):
Possible accidental freed memory access bugs.
I think the reverse of this Con is one of the stronger Pro arguments for
using PassRefPtr even more for
On Jun 19, 2011, at 2:03 PM, Ryosuke Niwa wrote:
One of the most common security bugs I have seen in editing is that we keep a
raw pointer to a node and call some helper method that modifies DOM
(therefore invoking scripts).
I'm sometimes tempted to replace all instances of Node* in the
Hi Darin. Few comments inlined.
On Sun, Jun 19, 2011 at 2:31 PM, Darin Adler da...@apple.com wrote:
On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote:
I actually do not like the way the review flags are cleared today only in
order to make the tools and pending-xxx pages happier. IMO the
On Sun, Jun 19, 2011 at 2:05 PM, Darin Adler da...@apple.com wrote:
On Jun 19, 2011, at 2:03 PM, Ryosuke Niwa wrote:
One of the most common security bugs I have seen in editing is that we
keep a raw pointer to a node and call some helper method that modifies DOM
(therefore invoking
On Sun, Jun 19, 2011 at 11:31 AM, Darin Adler da...@apple.com wrote:
On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote:
I actually do not like the way the review flags are cleared today only in
order to make the tools and pending-xxx pages happier. IMO the review flags
give much about the
Personally, I like this pattern a lot.
Would it also be helpful when sheriff bot rolls out a patch to attach the
rolled out patch with a nice description like ROLLOUT(rX) to the bug?
On Sun, Jun 19, 2011 at 8:36 PM, Eric Seidel e...@webkit.org wrote:
On Sun, Jun 19, 2011 at 11:31 AM, Darin
It might get a little squirrelly to have things like:
LANDED(12345): REVERTED(12344): LANDED(12343): Patch
But I'm happy to write up the patches to make it so.
-eric
On Sun, Jun 19, 2011 at 6:32 PM, Antonio Gomes toniki...@gmail.com wrote:
Personally, I like this pattern a lot.
Would it
Hi,
We have to implement *HbbTV *specification using WebKit.
We have no idea to integrate *HbbTV *with WebKit.
So please advice us, below queries for developing *HbbTV*.
1. How to add new HTML tags and attributes in WebKit?
2. How to add new styles in WebKit?
3. How to add new class,method
10 matches
Mail list logo
