On Tue, Nov 8, 2011 at 7:06 AM, Elliot Poger wrote:
> I have just run "Tools/Scripts/webkit-patch rebaseline-expectations". There
> are plenty of image rebaseline changes ("svn status" yields 792 lines!), but
> I'm not seeing the promised html page to compare old and new baselines.
Correct. It
I believe that tool just got nuked. Seems the Wiki page should as well:
https://bugs.webkit.org/show_bug.cgi?id=71833
On Tue, Nov 8, 2011 at 9:09 AM, Adam Barth wrote:
> On Tue, Nov 8, 2011 at 7:06 AM, Elliot Poger wrote:
>> I have just run "Tools/Scripts/webkit-patch rebaseline-expectations".
Perhaps I should approach this from a different angle:
What is the recommended procedure for:
- generating new baseline images for a few dozen failing tests, on various
platforms
- visually inspecting them to make sure they're not bogus
- committing them, along with test_expectations changes, to t
Perhaps I should approach this from a different angle:
What is the recommended procedure for:
- generating new baseline images for a few dozen failing tests, on various
platforms
- visually inspecting them to make sure they're not bogus
- committing them, along with test_expectations changes, to t
On Tue, Nov 8, 2011 at 12:00 PM, Elliot Poger wrote:
> Perhaps I should approach this from a different angle:
>
> What is the recommended procedure for:
> - generating new baseline images for a few dozen failing tests, on various
> platforms
>
webkit-patch rebaseline-expectations
> - visually
On Tue, Nov 8, 2011 at 12:20 PM, Tony Chang wrote:
> On Tue, Nov 8, 2011 at 12:00 PM, Elliot Poger wrote:
>> Perhaps I should approach this from a different angle:
>> What is the recommended procedure for:
>> - generating new baseline images for a few dozen failing tests, on various
>> platforms
-- Forwarded message --
From: Ryosuke Niwa
Date: Tue, Nov 8, 2011 at 12:25 PM
Subject: Re: [webkit-dev] "Tools/Scripts/webkit-patch
rebaseline-expectations" does not launch html comparison page?
To: Tony Chang
Cc: Elliot Poger , James Kozianski ,
webkit-dev@lists.webkit.org, Mike
On Tue, Nov 8, 2011 at 12:24 PM, Adam Barth wrote:
> On Tue, Nov 8, 2011 at 12:20 PM, Tony Chang wrote:
>> On Tue, Nov 8, 2011 at 12:00 PM, Elliot Poger wrote:
>>> Perhaps I should approach this from a different angle:
>>> What is the recommended procedure for:
>>> - generating new baseline imag
On Tue, Nov 8, 2011 at 12:31 PM, Dirk Pranke wrote:
> On Tue, Nov 8, 2011 at 12:24 PM, Adam Barth wrote:
>> On Tue, Nov 8, 2011 at 12:20 PM, Tony Chang wrote:
>>> On Tue, Nov 8, 2011 at 12:00 PM, Elliot Poger wrote:
Perhaps I should approach this from a different angle:
What is the re
How do the gardeners do the rebaselining currently? It seems like what I'm
looking for is pretty much akin to gardening...
I have looked at
http://www.chromium.org/developers/how-tos/webkit-gardening, but I
have no idea if it is current.
On Tue, Nov 8, 2011 at 3:31 PM, Dirk Pranke wrote:
> On
On Tue, Nov 8, 2011 at 1:00 PM, Elliot Poger wrote:
> How do the gardeners do the rebaselining currently? It seems like what I'm
> looking for is pretty much akin to gardening...
They use garden-o-matic, which displays the diffs prior to conducting
the rebaseline.
> I have looked at http://www.
A week or two ago, Adam Barth elected to remove my WinCairo build bot
from the list of core builders. In the check-in comment, he noted that
the WinCairo bot rarely built, and was never green.
I do not agree with either of these statements -- the WinCairo build
bot had been green for a number of w
What makes Brent's statement even more understanable is that since the last
three weeks I've been waiting for a "green" state on at least a few bots to
land a test, and it simply has not happened. All bots, including Apple's
and Chromium's have been red for a while, and a "green state" spot seems
l
The Core Builders are a failed experiment (for which I am guilty).
They were intended as a set of builders which when green would allow
the CommitQueue to commit. This was long before the CommitQueue knew
how to commit when the bots were red (like real humans do).
I know of no set of builders @ b
Furthermore, it seems the only solution which (sorta) works for
keeping a port building is to have an EWS bot. I recommend that any
port which wishes to keep its bot building add one. :)
A while back we disabled the SheriffBot's "you might have broken the
build" commenting in bugs and over IRC, a
Yeah, we should just delete the concept. I'm tired of explaining to
folks that a bot that hasn't compiled in a weeks doesn't quality as a
core builder.
Adam
On Tue, Nov 8, 2011 at 7:38 PM, Eric Seidel wrote:
> The Core Builders are a failed experiment (for which I am guilty).
> They were inten
> On Nov 8, 2011, at 7:38 PM, Eric Seidel wrote:
>
> The Core Builders are a failed experiment (for which I am guilty).
> They were intended as a set of builders which when green would allow
> the CommitQueue to commit. This was long before the CommitQueue knew
> how to commit when the bots were
I wrote up a wiki page that I hope answers your questions:
http://trac.webkit.org/wiki/Core%20Builders
Adam
On Tue, Nov 8, 2011 at 5:09 PM, Brent Fulgham wrote:
> A week or two ago, Adam Barth elected to remove my WinCairo build bot
> from the list of core builders. In the check-in comment, he
18 matches
Mail list logo
