Re: [webkit-dev] Existing metrics for deprecated features
On Thu, Sep 13, 2012 at 10:58 PM, Pavel Feldman wrote: > On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth wrote: >> In connection with the thread on webkitPostMessage, I took a look at >> what sorts of metrics we have currently for depreciated features. We >> have high quality data for two groups of APIs: >> >> For mutation events, we measure what percent of Documents have >> listeners for various kinds of mutation events: >> >> DOMAPI.PerDocumentMutationEventUsage.DOMCharacterDataModified: 2.85% >> of all Documents >> DOMAPI.PerDocumentMutationEventUsage.DOMNodeInserted: 4.78% of all >> Documents >> DOMAPI.PerDocumentMutationEventUsage.DOMNodeInsertedIntoDocument: >> 0.21% of all Documents >> DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemoved: 0.07% of all >> Documents >> DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemovedFromDocument: >> 0.0003% of all Documents >> DOMAPI.PerDocumentMutationEventUsage.DOMSubtreeModified: 2.30% of all >> Documents >> >> From this data, it's tempting to remove support for DOMNodeRemoved and >> DOMNodeRemovedFromDocument as those are used extremely rarely. We >> don't have any data for how much of this usage is attributable to >> extensions. It will be interesting to watch this data as we >> evangelize MutationObservers, especially among extension developers. > > Is there an absolute number for those 0.07%? There is, but I'm not able to share the absolute number publicly. I suspect you have access to the metrics yourself. You can look at the histograms with those names. > How is it calculated? It is calculated by this code: http://trac.webkit.org/browser/trunk/Source/WebCore/dom/Document.cpp#L584 Basically, when a document is destructed, we look to see whether there are event listeners of these types. I'm not sure that's the optimal way to measure the usage of these events, but that's the data we have currently. > Like Web > Inspector has been using DOMNodeRemoved for its viewport-based text editor > until very recently, so your 0.07% is likely to include millions of users. > Is that expected? The data is per-Document, not per user data. In general, there is no way to convert from one to the other. You know the phrase "lies, damn lies, and statistics"? If we're going to make these sorts of decisions based on metrics, we should make sure we're measuring the right things. > I wonder what will the drop be with the next major Chrome release. This is data from the Stable channel on Windows, which is currently Chrome 21. There's also data from the Beta channel, which you or I could look up if you think that would make a difference. Adam >> Another metric we have is for Blob.webkitSlice: >> >> Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% >> Ratio of Blob.webkitSlice calls to Document creation: 0.0053% >> >> It's difficult to know how to interpret this data because we don't >> actually correlate calls to webkitSlice with Documents or Pages. >> Instead, we just count the total number of calls across all Documents. >> This gives us an upper bound on how many Documents (or Pages) would >> be affected by deleting Blob.webkitSlice, but doesn't measure that >> information as accurately as the data we have for mutation events. >> >> We are also gathering metrics on the usage of vendor prefixes in CSS >> properties, but that histogram doesn't appear to have been in the >> field long enough to have meaningful data. >> >> Adam >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)
> > > By the way, in preparing the patch, I noticed that webkitSlice was > used by the web inspector. Note that the data above includes the use > by the web inspector. > > The usage was in the heap profiler's load snapshot routines, so I can imagine it not being invoked a lot. That matches the stats fine. We'll follow up on it. Regards Pavel > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Existing metrics for deprecated features
On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth wrote: > In connection with the thread on webkitPostMessage, I took a look at > what sorts of metrics we have currently for depreciated features. We > have high quality data for two groups of APIs: > > For mutation events, we measure what percent of Documents have > listeners for various kinds of mutation events: > > DOMAPI.PerDocumentMutationEventUsage.DOMCharacterDataModified: 2.85% > of all Documents > DOMAPI.PerDocumentMutationEventUsage.DOMNodeInserted: 4.78% of all > Documents > DOMAPI.PerDocumentMutationEventUsage.DOMNodeInsertedIntoDocument: > 0.21% of all Documents > DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemoved: 0.07% of all Documents > DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemovedFromDocument: > 0.0003% of all Documents > DOMAPI.PerDocumentMutationEventUsage.DOMSubtreeModified: 2.30% of all > Documents > > From this data, it's tempting to remove support for DOMNodeRemoved and > DOMNodeRemovedFromDocument as those are used extremely rarely. We > don't have any data for how much of this usage is attributable to > extensions. It will be interesting to watch this data as we > evangelize MutationObservers, especially among extension developers. > Is there an absolute number for those 0.07%? How is it calculated? Like Web Inspector has been using DOMNodeRemoved for its viewport-based text editor until very recently, so your 0.07% is likely to include millions of users. Is that expected? I wonder what will the drop be with the next major Chrome release. > Another metric we have is for Blob.webkitSlice: > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% > > It's difficult to know how to interpret this data because we don't > actually correlate calls to webkitSlice with Documents or Pages. > Instead, we just count the total number of calls across all Documents. > This gives us an upper bound on how many Documents (or Pages) would > be affected by deleting Blob.webkitSlice, but doesn't measure that > information as accurately as the data we have for mutation events. > > We are also gathering metrics on the usage of vendor prefixes in CSS > properties, but that histogram doesn't appear to have been in the > field long enough to have meaningful data. > > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)
On Thu, Sep 13, 2012 at 9:05 PM, Maciej Stachowiak wrote: > On Sep 13, 2012, at 11:15 PM, Darin Fisher wrote: > On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote: >> On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: >> > Another metric we have is for Blob.webkitSlice: >> > >> > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% >> > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% >> > >> > It's difficult to know how to interpret this data because we don't >> > actually correlate calls to webkitSlice with Documents or Pages. >> > Instead, we just count the total number of calls across all Documents. >> > This gives us an upper bound on how many Documents (or Pages) would >> > be affected by deleting Blob.webkitSlice, but doesn't measure that >> > information as accurately as the data we have for mutation events. >> >> Based on this data, I've posted a patch for removing Blob.webkitSlice >> in favor of Blob.slice: >> >> https://bugs.webkit.org/show_bug.cgi?id=96715 >> >> Adam > > > So, worst case 53 out of a million pages calls webkitSlice. But, it is easy > to imagine that that upper bound is crazy high, and more likely a couple > pages simply call webkitSlice a lot. Also, given that there are so many > more calls to Blob.slice() one could imagine that sites that call > webkitSlice probably have fallback to Blob.slice(). Is this the hypothesis? > > > Adam's data measures webkitSlice() *calls*, not just appearances of the > symbol, so these are either sites that have fallback in the wrong direction > (trying the prefixed version before the vanilla version), or would break > after the removal. I've seen both problems with about similar frequency in > the past, so a decent hypothesis is that half those webkitSlice calls will > break. > > Safari hasn't had Blob for very long at all, so Chrome is probably more > impacted. From my own perspective, I think the usage is low enough that it's > worth making the change to see the fallout. > > I wonder also how likely it is that some of the webkitSlice uses are on > Google-controlled Web properties and therefore could be fixed ahead of time. By the way, in preparing the patch, I noticed that webkitSlice was used by the web inspector. Note that the data above includes the use by the web inspector. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura
Congrats Yuta. -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of TAMURA, Kent Sent: Friday, September 14, 2012 11:57 AM To: WebKit Development Subject: [webkit-dev] New WebKit reviewer: Yuta Kitamura I'd like to announce that Yuta Kitamura is now a WebKit reviewer. He has contributed to WebKit project for three years mainly in WebSocket area. He is a trustworthy authority on WebSocket area. If you worked on WebSocket issues, please involve him. -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura
Wow, congratulation Yuta :-) Gyuyoung On Fri, Sep 14, 2012 at 1:01 PM, Adam Barth wrote: > Congrats Yuta!! > > Adam > > > On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent wrote: > > I'd like to announce that Yuta Kitamura is now a > > WebKit reviewer. > > > > He has contributed to WebKit project for three years mainly in WebSocket > > area. He is a trustworthy authority on WebSocket area. If you worked on > > WebSocket issues, please involve him. > > > > -- > > TAMURA Kent > > Software Engineer, Google > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > -- - Gyuyoung ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)
On Sep 13, 2012, at 11:15 PM, Darin Fisher wrote: > > > On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote: > On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: > > Another metric we have is for Blob.webkitSlice: > > > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% > > > > It's difficult to know how to interpret this data because we don't > > actually correlate calls to webkitSlice with Documents or Pages. > > Instead, we just count the total number of calls across all Documents. > > This gives us an upper bound on how many Documents (or Pages) would > > be affected by deleting Blob.webkitSlice, but doesn't measure that > > information as accurately as the data we have for mutation events. > > Based on this data, I've posted a patch for removing Blob.webkitSlice > in favor of Blob.slice: > > https://bugs.webkit.org/show_bug.cgi?id=96715 > > Adam > > So, worst case 53 out of a million pages calls webkitSlice. But, it is easy > to imagine that that upper bound is crazy high, and more likely a couple > pages simply call webkitSlice a lot. Also, given that there are so many more > calls to Blob.slice() one could imagine that sites that call webkitSlice > probably have fallback to Blob.slice(). Is this the hypothesis? Adam's data measures webkitSlice() *calls*, not just appearances of the symbol, so these are either sites that have fallback in the wrong direction (trying the prefixed version before the vanilla version), or would break after the removal. I've seen both problems with about similar frequency in the past, so a decent hypothesis is that half those webkitSlice calls will break. Safari hasn't had Blob for very long at all, so Chrome is probably more impacted. From my own perspective, I think the usage is low enough that it's worth making the change to see the fallout. I wonder also how likely it is that some of the webkitSlice uses are on Google-controlled Web properties and therefore could be fixed ahead of time. Cheers, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] New WebKit reviewer: Yuta Kitamura
Congrats Yuta!! Adam On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent wrote: > I'd like to announce that Yuta Kitamura is now a > WebKit reviewer. > > He has contributed to WebKit project for three years mainly in WebSocket > area. He is a trustworthy authority on WebSocket area. If you worked on > WebSocket issues, please involve him. > > -- > TAMURA Kent > Software Engineer, Google > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] New WebKit reviewer: Yuta Kitamura
I'd like to announce that Yuta Kitamura is now a WebKit reviewer. He has contributed to WebKit project for three years mainly in WebSocket area. He is a trustworthy authority on WebSocket area. If you worked on WebSocket issues, please involve him. -- TAMURA Kent Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)
On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote: > On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: > > Another metric we have is for Blob.webkitSlice: > > > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% > > > > It's difficult to know how to interpret this data because we don't > > actually correlate calls to webkitSlice with Documents or Pages. > > Instead, we just count the total number of calls across all Documents. > > This gives us an upper bound on how many Documents (or Pages) would > > be affected by deleting Blob.webkitSlice, but doesn't measure that > > information as accurately as the data we have for mutation events. > > Based on this data, I've posted a patch for removing Blob.webkitSlice > in favor of Blob.slice: > > https://bugs.webkit.org/show_bug.cgi?id=96715 > > Adam So, worst case 53 out of a million pages calls webkitSlice. But, it is easy to imagine that that upper bound is crazy high, and more likely a couple pages simply call webkitSlice a lot. Also, given that there are so many more calls to Blob.slice() one could imagine that sites that call webkitSlice probably have fallback to Blob.slice(). Is this the hypothesis? -Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Removing webkitSlice (was Re: Existing metrics for deprecated features)
On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote: > Another metric we have is for Blob.webkitSlice: > > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% > Ratio of Blob.webkitSlice calls to Document creation: 0.0053% > > It's difficult to know how to interpret this data because we don't > actually correlate calls to webkitSlice with Documents or Pages. > Instead, we just count the total number of calls across all Documents. > This gives us an upper bound on how many Documents (or Pages) would > be affected by deleting Blob.webkitSlice, but doesn't measure that > information as accurately as the data we have for mutation events. Based on this data, I've posted a patch for removing Blob.webkitSlice in favor of Blob.slice: https://bugs.webkit.org/show_bug.cgi?id=96715 Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] SH4, MIPS, and legacy-ARM assemblers in JavaScriptCore
Hi, Submitted the patch for enabling the MIPS slave in build.webkit.org. https://bugs.webkit.org/show_bug.cgi?id=96713 Who should I send the buildbot password for the slave? Thanks, Gergely On Thu, Aug 30, 2012 at 9:52 AM, Holger Freyther wrote: > On 08/30/2012 12:10 AM, Gergely Kis wrote: > > > > > Would this be acceptable for you? > > sure, an actively and publicly maintained MIPS build would be great. We > have > some documentation on how to setup a build slave in the wiki[1] and the > slave > configuration files are maintained in SVN[2]. The configuration file > changes > follow the normal WebKit contribution procedure. > > holger > > > [1] http://trac.webkit.org/wiki/BuildBot > [2] > > http://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Existing metrics for deprecated features
In connection with the thread on webkitPostMessage, I took a look at what sorts of metrics we have currently for depreciated features. We have high quality data for two groups of APIs: For mutation events, we measure what percent of Documents have listeners for various kinds of mutation events: DOMAPI.PerDocumentMutationEventUsage.DOMCharacterDataModified: 2.85% of all Documents DOMAPI.PerDocumentMutationEventUsage.DOMNodeInserted: 4.78% of all Documents DOMAPI.PerDocumentMutationEventUsage.DOMNodeInsertedIntoDocument: 0.21% of all Documents DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemoved: 0.07% of all Documents DOMAPI.PerDocumentMutationEventUsage.DOMNodeRemovedFromDocument: 0.0003% of all Documents DOMAPI.PerDocumentMutationEventUsage.DOMSubtreeModified: 2.30% of all Documents >From this data, it's tempting to remove support for DOMNodeRemoved and DOMNodeRemovedFromDocument as those are used extremely rarely. We don't have any data for how much of this usage is attributable to extensions. It will be interesting to watch this data as we evangelize MutationObservers, especially among extension developers. Another metric we have is for Blob.webkitSlice: Ratio of Blob.webkitSlice calls to Blob.slice: 14.87% Ratio of Blob.webkitSlice calls to Document creation: 0.0053% It's difficult to know how to interpret this data because we don't actually correlate calls to webkitSlice with Documents or Pages. Instead, we just count the total number of calls across all Documents. This gives us an upper bound on how many Documents (or Pages) would be affected by deleting Blob.webkitSlice, but doesn't measure that information as accurately as the data we have for mutation events. We are also gathering metrics on the usage of vendor prefixes in CSS properties, but that histogram doesn't appear to have been in the field long enough to have meaningful data. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
If someone wanted this and understood python, I suspect that they could search for "unsigned" in that cpp.py and in about 10 min have a pretty good idea of how to add such a check. If you don't understand Python, then 30 minutes :) dave On Thu, Sep 13, 2012 at 2:12 PM, Kenneth Rohde Christiansen < kenneth.christian...@gmail.com> wrote: > Filed https://bugs.webkit.org/show_bug.cgi?id=96693 > > On Thu, Sep 13, 2012 at 10:47 PM, Ryosuke Niwa wrote: > > No. I think we can update webkitpy/style/checkers/cpp.py to do that. > > Unfortunately, I don't understand that code base. > > > > - Ryosuke > > > > > > On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wrote: > >> > >> Does the style bot pick up "unsigned int" etc? > >> > >> --Oliver > >> > >> On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote: > >> > >> Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) > >> > >> On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa > wrote: > >>> > >>> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. > >>> > >>> - Ryosuke > >>> > >>> On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: > > > > On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen > wrote: > > > Hi there, > > > > I was telling people to use "unsigned" instead of "unsigned int", > as I > > have been told that was the preferred style before, but apparently > > that is not in the style guide. > > > > The question is, should it be? > > Yes. > > > > > A few greps in the code: > > > > "unsigned" -> 18406 occurrences. > > "unsigned int" -> 1721 > > "unsigned i =" -> 1548 > > > > It does in fact seem to be the preferred style. > > > > Cheers > > Kenneth > > > > -- > > Kenneth Rohde Christiansen > > Senior Engineer, WebKit, Qt, EFL > > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > > > ﹆﹆﹆ > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > >>> > >>> > >> > >> ___ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo/webkit-dev > >> > >> > > > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > > -- > Kenneth Rohde Christiansen > Senior Engineer, WebKit, Qt, EFL > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > ﹆﹆﹆ > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
Filed https://bugs.webkit.org/show_bug.cgi?id=96693 On Thu, Sep 13, 2012 at 10:47 PM, Ryosuke Niwa wrote: > No. I think we can update webkitpy/style/checkers/cpp.py to do that. > Unfortunately, I don't understand that code base. > > - Ryosuke > > > On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wrote: >> >> Does the style bot pick up "unsigned int" etc? >> >> --Oliver >> >> On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote: >> >> Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) >> >> On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote: >>> >>> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. >>> >>> - Ryosuke >>> >>> On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen wrote: > Hi there, > > I was telling people to use "unsigned" instead of "unsigned int", as I > have been told that was the preferred style before, but apparently > that is not in the style guide. > > The question is, should it be? Yes. > > A few greps in the code: > > "unsigned" -> 18406 occurrences. > "unsigned int" -> 1721 > "unsigned i =" -> 1548 > > It does in fact seem to be the preferred style. > > Cheers > Kenneth > > -- > Kenneth Rohde Christiansen > Senior Engineer, WebKit, Qt, EFL > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > ﹆﹆﹆ > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev >>> >>> >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev >> >> > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > -- Kenneth Rohde Christiansen Senior Engineer, WebKit, Qt, EFL Phone +45 4093 0598 / E-mail kenneth at webkit.org ﹆﹆﹆ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
No. I think we can update webkitpy/style/checkers/cpp.py to do that. Unfortunately, I don't understand that code base. - Ryosuke On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wrote: > Does the style bot pick up "unsigned int" etc? > > --Oliver > > On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote: > > Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) > > On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote: > >> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. >> >> - Ryosuke >> >> On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: >> >>> >>> >>> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen < >>> kenneth.christian...@gmail.com> wrote: >>> >>> > Hi there, >>> > >>> > I was telling people to use "unsigned" instead of "unsigned int", as I >>> > have been told that was the preferred style before, but apparently >>> > that is not in the style guide. >>> > >>> > The question is, should it be? >>> >>> Yes. >>> >>> > >>> > A few greps in the code: >>> > >>> > "unsigned" -> 18406 occurrences. >>> > "unsigned int" -> 1721 >>> > "unsigned i =" -> 1548 >>> > >>> > It does in fact seem to be the preferred style. >>> > >>> > Cheers >>> > Kenneth >>> > >>> > -- >>> > Kenneth Rohde Christiansen >>> > Senior Engineer, WebKit, Qt, EFL >>> > Phone +45 4093 0598 / E-mail kenneth at webkit.org >>> > >>> > ﹆﹆﹆ >>> > ___ >>> > webkit-dev mailing list >>> > webkit-dev@lists.webkit.org >>> > http://lists.webkit.org/mailman/listinfo/webkit-dev >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo/webkit-dev >>> >> >> > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
Does the style bot pick up "unsigned int" etc? --Oliver On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote: > Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) > > On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote: > Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. > > - Ryosuke > > On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: > > > On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen > wrote: > > > Hi there, > > > > I was telling people to use "unsigned" instead of "unsigned int", as I > > have been told that was the preferred style before, but apparently > > that is not in the style guide. > > > > The question is, should it be? > > Yes. > > > > > A few greps in the code: > > > > "unsigned" -> 18406 occurrences. > > "unsigned int" -> 1721 > > "unsigned i =" -> 1548 > > > > It does in fact seem to be the preferred style. > > > > Cheers > > Kenneth > > > > -- > > Kenneth Rohde Christiansen > > Senior Engineer, WebKit, Qt, EFL > > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > > > ﹆﹆﹆ > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!) On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote: > Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. > > - Ryosuke > > On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: > >> >> >> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen < >> kenneth.christian...@gmail.com> wrote: >> >> > Hi there, >> > >> > I was telling people to use "unsigned" instead of "unsigned int", as I >> > have been told that was the preferred style before, but apparently >> > that is not in the style guide. >> > >> > The question is, should it be? >> >> Yes. >> >> > >> > A few greps in the code: >> > >> > "unsigned" -> 18406 occurrences. >> > "unsigned int" -> 1721 >> > "unsigned i =" -> 1548 >> > >> > It does in fact seem to be the preferred style. >> > >> > Cheers >> > Kenneth >> > >> > -- >> > Kenneth Rohde Christiansen >> > Senior Engineer, WebKit, Qt, EFL >> > Phone +45 4093 0598 / E-mail kenneth at webkit.org >> > >> > ﹆﹆﹆ >> > ___ >> > webkit-dev mailing list >> > webkit-dev@lists.webkit.org >> > http://lists.webkit.org/mailman/listinfo/webkit-dev >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev >> > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Should we support multiple bug URLs in TestExpectations?
On Thu, Sep 13, 2012 at 12:32 PM, Ryosuke Niwa wrote: > Hi, > > This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569. > > Should we allow URLs other than webkit.org/b/ to be used in > TestExpectations? > > I vote for yes, and in fact, adding new URLs should be easy. What do you > guys think? > What I wrote in that bug thread ... I think it's actually kind of lame that we reference bugs tracked anywhere other than webkit.org (and chromium currently does a lot of this). I also don't think there's a very large list of places we would want to look and so there's no need to make it easy to add new ones. For what it's worth, there is also an advantage to having a programmatically grokkable list, rather than allowing free-form URLs, since it makes it easier to write tools that extract the bug numbers from the URL and/or scrape or join against data in the bug databases (both of which I've done in the past). That said, I'll implement whatever there is a consensus for; I don't feel that strongly about this one way or another. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Should we support multiple bug URLs in TestExpectations?
Hi, This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569. Should we allow URLs other than webkit.org/b/ to be used in TestExpectations? I vote for yes, and in fact, adding new URLs should be easy. What do you guys think? Best, Ryosuke Niwa Software Engineer Google Inc. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682. - Ryosuke On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote: > > > On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen < > kenneth.christian...@gmail.com> wrote: > > > Hi there, > > > > I was telling people to use "unsigned" instead of "unsigned int", as I > > have been told that was the preferred style before, but apparently > > that is not in the style guide. > > > > The question is, should it be? > > Yes. > > > > > A few greps in the code: > > > > "unsigned" -> 18406 occurrences. > > "unsigned int" -> 1721 > > "unsigned i =" -> 1548 > > > > It does in fact seem to be the preferred style. > > > > Cheers > > Kenneth > > > > -- > > Kenneth Rohde Christiansen > > Senior Engineer, WebKit, Qt, EFL > > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > > > ﹆﹆﹆ > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Removing the prefix from webkitPostMessage
On Thu, Sep 13, 2012 at 12:06 PM, Dirk Pranke wrote: > On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak wrote: > > > > On Sep 12, 2012, at 10:36 PM, Ojan Vafai wrote: > > > > On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak > wrote: > >> > >> - Is this approach substantially less time and effort than adding a > >> histogram-style metric? I expect you have added a histogram to Chrome at > >> some point, and so can comment on the relative difficulty and time to > >> produce an answer. > >> (BTW we have the capability to do this type of thing in Safari as > well, > >> and it is what I ask Apple engineers to do when they want to remove a > >> feature, even a purely Mac-specific one.) > > > > > > FWIW, histograms can only tell you a percentile. We never report back > URLs > > due to privacy concerns. So, it's somewhat underpowered compared to > > experimentally removing a feature and seeing what sites break. I'm not > > saying that's not a useful signal, just clarifying what data is possible > for > > Chromium to gather in the wild. > > > > > > That's about what the equivalent Safari mechanism does too. What it can > tell > > you is stuff like "feature x is used very little by sites users actually > > visit" without risk of breakage. But if there is significant use, it > won't > > tell you what sites it is on or whether it's critical. > > > > Technically we can build histograms that either give you a percentage > of sites or a percentage of page views without compromising privacy > overly. The combination of the two is a pretty good approximation of > importance. > > It would be interesting to build a generic mechanism for monitoring > prefixed APIs ... I wonder how hard that would be. > FWIW, Tab has adding roughly this for prefixed CSS properties. Not sure what the status of that is, but the code has been committed AFAIK. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Removing the prefix from webkitPostMessage
On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak wrote: > > On Sep 12, 2012, at 10:36 PM, Ojan Vafai wrote: > > On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak wrote: >> >> - Is this approach substantially less time and effort than adding a >> histogram-style metric? I expect you have added a histogram to Chrome at >> some point, and so can comment on the relative difficulty and time to >> produce an answer. >> (BTW we have the capability to do this type of thing in Safari as well, >> and it is what I ask Apple engineers to do when they want to remove a >> feature, even a purely Mac-specific one.) > > > FWIW, histograms can only tell you a percentile. We never report back URLs > due to privacy concerns. So, it's somewhat underpowered compared to > experimentally removing a feature and seeing what sites break. I'm not > saying that's not a useful signal, just clarifying what data is possible for > Chromium to gather in the wild. > > > That's about what the equivalent Safari mechanism does too. What it can tell > you is stuff like "feature x is used very little by sites users actually > visit" without risk of breakage. But if there is significant use, it won't > tell you what sites it is on or whether it's critical. > Technically we can build histograms that either give you a percentage of sites or a percentage of page views without compromising privacy overly. The combination of the two is a pretty good approximation of importance. It would be interesting to build a generic mechanism for monitoring prefixed APIs ... I wonder how hard that would be. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] unsigned vs unsigned int
On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen wrote: > Hi there, > > I was telling people to use "unsigned" instead of "unsigned int", as I > have been told that was the preferred style before, but apparently > that is not in the style guide. > > The question is, should it be? Yes. > > A few greps in the code: > > "unsigned" -> 18406 occurrences. > "unsigned int" -> 1721 > "unsigned i =" -> 1548 > > It does in fact seem to be the preferred style. > > Cheers > Kenneth > > -- > Kenneth Rohde Christiansen > Senior Engineer, WebKit, Qt, EFL > Phone +45 4093 0598 / E-mail kenneth at webkit.org > > ﹆﹆﹆ > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] unsigned vs unsigned int
Hi there, I was telling people to use "unsigned" instead of "unsigned int", as I have been told that was the preferred style before, but apparently that is not in the style guide. The question is, should it be? A few greps in the code: "unsigned" -> 18406 occurrences. "unsigned int" -> 1721 "unsigned i =" -> 1548 It does in fact seem to be the preferred style. Cheers Kenneth -- Kenneth Rohde Christiansen Senior Engineer, WebKit, Qt, EFL Phone +45 4093 0598 / E-mail kenneth at webkit.org ﹆﹆﹆ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
