[webkit-dev] commit queue is stucked
Hi, It seems CQ is stucked 2 days ago: http://queues.webkit.org/queue-status/commit-queue Is there anyone here to be able to kick it/them? br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] MIPS port status update
Dear WebKit Developers, A quick status update on the MIPS port progress: - we have a build-only buildslave running ( http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/) (it is currently failing, a patch was already submitted to: https://bugs.webkit.org/show_bug.cgi?id=98856) - we have DFG and LLINT working for MIPS. We are going to start sending in the patches today or tomorrow. We plan to submit the work in 3 parts, as 3 separate issues in bugzilla: - common parts, which are used by both LLINT and DFG - LLINT MIPS implementation - DFG MIPS implementation Should we CC someone directly on these bugs to make the reviews easier? - Our porting effort uses the following git repository as a staging area: https://github.com/paul99/webkit The master branch in this repository is a direct mirror of the main webkit.org trunk branch. With the mips-master branch we are tracking the master branch, but also add a few MIPS specific patches that we are preparing for submitting back to the main webkit repository. Once we get LLINT and DFG accepted, the difference between the webkit trunk and our mips-master branch will be minimal: just the patches that were not yet accepted to webkit trunk. No forking or added exclusive features are intended here in this repository. We are committed to submit all MIPS support patches to the webkit.org main repository. Best Regards, Gergely ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] commit queue is stucked
Will do once I get a stable Internet connection (probably in an hour and a half). Adam On Oct 15, 2012 4:10 AM, Osztrogonac Csaba o...@inf.u-szeged.hu wrote: Hi, It seems CQ is stucked 2 days ago: http://queues.webkit.org/** queue-status/commit-queuehttp://queues.webkit.org/queue-status/commit-queue Is there anyone here to be able to kick it/them? br, Ossy __**_ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/**mailman/listinfo/webkit-devhttp://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] 8 Bit String Handling in Render Text Code
I recently landed r131311 which adds code to handle 8-bit strings in the render text path. The code also puts HTML text into 8-bit strings. The reason for this announcement is that the handling of 8-bit text on the render path is disabled on non-Mac platforms. Most platforms have platform specific text rendering code and that code needs to be updated to handle 8-bit text. For Mac, the platform specific changes are for the complex text rendering path only. The changes involved converting the 8-bit text to a 16-bit String, adding the 16-bit string to the ComplexTextController so the string won't be freed and using the contained 16-bit text with the rest of the complex code unchanged. See ComplexTextController::collectComplexTextRuns() in WebCore/platform/graphics/mac/ComplexTextController.cpp. The new define WTF_USE_8BIT_TEXTRUN is used to control the creation of 8-bit TextRun objects. When this define is not enabled, TextRun's will only contain 16-bit text and current code should work correctly. After platform code is added to handle 8-bit text in platform specific code, that platform should enable WTF_USE_8BIT_TEXTRUN. Note that all platforms compile with that define enabled, but it is likely they'll crash when running the tests. - Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Transformations precision: double - float
On Mon, Oct 15, 2012 at 9:35 AM, Gabor Rapcsanyi rga...@inf.u-szeged.huwrote: On 10/12/2012 11:23 AM, Tom Hudson wrote: Do you have particular bottleneck functions that you have reason to believe would benefit from ARM SIMD optimizations? Under what workloads, and how much benefit? We've see a few ridiculously expensive transform functions in WebKit that my colleagues in Chapel Hill might be able to recall, but usually it's the rendering engines that are hot, not WebKit itself. Yes, you're right that the rendering engine is usually the basic bottleneck, but why shouldn't we optimize WebKit where it is possible. For example the function what you asking is TransformationMatrix::multiply(). I made a test which could be speed up with optimizing this matrix multiplication. I uploaded here: https://bugs.webkit.org/show_bug.cgi?id=98913 You are suggesting a massive change to WebKit based on an hypothetical universe in which a certain function is important. The problem is the same claim can be done for about any function of WebKit. You can handcraft a microbenchmark exercising a slow function and redesign everything to make that particular function fast. Does this add a lot of value to the project? No so much. As much as I am in favor of increasing the use of SIMD, especially on ARM, I am really not a fan of the idea of switching to float on such weak premises. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] MIPS port status update
On Oct 15, 2012, at 7:13 AM, Gergely Kis wrote: Should we CC someone directly on these bugs to make the reviews easier? Likely reviewers would be me, Oliver, Filip or Geoff, feel free to cc. cheers, G. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] 8 Bit String Handling in Render Text Code
On Oct 15, 2012, at 9:56 AM, Michael Saboff msab...@apple.com wrote: I recently landed r131311 which adds code to handle 8-bit strings in the render text path. The code also puts HTML text into 8-bit strings. The reason for this announcement is that the handling of 8-bit text on the render path is disabled on non-Mac platforms. Most platforms have platform specific text rendering code and that code needs to be updated to handle 8-bit text. For Mac, the platform specific changes are for the complex text rendering path only. The changes involved converting the 8-bit text to a 16-bit String, adding the 16-bit string to the ComplexTextController so the string won't be freed and using the contained 16-bit text with the rest of the complex code unchanged. See ComplexTextController::collectComplexTextRuns() in WebCore/platform/graphics/mac/ComplexTextController.cpp. The new define WTF_USE_8BIT_TEXTRUN is used to control the creation of 8-bit TextRun objects. When this define is not enabled, TextRun's will only contain 16-bit text and current code should work correctly. After platform code is added to handle 8-bit text in platform specific code, that platform should enable WTF_USE_8BIT_TEXTRUN. Note that all platforms compile with that define enabled, but it is likely they'll crash when running the tests. Minor technicality, but this should be an ENABLE flag, not USE. ENABLE is for optional code in WebKit itself, USE is for optional external dependencies. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] New CSS3 feature : text-align-last
Dear WebKit, I would like to let you know that I'm trying to implement a new CSS3 feature which name is text-align-last. The specification link is here : http://www.w3.org/TR/css3-text/#text-align-last This property describes how the last line of a block or a line right before a forced line break is aligned. This feature is already properly supported on IE and Mozilla, currently. With this property, we can give a text-align style to the last line, or one line content. Especially, this is valuable when we want to use justify style to the last line, or one line content. When we give text-align:justify, current WebKit gives text-align:start to the last line of the content. The bug related to this implementation is https://bugs.webkit.org/show_bug.cgi?id=76173 . Any comments will be kindly appreciated! Best regards, Dongwoo. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
