Re: [webkit-dev] Changing Github repository to mirror git.webkit.org (was Github vs. git.webkit.org)
On 01/16/2013 10:07 PM, Eric Seidel wrote: Do we know if there is a way to re-write our existing forks w/o pulling the whole repo down, just to push it back up again? If you make the new github mirror fork a remote for your existing git.webkit.org clone and push from there you would only need to push a small amount - at least that's how it worked for me. Dominik ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal to remove list-item special counter
On Wednesday 2013-01-16 18:25 -0800, Darin Adler wrote: On Jan 16, 2013, at 5:46 PM, Elliott Sprehn espr...@chromium.org wrote: I've scoured the web and can't find any reference to anyone using it, mention of it's usage on any pages and no other browser supports it. How much more common is use of the rest of the counters specification? I understand that counters is still a leading-edge feature that isn’t likely to be used much on the real web yet. The list-item counter is used in the very first example in the CSS Lists and Counters Module http://www.w3.org/TR/css3-lists/. I don’t understand why you are so eager to throw it under the bus. In terms of harm, it adds implementation complexity, especially when I want to rewrite counters to be much simpler and faster. I'd like to go ahead with the removal and then we can bring this back if developers show interest. Does that sound reasonable? If you really want to remove it, and all the other browser vendors agree, maybe you can get it removed from the CSS working draft. For what it's worth, reimplementing Gecko's list numbering using counters is something I'd like to do; it's just not so high on the priority list these days. (Our current list numbering code has a bunch of weird bugs that our counter implementation does not have. That said, I think implementing list numbering using counters might require implementing the new 'counter-set' in addition to the existing 'counter-increment' and 'counter-reset'.) -David -- 턞 L. David Baron http://dbaron.org/ 턂 턢 Mozilla http://www.mozilla.org/ 턂 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] request of canconfirm-bit
Thank you. Darin I will add comments on the bug. BR, Zheng (2013/01/17 11:40), Darin Adler wrote: On Jan 16, 2013, at 2:54 PM, 徐征 xz91...@yahoo.co.jp wrote: So, how can I get assign for this issue(and make the status to ASSIGNED)? You don’t need to. You can add comments and post a patch without having the bug formally assigned to you. In fact, we don’t normally pay all that much attention to the Assigned To field. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] EWS commenting about ancient patches
On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
Hi, EWS picks up all patches with r? flag. Mac WK2 EWS is a brand new EWS bot, that's why it tested ancient patches and commented their bugs. It finished processing ancient patches, so it won't be problem in the future. br, Ossy Alexey Proskuryakov írta: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Can't upload patch
I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug ( https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
Sorry. webkit-patch upload does not have very good error handling: https://bugs.webkit.org/show_bug.cgi?id=72863 On Thu, Jan 17, 2013 at 10:49 AM, Raymond Toy r...@google.com wrote: Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS queue has either has a result for each patch, or adds it to each individual queue. Since there are some ancient patches still marked r?, new queues will process ancient patches. :) (The feeder-queue is then smart enough to keep an in-memory list of what it's sent to queues.webkit.org, so it only send incremental lists until it restarts itself again in 2 hours.) -eric On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
Maybe we shouldn't bother feeding the bots patches that are over a certain age (perhaps a week)? Adam On Thu, Jan 17, 2013 at 11:50 AM, Eric Seidel e...@webkit.org wrote: I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS queue has either has a result for each patch, or adds it to each individual queue. Since there are some ancient patches still marked r?, new queues will process ancient patches. :) (The feeder-queue is then smart enough to keep an in-memory list of what it's sent to queues.webkit.org, so it only send incremental lists until it restarts itself again in 2 hours.) -eric On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
That seems totally reasonable, and simple to implement: https://bugs.webkit.org/show_bug.cgi?id=107152 On Thu, Jan 17, 2013 at 11:55 AM, Adam Barth aba...@webkit.org wrote: Maybe we shouldn't bother feeding the bots patches that are over a certain age (perhaps a week)? Adam On Thu, Jan 17, 2013 at 11:50 AM, Eric Seidel e...@webkit.org wrote: I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS queue has either has a result for each patch, or adds it to each individual queue. Since there are some ancient patches still marked r?, new queues will process ancient patches. :) (The feeder-queue is then smart enough to keep an in-memory list of what it's sent to queues.webkit.org, so it only send incremental lists until it restarts itself again in 2 hours.) -eric On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
Note that "git show" produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.)If you have your commit, plus the ChangeLog changes mer ged into the same commit, you can just pipe the output of "git show" to a file and attach that to your bug manually instead. For the bots and the review machinery, the patch should be the same as if you had uploaded it through webkit-patch. You'll only miss out on a few sanity checks that webkit-patch performs before uploading, and the raw file will look slightly differently.Cheers, Jakob From: Raymond ToySent: Thursday, January 17, 2013 1:49 PMTo: Adam BarthCc: webkit-dev@lists.webkit.orgSubject: Re: [webkit-dev] Can't upload patchHmm. I have a git checkout of webkit so svn-create-patch doesn't want to work.Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the "attachments" UI in bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
... valid *diff* file. Damn you autocorrect! From: jpe...@gmx.atSent: Thursday, January 17, 2013 3:42 PMTo: Raymond ToyCc: webkit-d e...@lists.webkit.orgSubject: Re: [webkit-dev] Can't upload patchNote that "git show" produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.)If you have your commit, plus the ChangeLog changes mer ged into the same commit, you can just pipe the output of "git show" to a file and attach that to your bug manually instead. For the bots and the review machinery, the patch should be the same as if you had uploaded it through webkit-patch. You'll only miss out on a few sanity checks that webkit-patch performs before uploading, and the raw file will look slightly differently.Cheers, Jakob From: Raymond ToySent: Thursday, January 17, 2013 1:49 PMTo: Adam BarthCc: webkit-dev@lists.webkit.orgSubject: Re: [webkit-dev] Can't upload patchHmm. I have a git checkout of webkit so svn-create-patch doesn't want to work.Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the "attachments" UI in bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Changing Github repository to mirror git.webkit.org (was Github vs. git.webkit.org)
Yes, but I'm more interested in rebasing my existing github branches. :) But you're right, I could probably run Tools/Scripts/sync-master-with-upstream from my existing git.webkit.org checkout and not have to download anything. I'd still have a bunch of github branches which I can't easily rebase on top of that, but that's a start. On Thu, Jan 17, 2013 at 4:00 AM, Dominik Röttsches dominik.rottsc...@intel.com wrote: On 01/16/2013 10:07 PM, Eric Seidel wrote: Do we know if there is a way to re-write our existing forks w/o pulling the whole repo down, just to push it back up again? If you make the new github mirror fork a remote for your existing git.webkit.org clone and push from there you would only need to push a small amount - at least that's how it worked for me. Dominik ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
Instead of piping the output of git show, I'd use git format-patch -1 This will generate a patch file for the topmost commit of your current branch. Cheers, Konrad From: webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.org] on behalf of jpe...@gmx.at [jpe...@gmx.at] Sent: Thursday, January 17, 2013 3:43 PM To: Raymond Toy Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch ... valid *diff* file. Damn you autocorrect! From: jpe...@gmx.at Sent: Thursday, January 17, 2013 3:42 PM To: Raymond Toy Cc: webkit-d e...@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch Note that git show produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.) If you have your commit, plus the ChangeLog changes mer ged into the same commit, you can just pipe the output of git show to a file and attach that to your bug manually instead. For the bots and the review machinery, the patch should be the same as if you had uploaded it through webkit-patch. You'll only miss out on a few sanity checks that webkit-patch performs before uploading, and the raw file will look slightly differently. Cheers, Jakob From: Raymond Toy Sent: Thursday, January 17, 2013 1:49 PM To: Adam Barth Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.orgmailto:aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.orghttp://bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.orghttp://bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.commailto:r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Changing Github repository to mirror git.webkit.org (was Github vs. git.webkit.org)
Maybe git rebase --onto would help, if only a bit? http://git-scm.com/book/en/Git-Branching-Rebasing#More-Interesting-Rebases /pf On Thu, 17 Jan 2013 13:13:44 -0800, Eric Seidel esei...@google.com wrote: Yes, but I'm more interested in rebasing my existing github branches. :) But you're right, I could probably run Tools/Scripts/sync-master-with-upstream from my existing git.webkit.org checkout and not have to download anything. I'd still have a bunch of github branches which I can't easily rebase on top of that, but that's a start. On Thu, Jan 17, 2013 at 4:00 AM, Dominik Röttsches dominik.rottsc...@intel.com wrote: On 01/16/2013 10:07 PM, Eric Seidel wrote: Do we know if there is a way to re-write our existing forks w/o pulling the whole repo down, just to push it back up again? If you make the new github mirror fork a remote for your existing git.webkit.org clone and push from there you would only need to push a small amount - at least that's how it worked for me. Dominik ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- pablo flouret motorola | webkit / browser team ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
On Thu, Jan 17, 2013 at 1:17 PM, Konrad Piascik kpias...@rim.com wrote: Instead of piping the output of git show, I'd use git format-patch -1 This will generate a patch file for the topmost commit of your current branch. Thanks! That does the trick. I wasn't sure if the patches for the multiple commits would work if I concatenated them into one, so I just squashed my commits. It turns out that the patch was 2.16 MB, just over the limit. Ray Cheers, Konrad From: webkit-dev-boun...@lists.webkit.org [ webkit-dev-boun...@lists.webkit.org] on behalf of jpe...@gmx.at [ jpe...@gmx.at] Sent: Thursday, January 17, 2013 3:43 PM To: Raymond Toy Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch ... valid *diff* file. Damn you autocorrect! From: jpe...@gmx.at Sent: Thursday, January 17, 2013 3:42 PM To: Raymond Toy Cc: webkit-d e...@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch Note that git show produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.) If you have your commit, plus the ChangeLog changes mer ged into the same commit, you can just pipe the output of git show to a file and attach that to your bug manually instead. For the bots and the review machinery, the patch should be the same as if you had uploaded it through webkit-patch. You'll only miss out on a few sanity checks that webkit-patch performs before uploading, and the raw file will look slightly differently. Cheers, Jakob From: Raymond Toy Sent: Thursday, January 17, 2013 1:49 PM To: Adam Barth Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.orgmailto: aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.org http://bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.org http://bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.commailto: r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can't upload patch
You could have kept your commits separate and generated a patch for each. The parameter for format-patch is the number of commits for which to generate patches. -Konrad Sent from my BlackBerry smartphone. From: Raymond Toy Sent: Thursday, January 17, 2013 6:00 PM To: Konrad Piascik Cc: jpe...@gmx.at; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch On Thu, Jan 17, 2013 at 1:17 PM, Konrad Piascik kpias...@rim.commailto:kpias...@rim.com wrote: Instead of piping the output of git show, I'd use git format-patch -1 This will generate a patch file for the topmost commit of your current branch. Thanks! That does the trick. I wasn't sure if the patches for the multiple commits would work if I concatenated them into one, so I just squashed my commits. It turns out that the patch was 2.16 MB, just over the limit. Ray Cheers, Konrad From: webkit-dev-boun...@lists.webkit.orgmailto:webkit-dev-boun...@lists.webkit.org [webkit-dev-boun...@lists.webkit.orgmailto:webkit-dev-boun...@lists.webkit.org] on behalf of jpe...@gmx.atmailto:jpe...@gmx.at [jpe...@gmx.atmailto:jpe...@gmx.at] Sent: Thursday, January 17, 2013 3:43 PM To: Raymond Toy Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch ... valid *diff* file. Damn you autocorrect! From: jpe...@gmx.atmailto:jpe...@gmx.at Sent: Thursday, January 17, 2013 3:42 PM To: Raymond Toy Cc: webkit-d e...@lists.webkit.orgmailto:e...@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch Note that git show produces a valid different file, extra commit message notwithstanding. (The commit message is part of the header and will be ignored when used with diff and related tools.) If you have your commit, plus the ChangeLog changes mer ged into the same commit, you can just pipe the output of git show to a file and attach that to your bug manually instead. For the bots and the review machinery, the patch should be the same as if you had uploaded it through webkit-patch. You'll only miss out on a few sanity checks that webkit-patch performs before uploading, and the raw file will look slightly differently. Cheers, Jakob From: Raymond Toy Sent: Thursday, January 17, 2013 1:49 PM To: Adam Barth Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Can't upload patch Hmm. I have a git checkout of webkit so svn-create-patch doesn't want to work. Yeah, the patch is probably too big. The particular patch could be broken up into 3-4 separate smaller patches. Perhaps that will work. On Thu, Jan 17, 2013 at 9:52 AM, Adam Barth aba...@webkit.orgmailto:aba...@webkit.orgmailto:aba...@webkit.orgmailto:aba...@webkit.org wrote: Have you tried uploading the patch manually by running svn-create-patch and using the attachments UI in bugs.webkit.orghttp://bugs.webkit.orghttp://bugs.webkit.org? One possibility is that your patch is too big for bugs.webkit.orghttp://bugs.webkit.orghttp://bugs.webkit.org to handle. You mention that it contains a number of binary files, which might be the cause of the problem. Adam On Thu, Jan 17, 2013 at 9:43 AM, Raymond Toy r...@google.commailto:r...@google.commailto:r...@google.commailto:r...@google.com wrote: I'm trying to upload a patch and webkit-patch upload appears to do everything except actually add the patch to the bug. I first ran webkit-patch upload and it correctly created the bug (https://bugs.webkit.org/show_bug.cgi?id=106955) for me, but didn't upload the patch. When I run webkit-patch upload again, it correctly shows the diff, which consists of a a change to TestExpectations and several binary files. It says it adding the patch, but when I look at the bug, there's no patch. I'm missing something, but I don't know what it is. I've uploaded patches before, so I know it used to work. :-( Any suggestions? Ray ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. - This transmission (including
[webkit-dev] Feature configurations
Hi, I wanted to give a heads up that I'm planning to land a patch that moves the ENABLE feature macros out from Platform.h into its own file - see https://bugs.webkit.org/show_bug.cgi?id=105735. After the patch lands I will update our wiki with the changes at http://trac.webkit.org/wiki/AddingFeatures. I consider this as a first step for some other (incremental) changes. I created a meta bug to collect the work - see https://bugs.webkit.org/show_bug.cgi?id=105734 . The (long term) goals are: - Potentially decrease the scope of the flags - e.g. WebCore flags do not need to be visible to JavaScriptCore - Maintain a full list of feature flags in the source code - replace the existing Wiki that is disconnected from the source code - Make it easier to introduce/remove a build flag Any feedback on the goals and/or the approach is welcome here or on the bugs. Thanks, Laszlo ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Is the New XMLParser dead?
Hi, It has been 11 months since Eric initially raised the concern. Can we go ahead and remove the parser now? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Is the New XMLParser dead?
Maciej has asked that we keep it around until the end of February: https://bugs.webkit.org/show_bug.cgi?id=100710 Adam On Thu, Jan 17, 2013 at 4:10 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It has been 11 months since Eric initially raised the concern. Can we go ahead and remove the parser now? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding main element to WebCore
IMO, the following represents enough evidence to land the patch as soon as the last layout test failure is resolved. https://bugs.webkit.org/show_bug.cgi?id=103172 1. Sam Ruby, as Chair declared this passing the HTML WG vote, With no objections and ample support, this resolution passes. http://lists.w3.org/Archives/Public/public-html/2012Nov/0232.html 2. Representatives from another rendering engine vendor (Mozilla) have expressed support for this feature and a willingness to implement it. 2a. David Bolter, said, …this [main] is a good thing! http://lists.w3.org/Archives/Public/public-html/2012Dec/0073.html 2b. Henri Sivonen: I think we should implement it because… (Gecko patch pending) https://bugzilla.mozilla.org/show_bug.cgi?id=820508 3. And finally, main already landed in the HTML 5.1 spec about a week ago. http://www.w3.org/html/wg/drafts/html/master/grouping-content.html#the-main-element ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding main element to WebCore
Does anyone still object in light of these updates, particularly Mozilla's support for the feature? Regards, Maciej On Jan 17, 2013, at 5:20 PM, James Craig jcr...@apple.com wrote: IMO, the following represents enough evidence to land the patch as soon as the last layout test failure is resolved. https://bugs.webkit.org/show_bug.cgi?id=103172 1. Sam Ruby, as Chair declared this passing the HTML WG vote, With no objections and ample support, this resolution passes. http://lists.w3.org/Archives/Public/public-html/2012Nov/0232.html 2. Representatives from another rendering engine vendor (Mozilla) have expressed support for this feature and a willingness to implement it. 2a. David Bolter, said, …this [main] is a good thing! http://lists.w3.org/Archives/Public/public-html/2012Dec/0073.html 2b. Henri Sivonen: I think we should implement it because… (Gecko patch pending) https://bugzilla.mozilla.org/show_bug.cgi?id=820508 3. And finally, main already landed in the HTML 5.1 spec about a week ago. http://www.w3.org/html/wg/drafts/html/master/grouping-content.html#the-main-element ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Is the New XMLParser dead?
I think it's fine to shoot it in the head now. We do still want to come back to it eventually, but it's now apparent that we won't in the next 1.5 months. - Maciej On Jan 17, 2013, at 4:15 PM, Adam Barth aba...@webkit.org wrote: Maciej has asked that we keep it around until the end of February: https://bugs.webkit.org/show_bug.cgi?id=100710 Adam On Thu, Jan 17, 2013 at 4:10 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It has been 11 months since Eric initially raised the concern. Can we go ahead and remove the parser now? - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Adding main element to WebCore
Thanks for the follow up. Mozilla's commitment makes a strong case for supporting it in WebKit as well. - R. Niwa On Thu, Jan 17, 2013 at 5:20 PM, James Craig jcr...@apple.com wrote: IMO, the following represents enough evidence to land the patch as soon as the last layout test failure is resolved. https://bugs.webkit.org/show_bug.cgi?id=103172 1. Sam Ruby, as Chair declared this passing the HTML WG vote, With no objections and ample support, this resolution passes. http://lists.w3.org/Archives/Public/public-html/2012Nov/0232.html 2. Representatives from another rendering engine vendor (Mozilla) have expressed support for this feature and a willingness to implement it. 2a. David Bolter, said, …this [main] is a good thing! http://lists.w3.org/Archives/Public/public-html/2012Dec/0073.html 2b. Henri Sivonen: I think we should implement it because… (Gecko patch pending) https://bugzilla.mozilla.org/show_bug.cgi?id=820508 3. And finally, main already landed in the HTML 5.1 spec about a week ago. http://www.w3.org/html/wg/drafts/html/master/grouping-content.html#the-main-element ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] We've added Mac WK2 EWS (runs tests!)
Hello WebKittens, Lucas and I have enabled Mac WK2 EWS bots that run layout tests using WebKitTestRunner (WebKit2) on Mountain Lion. You should see the mac-wk2 bubble in your bugzilla entries now. If anyone has any interest in looking at the queues, you can find them here: EWS Queues http://queues.webkit.org Active Botshttp://queues.webkit.org/active-bots. We are using Mac Mini's to process our queues. There are 8 bots for the WK1 queue, 8 for WK2 queue, for a total of 16 EWS bots. If you have any questions, freel free to ping myself or Lucas! Best regards, R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
