[webkit-dev] Getting started with making Qt WebKit patches
Hello, I'm trying to submit a patch for Qt WebKit. I've applied the patch to my local copy of qtwebkit.git, but am having trouble using webkit-patch. What am I missing? I'm running Windows 8 x64, Git version 1.8.0.msysgit.0, and ActivePython 2.7.2 x64. From Git Bash, I called `Tools/Scripts/webkit-patch prepare --cc=hausm...@webkit.org' I got the error message below, but am not told what file the script is unable to find. I tried it with my changes uncommitted and committed, but got the same result. == Traceback (most recent call last): File Tools/Scripts/webkit-patch, line 84, in module main() File Tools/Scripts/webkit-patch, line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\tool\multicommandtool.py, line 304, in main self.handle_global_options(options) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\tool\main.py, line 94, in handle_global_options self.initialize_scm(options.patch_directories) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\host.py, line 132, in initialize_scm self._scm = detector.default_scm(patch_directories) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\detection.py, line 55, in default_scm scm_system = self.detect_scm_system(cwd, patch_directories) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\detection.py, line 71, in detect_scm_system if SVN.in_working_directory(absolute_path, executive=self._executive): File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\svn.py, line 93, in in_working_directory exit_code = executive.run_command(svn_info_args, cwd=path, return_exit_code=True) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\system\executive.py, line 405, in run_command close_fds=self._should_close_fds()) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\system\executive.py, line 461, in popen return subprocess.Popen(*args, **kwargs) File c:\Python27\lib\subprocess.py, line 679, in __init__ errread, errwrite) File c:\Python27\lib\subprocess.py, line 893, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified == Running Tools/Scripts/prepare-ChangeLog worked ok, but I was under the impression that webkit-patch is preferred as it automates a lot more aspects of the workflow (is that correct?) Thanks in advance for your guidance. Regards, Sze-Howe ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Getting started with making Qt WebKit patches
You're probably missing subversion package. If you're on ubuntu, sudo apt-get install subversion should do the trick. On Mon, Mar 25, 2013 at 12:00 PM, Sze Howe Koh szehowe@gmail.comwrote: Hello, I'm trying to submit a patch for Qt WebKit. I've applied the patch to my local copy of qtwebkit.git, but am having trouble using webkit-patch. What am I missing? I'm running Windows 8 x64, Git version 1.8.0.msysgit.0, and ActivePython 2.7.2 x64. From Git Bash, I called `Tools/Scripts/webkit-patch prepare --cc=hausm...@webkit.org' I got the error message below, but am not told what file the script is unable to find. I tried it with my changes uncommitted and committed, but got the same result. == Traceback (most recent call last): File Tools/Scripts/webkit-patch, line 84, in module main() File Tools/Scripts/webkit-patch, line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\tool\multicommandtool.py, line 304, in main self.handle_global_options(options) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\tool\main.py, line 94, in handle_global_options self.initialize_scm(options.patch_directories) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\host.py, line 132, in initialize_scm self._scm = detector.default_scm(patch_directories) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\detection.py, line 55, in default_scm scm_system = self.detect_scm_system(cwd, patch_directories) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\detection.py, line 71, in detect_scm_system if SVN.in_working_directory(absolute_path, executive=self._executive): File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\svn.py, line 93, in in_working_directory exit_code = executive.run_command(svn_info_args, cwd=path, return_exit_code=True) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\system\executive.py, line 405, in run_command close_fds=self._should_close_fds()) File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\system\executive.py, line 461, in popen return subprocess.Popen(*args, **kwargs) File c:\Python27\lib\subprocess.py, line 679, in __init__ errread, errwrite) File c:\Python27\lib\subprocess.py, line 893, in _execute_child startupinfo) WindowsError: [Error 2] The system cannot find the file specified == Running Tools/Scripts/prepare-ChangeLog worked ok, but I was under the impression that webkit-patch is preferred as it automates a lot more aspects of the workflow (is that correct?) Thanks in advance for your guidance. Regards, Sze-Howe ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- Rafael Brandao @ INdT ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Getting started with making Qt WebKit patches
On Mon, Mar 25, 2013 at 12:07:13PM -0300, Rafael Brandao wrote: You're probably missing subversion package. If you're on ubuntu, sudo apt-get install subversion should do the trick. On Mon, Mar 25, 2013 at 12:00 PM, Sze Howe Koh szehowe@gmail.comwrote: Hello, I'm trying to submit a patch for Qt WebKit. I've applied the patch to my local copy of qtwebkit.git, but am having trouble using webkit-patch. What am I missing? You might also want to know that qtwebkit.git has a few directories stripped, please use the official git://git.webkit.org/WebKit.git or https://github.com/WebKit/webkit repositories instead. I'm running Windows 8 x64, Git version 1.8.0.msysgit.0, and ActivePython 2.7.2 x64. From Git Bash, I called `Tools/Scripts/webkit-patch prepare --cc=hausm...@webkit.org' AFAIK nobody is maintaining webkit-patch on Windows, it currently works much better on Mac and Linux. It's also not possible to run tests for QtWebKit on Windows. Running Tools/Scripts/prepare-ChangeLog worked ok, but I was under the impression that webkit-patch is preferred as it automates a lot more aspects of the workflow (is that correct?) After running prepare-ChangeLog you can create a bug and upload a patch manually. See http://www.webkit.org/coding/contributing.html for more info. Cheers, Jocelyn p.s. For QtWebKit-specific questions https://lists.webkit.org/mailman/listinfo/webkit-qt is a better place to ask. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
