[webkit-dev] webkitbot unable to roll out patches
I tried using webkitbot tonight to roll out a patch, but it’s encountering an error running `update-webkit`. [23:42:16] estes webkitbot: rollout r172697 made two webarchive layout tests start flaking [23:42:18] webkitbot estes: Preparing rollout for http://trac.webkit.org/changeset/172697 http://trac.webkit.org/changeset/172697 ... [23:42:39] webkitbot Exception executing command: Failed to run ['Tools/Scripts/update-webkit'] exit_code: 1 Ossy rebooted the bot but the error persists. Perhaps something's gone wrong with the bot’s working copy? Andy___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] webkitbot unable to roll out patches
How could Ossy reboot the bot!? As far as I know, he doesn't have the access to the machine on which webkitbot is running. Having said that, are you sure there are no conflicts? That error usually occurs when there is some other change such that we can't simply reverse apply the specified revision. - R. Niwa On Sun, Aug 17, 2014 at 11:54 PM, Andy Estes aes...@apple.com wrote: I tried using webkitbot tonight to roll out a patch, but it's encountering an error running `update-webkit`. [23:42:16] estes webkitbot: rollout r172697 made two webarchive layout tests start flaking [23:42:18] webkitbot estes: Preparing rollout for http://trac.webkit.org/changeset/172697 ... [23:42:39] webkitbot Exception executing command: Failed to run ['Tools/Scripts/update-webkit'] exit_code: 1 Ossy rebooted the bot but the error persists. Perhaps something's gone wrong with the bot's working copy? Andy ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] webkitbot unable to roll out patches
On Aug 18, 2014, at 12:17 AM, Ryosuke Niwa rn...@webkit.org wrote: How could Ossy reboot the bot!? As far as I know, he doesn't have the access to the machine on which webkitbot is running. webkitbot has a restart option. Having said that, are you sure there are no conflicts? That error usually occurs when there is some other change such that we can't simply reverse apply the specified revision. I’m not sure, but since the error was with update-webkit rather than with svn-apply I didn’t suspect a failure to revert the patch. Andy___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] webkitbot unable to roll out patches
On Mon, Aug 18, 2014 at 12:19 AM, Andy Estes aes...@apple.com wrote: On Aug 18, 2014, at 12:17 AM, Ryosuke Niwa rn...@webkit.org wrote: How could Ossy reboot the bot!? As far as I know, he doesn't have the access to the machine on which webkitbot is running. webkitbot has a restart option. That command doesn't really reboot the machine. We should probably remove that option entirely. Having said that, are you sure there are no conflicts? That error usually occurs when there is some other change such that we can't simply reverse apply the specified revision. I'm not sure, but since the error was with update-webkit rather than with svn-apply I didn't suspect a failure to revert the patch. Okay. I'll take a look. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] ftlopt merge - basically done
Has anyone managed to make an FTL build on Linux? Yong Li From: Sergio Villar Seninmailto:svil...@igalia.com Sent: 8/7/2014 11:58 AM To: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] ftlopt merge - basically done On 06/08/14 23:35, Filip Pizlo wrote: Hi everyone, The JSC “ftlopt” branch is basically merged. I think I have one more revision to merge over, and it is a minor one. Please don’t land more things on the branch. Landing on trunk is fine; it’s unlikely to get in my way as I merge the last revision over. Thanks to everyone who helped with diagnostic problems and fixing things! For those not following the development in that branch, mind sharing details about what that work was about? BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] ftlopt merge - basically done
It works fine with EFL port on x86_64 Linux. You only need the following things: (on Ubuntu 14.04!) - apply the patch from https://bugs.webkit.org/show_bug.cgi?id=133571 - run sudo Tools/efl/install-dependencies - run WEBKIT_EXTRA_MODULES=llvm Tools/Scripts/update-webkitefl-libs - run Tools/Scripts/build-webkit --efl --ftl-jit Yong Li írta: Has anyone managed to make an FTL build on Linux? Yong Li ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] ftlopt merge - basically done
Thanks a lot:) Yong Li From: Osztrogonác Csabamailto:o...@inf.u-szeged.hu Sent: 8/18/2014 3:51 PM To: WebKit Developmentmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] ftlopt merge - basically done It works fine with EFL port on x86_64 Linux. You only need the following things: (on Ubuntu 14.04!) - apply the patch from https://bugs.webkit.org/show_bug.cgi?id=133571 - run sudo Tools/efl/install-dependencies - run WEBKIT_EXTRA_MODULES=llvm Tools/Scripts/update-webkitefl-libs - run Tools/Scripts/build-webkit --efl --ftl-jit Yong Li írta: Has anyone managed to make an FTL build on Linux? Yong Li ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] ftlopt merge - basically done
Of course, I will look. -Filip On Aug 8, 2014, at 12:59 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: Hi Filip, the latest part of ftlopt branch merge made some performance tests crash everywhere. I filed a bug report with the details: https://bugs.webkit.org/show_bug.cgi?id=135750 Could you possible fix this regression? br, Ossy Filip Pizlo írta: Hi everyone, The JSC ftlopt branch is basically merged. I think I have one more revision to merge over, and it is a minor one. Please don't land more things on the branch. Landing on trunk is fine; it's unlikely to get in my way as I merge the last revision over. Thanks to everyone who helped with diagnostic problems and fixing things! -Filip ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] ftlopt merge - basically done
The big items are: - Getter/setter inlining that is up to par with normal call inlining. - Immutable property inference. - GCSE. - Better reasoning about polymorphism. - The beginnings of a type profiling infrastructure for the inspector. -Filip On Aug 7, 2014, at 1:58 AM, Sergio Villar Senin svil...@igalia.com wrote: On 06/08/14 23:35, Filip Pizlo wrote: Hi everyone, The JSC “ftlopt” branch is basically merged. I think I have one more revision to merge over, and it is a minor one. Please don’t land more things on the branch. Landing on trunk is fine; it’s unlikely to get in my way as I merge the last revision over. Thanks to everyone who helped with diagnostic problems and fixing things! For those not following the development in that branch, mind sharing details about what that work was about? BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Proposal: Remove ENABLE(SUBPIXEL_LAYOUT)
Hi Everyone, I’d like to propose removing ENABLE(SUBPIXEL_LAYOUT), as every port has it enabled. As part of this activity, I am planning to enable SATURATED_LAYOUT_ARITHMETIC by default. Thanks, Zalan. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SUBPIXEL_LAYOUT)
Hi, On 08/18/2014 08:14 PM, Zalan Bujtas wrote: Hi Everyone, I’d like to propose removing ENABLE(SUBPIXEL_LAYOUT), as every port has it enabled. As part of this activity, I am planning to enable SATURATED_LAYOUT_ARITHMETIC by default. Thanks, Zalan. I've already opened a bug to address this issue, but unfortunately, didn't find the time to complete the task. See https://bugs.webkit.org/show_bug.cgi?id=124234 for details. -- javi ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SUBPIXEL_LAYOUT)
Hi, Quote for from bug #124234 Since the SATURATED_LAYOUT_ARITHMETIC flag makes no sense without SUBPIXEL_LAYOUT, actually there is an assertion preventing this, it seems that the most sensible action is to merge the SATURATED_LAYOUT_ARITHMETIC logic into the SUBPIXEL_LAYOUT, and eventually removing it.” Makes sense. I might just remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) too (instead of just enable it by default). Zalan. On Aug 18, 2014, at 12:47 PM, Javier Fernandez jfernan...@igalia.com wrote: Hi, On 08/18/2014 08:14 PM, Zalan Bujtas wrote: Hi Everyone, I’d like to propose removing ENABLE(SUBPIXEL_LAYOUT), as every port has it enabled. As part of this activity, I am planning to enable SATURATED_LAYOUT_ARITHMETIC by default. Thanks, Zalan. I've already opened a bug to address this issue, but unfortunately, didn't find the time to complete the task. See https://bugs.webkit.org/show_bug.cgi?id=124234 for details. -- javi ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
