Re: [webkit-dev] Streams API
On Fri, Oct 31, 2014 at 9:07 AM, Benjamin Poulain benja...@webkit.org wrote: Any opinion for or against Streams? Do you know if Mozilla intends to implement it? I'm in favor of having IO streams :-) There's so many features that could be made better by having them. I don't think anyone from Mozilla has looked at https://streams.spec.whatwg.org/ in detail, but I could be mistaken. If I find out I'll let you know. -- https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] gtk failure
I submitted a patch for the bug https://bugs.webkit.org/show_bug.cgi?id=137132 https://bugs.webkit.org/show_bug.cgi?id=137132 The build failed for gtk-wk2 but passed for mac and mac-wk2. Here is the failure. Last 500 characters of output: e/CMakeFiles/WebCore.dir/rendering/style/RenderStyle.cpp.o -c ../../Source/WebCore/rendering/style/RenderStyle.cpp ../../Source/WebCore/rendering/style/RenderStyle.cpp: In member function 'WebCore::Color WebCore::RenderStyle::colorIncludingFallback(int, bool) const': ../../Source/WebCore/rendering/style/RenderStyle.cpp:1525:10: error: 'CSSPropertyWebkitColumnRuleColor' was not declared in this scope case CSSPropertyWebkitColumnRuleColor: In the patch I have the following change Source/WebCore/rendering/style/RenderStyle.cpp http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/style/RenderStyle.cpp @@Color RenderStyle::colorIncludingFallbac 15221522case CSSPropertyOutlineColor: 15231523result = visitedLink ? visitedLinkOutlineColor() : outlineColor(); 15241524break; 1525 case CSSPropertyWebkitColumnRuleColor: 1525case CSSPropertyColumnRuleColor: 15261526result = visitedLink ? visitedLinkColumnRuleColor() : columnRuleColor(); 15271527break; 15281528case CSSPropertyWebkitTextDecorationColor: I am un-prefixing the column rule color property. So I replaced CSSPropertyWebkitColumnRuleColor with CSSPropertyColumnRuleColor. But the failure is saying the prefixed property is not defined. How can for gtk-wk2 only, the patch is not applied in RenderStyle.cpp but is applied with other files and is applied also for all files for the mac platform? Thanks, Said___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Disk cache
Hello, I'm planning to add an experimental HTTP cache implementation to WebKit ( https://bugs.webkit.org/show_bug.cgi?id=30322). The main motivations are: - Improving performance by bringing the cache closer. For example we can serialize WebKit response objects directly instead of converting to/from platform types. - Making future innovation around caching easier. Closer coordination between cache and WebKit opens new optimization possibilities. The cache lives in the network process. Most of the code is cross-platform. The storage backend uses libdispatch IO though it wouldn't be hard to add a generic posix one too. The code will be behind NETWORK_CACHE feature flag. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] gtk failure
Hi Said, Can you please resubmit your patch? The EWS build directory was cleaned-up. Philippe On Fri, 2014-10-31 at 09:55 -0700, Said Abou-Hallawa wrote: I submitted a patch for the bug https://bugs.webkit.org/show_bug.cgi?id=137132 The build failed for gtk-wk2 but passed for mac and mac-wk2. Here is the failure. Last 500 characters of output: e/CMakeFiles/WebCore.dir/rendering/style/RenderStyle.cpp.o -c ../../Source/WebCore/rendering/style/RenderStyle.cpp ../../Source/WebCore/rendering/style/RenderStyle.cpp: In member function 'WebCore::Color WebCore::RenderStyle::colorIncludingFallback(int, bool) const': ../../Source/WebCore/rendering/style/RenderStyle.cpp:1525:10: error: 'CSSPropertyWebkitColumnRuleColor' was not declared in this scope case CSSPropertyWebkitColumnRuleColor: In the patch I have the following change Source/WebCore/rendering/style/RenderStyle.cpp @@Color RenderStyle::colorIncludingFallbac 15221522 case CSSPropertyOutlineColor: 15231523 result = visitedLink ? visitedLinkOutlineColor() : outlineColor(); 15241524 break; 1525 case CSSPropertyWebkitColumnRuleColor: 1525 case CSSPropertyColumnRuleColor: 15261526 result = visitedLink ? visitedLinkColumnRuleColor() : columnRuleColor(); 15271527 break; 15281528 case CSSPropertyWebkitTextDecorationColor: I am un-prefixing the column rule color property. So I replaced CSSPropertyWebkitColumnRuleColor with CSSPropertyColumnRuleColor. But the failure is saying the prefixed property is not defined. How can for gtk-wk2 only, the patch is not applied in RenderStyle.cpp but is applied with other files and is applied also for all files for the mac platform? Thanks, Said ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Disk cache
Would anything special need to be done for Windows? Alex On Oct 31, 2014, at 11:02 AM, Antti Koivisto koivi...@iki.fi wrote: Hello, I'm planning to add an experimental HTTP cache implementation to WebKit (https://bugs.webkit.org/show_bug.cgi?id=30322). The main motivations are: - Improving performance by bringing the cache closer. For example we can serialize WebKit response objects directly instead of converting to/from platform types. - Making future innovation around caching easier. Closer coordination between cache and WebKit opens new optimization possibilities. The cache lives in the network process. Most of the code is cross-platform. The storage backend uses libdispatch IO though it wouldn't be hard to add a generic posix one too. The code will be behind NETWORK_CACHE feature flag. antti ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
