Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2
On Fri, May 22, 2015 at 1:50 PM, Gyuyoung Kim wrote: > I also don't want to support the "content handler" feature at the moment. > The feature might be more clear and mature. The patch of Bug 92749 only > supports registerProtocolHandler, > and unregisterProtocolHandler and isProtocolHandlerRegistered are supported > as optional. > > https://bugs.webkit.org/show_bug.cgi?id=92749 Quickly scanning the bug I couldn't figure out whether you added hooks to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, see the discussion in this bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 My personal opinion is that these schemes should only have an effect if you navigate to them, not if you fetch them (the latter should result in a network error in my opinion). -- https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2
> Quickly scanning the bug I couldn't figure out whether you added hooks > to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, > see the discussion in this bug: > https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 > My personal opinion is that these schemes should only have an effect > if you navigate to them, not if you fetch them (the latter should > result in a network error in my opinion). Current implementation doesn't hook to HTML's navigation directly. We delegate the html navigation(or call native application) to application. Application is able to decide to navigate the given html page or execute native application through the patch. As far as I know, Chrome also has similar implementation. If this feature can be landed, I have a plan to test this scenario based on mock implementation. Gyuyoung. On Fri, May 22, 2015 at 5:52 PM, Anne van Kesteren wrote: > On Fri, May 22, 2015 at 1:50 PM, Gyuyoung Kim > wrote: > > I also don't want to support the "content handler" feature at the moment. > > The feature might be more clear and mature. The patch of Bug 92749 only > > supports registerProtocolHandler, > > and unregisterProtocolHandler and isProtocolHandlerRegistered are > supported > > as optional. > > > > https://bugs.webkit.org/show_bug.cgi?id=92749 > > Quickly scanning the bug I couldn't figure out whether you added hooks > to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, > see the discussion in this bug: > > https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 > > My personal opinion is that these schemes should only have an effect > if you navigate to them, not if you fetch them (the latter should > result in a network error in my opinion). > > > -- > https://annevankesteren.nl/ > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2
> Quickly scanning the bug I couldn't figure out whether you added hooks > to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, > see the discussion in this bug: > https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 > My personal opinion is that these schemes should only have an effect > if you navigate to them, not if you fetch them (the latter should > result in a network error in my opinion). Current implementation doesn't hook to HTML's navigation directly. We delegate the html navigation(or call native application) to application. Application is able to decide to navigate the given html page or execute native application through the patch. As far as I know, Chrome also has similar implementation. If this feature can be landed, I have a plan to test this scenario based on mock implementation. Gyuyoung. On Fri, May 22, 2015 at 5:52 PM, Anne van Kesteren wrote: > On Fri, May 22, 2015 at 1:50 PM, Gyuyoung Kim > wrote: > > I also don't want to support the "content handler" feature at the moment. > > The feature might be more clear and mature. The patch of Bug 92749 only > > supports registerProtocolHandler, > > and unregisterProtocolHandler and isProtocolHandlerRegistered are > supported > > as optional. > > > > https://bugs.webkit.org/show_bug.cgi?id=92749 > > Quickly scanning the bug I couldn't figure out whether you added hooks > to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, > see the discussion in this bug: > > https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 > > My personal opinion is that these schemes should only have an effect > if you navigate to them, not if you fetch them (the latter should > result in a network error in my opinion). > > > -- > https://annevankesteren.nl/ > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2
On Fri, May 22, 2015 at 6:43 PM, Gyuyoung Kim wrote: > Current implementation doesn't hook to HTML's navigation directly. We > delegate the html navigation(or call native application) to application. > Application is able to decide to navigate the given html page or execute > native application through the patch. As far as I know, Chrome also has > similar implementation. Okay, so results in a network error and not a fetch to the registered URL? -- https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2
Hi Anne, I need to verify the behaviour using the patch though, I think the registered URL isn't fetched under current patch of Bug 92749. However I need to check if the registered URL is passed to application under the patch's implementation. If this feature will be landed to WK2, it would be good if we add a test to check it. Let me do it. Gyuyoung. On Sat, May 23, 2015 at 9:55 AM, Anne van Kesteren wrote: > On Fri, May 22, 2015 at 6:43 PM, Gyuyoung Kim > wrote: > > Current implementation doesn't hook to HTML's navigation directly. We > > delegate the html navigation(or call native application) to application. > > Application is able to decide to navigate the given html page or execute > > native application through the patch. As far as I know, Chrome also has > > similar implementation. > > Okay, so > > > > results in a network error and not a fetch to the registered URL? > > > -- > https://annevankesteren.nl/ > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
