[webkit-dev] CC on reviewed bugs

2016-01-07 Thread Michael Catanzaro 
Hi,

I notice that when my only comment on a bug is the comment added using
the WebKit review feature, I do not get CCed on the bug and so do not
notice follow-up responses to my review.

It would be awesome if auto-CC could be implemented. I always want to
be CCed on bugs with patches I have reviewed.

Please be careful to CC yourself manually in the meantime.

Michael
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] CC on reviewed bugs

2016-01-07 Thread Brian Burg 
The only reason that normal commenting will CC you is that the [X] Add me to CC 
list is checked by default.
I agree it would be reasonable to duplicate that behavior when commenting via 
the review tool.

To do this, you’d have to modify “sub update()” in attachment.cgi, and pass in 
some new parameter.
I recommend filing a bug so we can deliberate how to implement it.

-Brian

> On Jan 7, 2016, at 12:48 PM, Michael Catanzaro  wrote:
> 
> Hi,
> 
> I notice that when my only comment on a bug is the comment added using
> the WebKit review feature, I do not get CCed on the bug and so do not
> notice follow-up responses to my review.
> 
> It would be awesome if auto-CC could be implemented. I always want to
> be CCed on bugs with patches I have reviewed.
> 
> Please be careful to CC yourself manually in the meantime.
> 
> Michael
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] CC on reviewed bugs

2016-01-07 Thread Michael Catanzaro 
On Thu, 2016-01-07 at 13:09 -0800, Brian Burg wrote:
> The only reason that normal commenting will CC you is that the [X]
> Add me to CC list is checked by default.
> I agree it would be reasonable to duplicate that behavior when
> commenting via the review tool.
> 
> To do this, you’d have to modify “sub update()” in attachment.cgi,
> and pass in some new parameter.
> I recommend filing a bug so we can deliberate how to implement it.
> 
>   -Brian

OK: https://bugs.webkit.org/show_bug.cgi?id=152854

Thanks,

Michael
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev