Re: [webkit-dev] JSObjectGetClass proposal

2016-07-22 Thread Darin Adler
> On Jul 22, 2016, at 6:16 AM, Danilo Cesar Lemes de Paula > wrote: > > My > best option until now was defining a specific property during object > creation containing another object with the private pointer set to the > JSClassRef itself (as the main object SetPrivate

Re: [webkit-dev] Strange result in fast/backgrounds/mask-composite.html

2016-07-22 Thread Simon Fraser
> On Jul 22, 2016, at 4:20 PM, Konstantin Tokarev wrote: > > Hello, > > I'm getting attached result for fast/backgrounds/mask-composite.html, while > in the tree expected result looks like > >

[webkit-dev] Strange result in fast/backgrounds/mask-composite.html

2016-07-22 Thread Konstantin Tokarev
Hello, I'm getting attached result for fast/backgrounds/mask-composite.html, while in the tree expected result looks like https://trac.webkit.org/browser/trunk/LayoutTests/platform/gtk/fast/backgrounds/mask-composite-expected.png

[webkit-dev] "Fake" ref-tests

2016-07-22 Thread Konstantin Tokarev
Hello, I've stumbled upon two ref-tests: fast/borders/border-painting-correctness-dashed.html fast/borders/border-painting-correctness-dotted.html Their references have a form of body { margin: 0px; } where img represents correct rendering of borders in mac port. As a result,

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Darin Adler
> On Jul 22, 2016, at 10:25 PM, Alexey Proskuryakov wrote: > > Simon and I were trying to move all tests out of platform/ directories. Is this nearly done? Can we take that feature out of the test running script? Anyone have any objections to this? — Darin

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Alexey Proskuryakov
> 22 июля 2016 г., в 21:57, Darin Adler написал(а): > >> What is the right way to deal with tests like these? > > I think we should move the tests into platform/mac. Simon and I were trying to move all tests out of platform/ directories. When the expected results are

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Darin Adler
> On Jul 22, 2016, at 4:14 PM, Konstantin Tokarev wrote: > > What is the right way to deal with tests like these? I think we should move the tests into platform/mac. > I think it would be better to convert such tests to pixel tests. No, because we don’t run pixel tests. —

Re: [webkit-dev] "Fake" ref-tests

2016-07-22 Thread Alexey Proskuryakov
> 22 июля 2016 г., в 22:34, Darin Adler написал(а): > >> On Jul 22, 2016, at 10:25 PM, Alexey Proskuryakov wrote: >> >> Simon and I were trying to move all tests out of platform/ directories. > > Is this nearly done? Can we take that feature out of the test

Re: [webkit-dev] JSObjectGetClass proposal

2016-07-22 Thread Danilo Cesar Lemes de Paula
On 21-07-2016 18:28, Darin Adler wrote: >> On Jul 21, 2016, at 12:09 PM, Danilo Cesar Lemes de Paula >> wrote: >> >> How to create a JSObjectRef as the same type as another one. > > Just curious: Is that something you can do in JavaScript itself? Actually, this is a bit