Re: [webkit-dev] CSS Parse error in element.

2017-02-06 Thread Yoav Weiss
Hi Atul, I second Alex's suggestion (perhaps followed by HTMLLinkElement::process() and other places in that file that refer to `hrefAttr`). If you have a test case online, I could try to take a look and maybe provide more guidance. Cheers :) Yoav On Fri, Feb 3, 2017 at 9:19 PM Alex Christensen

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread youenn fablet
I filed https://bugs.webkit.org/show_bug.cgi?id=167911. Le lun. 6 févr. 2017 à 16:22, youenn fablet a écrit : > It seems we agree in moving this forward. Any objection? > If so, let's start with small practical steps, something like a script to > automatically generate WPT PR

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Philip Jägenstedt
On Mon, Feb 6, 2017 at 7:32 PM Ryosuke Niwa wrote: > On Mon, Feb 6, 2017 at 4:22 PM, youenn fablet wrote: > > It seems we agree in moving this forward. Any objection? > If so, let's start with small practical steps, something like a script to > automatically

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Alexey Proskuryakov
> 6 февр. 2017 г., в 12:28, Ryosuke Niwa написал(а): > > The concern I've heard about is not how run-webkit-tests run the tests. It's > about how a test is opened inside a browser, DRT, WTR while debugging. +1 I think that making web platform tests more practical for

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Ryosuke Niwa
On Mon, Feb 6, 2017 at 4:22 PM, youenn fablet wrote: > It seems we agree in moving this forward. Any objection? > If so, let's start with small practical steps, something like a script to > automatically generate WPT PR requests from a WebKit repo. > I think we need to first

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread youenn fablet
It seems we agree in moving this forward. Any objection? If so, let's start with small practical steps, something like a script to automatically generate WPT PR requests from a WebKit repo. Le lun. 6 févr. 2017 à 12:28, Ryosuke Niwa a écrit : > > On Monday, February 6, 2017,

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread youenn fablet
The two complaints I heard against testharness.js are: > - They are less easy to debug as test harness.js does not print out > messages for each assert. There might be room for updating testharness to > support that > - Async tests are less easy to write. While this is probably true, >

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Ryosuke Niwa
On Monday, February 6, 2017, youenn fablet wrote: > The two complaints I heard against testharness.js are: > >> - They are less easy to debug as test harness.js does not print out >>> messages for each assert. There might be room for updating testharness to >>> support that

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Ryosuke Niwa
On Sun, Feb 5, 2017 at 5:04 PM, youenn fablet wrote: > I too am a big proponent of us moving more and more towards WPT. > As part of the streams and fetch API implementation, most of the related > functional tests have been made as WPT. > The benefits of having tests being

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-06 Thread Ryosuke Niwa
On Sun, Feb 5, 2017 at 6:54 PM, Philip Jägenstedt wrote: > FWIW, in Blink we stopped rewriting the testharness.js paths before > switching to wptserve, by instead rewriting those URLs only when running > LayoutTests: > https://cs.chromium.org/chromium/src/content/shell/ >