Re: [webkit-dev] PAL Strategy

[Maciej Stachowiak]

> On May 1, 2017, at 1:48 PM, Brady Eidson  wrote:
> 
> 
>> On May 1, 2017, at 12:41 PM, Michael Catanzaro  wrote:
>> 
>> I thought the original intent for PAL was to replace WebCore/platform, so I 
>> assume the criterion would be "stuff currently in WebCore/platform." If not, 
>> then I'd question the value of having PAL at all, as we really don't need a 
>> separate PAL on top of the platform abstraction library we already have 
>> under in Source/WebCore/platform.

I don't think anyone proposed that PAL should be on top of WebCore/platform. 
Instead, the question is if some things should be moved to WTF instead of to 
PAL. PAL is allowed to depend on WTF. JavaScriptCore is allowed to depend on 
WTF but not on PAL. This means that some things might be ok to put in either 
WTF or PAL.

>> 
>> The stuff that moved to WTF was needed in JSC. If we want to keep stuff like 
>> UUID from moving to WTF, then we'd need to allow JSC to depend on PAL, 
>> rather than vice-versa.
> 
> I think everything in WebCore/platform should be moved to PAL.
> 
> WTF should only be for things JSC needs, which is nothing inside 
> WebCore/platform.
> 
> If JSC later needs something that is in PAL, we can move it from PAL to WTF 
> as needed.


My 2c:

Things with no additional dependencies beyond what WTF has already might be ok 
to move to WTF, but it's not required to do so. For example, WTF has most of 
our implementations of container types, so more like those would be ok. I think 
it already has some that are only used in WebCore not in JSC.

Things that introduce new dependencies probably should not be moved. I think 
FileSystem would imply new dependencies on file operations which I don't think 
are currently used in WTF. The exception would be if JSC needs it for some 
reason.

Dependency on GUI toolkits would definitely be a hard no for WTF, since we want 
JSC to be independent of that.

Regards,
Maciej



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] PAL Strategy

[Michael Catanzaro]

I thought the original intent for PAL was to replace WebCore/platform, 
so I assume the criterion would be "stuff currently in 
WebCore/platform." If not, then I'd question the value of having PAL at 
all, as we really don't need a separate PAL on top of the platform 
abstraction library we already have under in Source/WebCore/platform.


The stuff that moved to WTF was needed in JSC. If we want to keep stuff 
like UUID from moving to WTF, then we'd need to allow JSC to depend on 
PAL, rather than vice-versa.


Michael

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] PAL Strategy

[Brady Eidson]

> On May 1, 2017, at 12:41 PM, Michael Catanzaro  wrote:
> 
> I thought the original intent for PAL was to replace WebCore/platform, so I 
> assume the criterion would be "stuff currently in WebCore/platform." If not, 
> then I'd question the value of having PAL at all, as we really don't need a 
> separate PAL on top of the platform abstraction library we already have under 
> in Source/WebCore/platform.
> 
> The stuff that moved to WTF was needed in JSC. If we want to keep stuff like 
> UUID from moving to WTF, then we'd need to allow JSC to depend on PAL, rather 
> than vice-versa.

I think everything in WebCore/platform should be moved to PAL.

WTF should only be for things JSC needs, which is nothing inside 
WebCore/platform.

If JSC later needs something that is in PAL, we can move it from PAL to WTF as 
needed.

Thanks,
~Brady

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] PAL Strategy

[Olmstead, Don]

Hey all,

As we mentioned during the contributors meeting we want to work towards 
fleshing out the PAL library. We have the cycles to really start rolling on it 
but are hitting some issues we wanted to run by the community.

Currently the obvious stuff to move over into PAL, network, graphics and text, 
has dependencies on some non-obvious stuff, such as FileSystem. We've also hit 
a couple cases, UUID and CPUTime, where they ended up moving into WTF while we 
were moving things into PAL.

We wanted to get the opinion of the community about a strategy going forward so 
we can get rolling on everything and land some patches. It would be good to 
identify any sort of general criteria for what goes in WTF and what goes into 
PAL.

At the moment I'm debating whether FileSystem and its related classes should go 
into WTF or PAL and am leaning more towards WTF at the moment so maybe that's 
something worth discussing.

Thanks for any feedback!
Don
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev