We already had this discussion; see the thread titled "Unified sources have
broken our #include hygiene"
> On Mar 19, 2019, at 3:48 PM, Said Abou-Hallawa wrote:
>
> I have been working on patches that require adding and removing cpp files
> from WebCore/Sources.txt. Almost every time I add or
I have been working on patches that require adding and removing cpp files from
WebCore/Sources.txt. Almost every time I add or remove a file, I hit undefined
symbol compilation error in some unrelated source or header file. Because a
group of source files are compiled in one unified source
Ah, good to know! Thank you Michael :)
Tom
On Tue, Mar 19, 2019 at 1:42 PM Michael Catanzaro
wrote:
> On Tue, Mar 19, 2019 at 12:57 AM, Tomas Popela
> wrote:
> > If a note from
> >
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66
> > applies,
On 19/03/2019 00:56, Michael Catanzaro wrote:
> On Mon, Mar 18, 2019 at 4:43 PM, Andy Estes wrote:
>> FWIW, Apple’s ports use the equivalent clang warning for pessimizing
>> and redundant moves, and we cleaned up a bunch of these mistakes in
>> our ports a few years ago. Hopefully you aren’t
On Tue, Mar 19, 2019 at 12:57 AM, Tomas Popela
wrote:
If a note from
https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66
applies, then you can't fix it until we support Ubuntu 14.04 (due to
its old gcc version):
Turns out the
std::move can only
Several more return WTFMove() cases were committed just between
yesterday and today. Please be careful. :)
On Tue, Mar 19, 2019 at 8:01 AM, Emilio Cobos
=?iso-8859-1?q?=C1lvarez?= wrote:
In Gecko, when I switched from mozilla::Move to std::move [1], I had
to
disable the warning and fix all
6 matches
Mail list logo
