On Tue, Jan 24 2023 at 02:53:42 PM -0600, Michael Catanzaro
wrote:
E.g. for GObjects, we could write GWeakPtr, but this would not be
very ergonomic, and it won't work for arbitrary types.
So Carlos Garcia added this in https://commits.webkit.org/259482@main.
There is a downside to GWeakPtr:
On Wed, Jan 25, 2023 at 5:54 AM Michael Catanzaro via webkit-dev <
webkit-dev@lists.webkit.org> wrote:
>
> Thinking about this more, I'm not sure this plan works for WeakPtrs?
> Say we have:
>
> WeakPtr f = /* initialized somehow */;
> if (Foo* f = f.get())
> {
> // do something
> }
>
> Then we
On Thu, Jan 26 2023 at 12:31:25 AM -0800, Myles Maxfield via webkit-dev
wrote:
Okay, sounds like we’re all pretty much in agreement.
How about I add a rule to our style guide that says “use unsigned
types to represent values which cannot be negative.”
Good idea?
This is pretty strict.
On Fri, Jan 27 2023 at 10:52:52 AM -0600, Michael Catanzaro
wrote:
There is probably a relatively high cost compared to WTF::WeakPtr, so
I'd say it should be used only when it provides valuable safety (e.g.
in member variables) rather than spammed (e.g. in local variables).
Another good use
As of 259501@main, we now have both, GitHub label "skip-ews" and git-webkit pr
support for --skip-ews flag.
Thanks
Aakash
> On Jan 26, 2023, at 3:58 PM, Geoffrey Garen wrote:
>
> This is great!
>
> As it is said in "Ghost Dog: The Way of the Samurai", it is bad when one
> thing becomes two.
5 matches
Mail list logo
