Re: [webkit-dev] WebKit coverage (a little welcome present)
On May 4, 2007, at 2:48 PM, Holger Freyther wrote: Hey, I adjusted, updated and improved my gcov scripts and let it run on the WebKit repository. Leopard will probably have something more visually appealing but for everyone not at Apple this http:// www.openembedded.org/~zecke/coverage/webkit/mac/index.html might look interesting. The commands that were run: WebKitTools/Scripts/build-webkit GCC_GENERATE_TEST_COVERAGE_FILES=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES EXTRA_LINK= -ftest-coverage - fprofile-arcs OTHER_CFLAGS= -MD OTHER_LDFLAGS= -ftest-coverage -fprofile-arcs -framework AppKit WebKitTools/Scripts/run-webkit-tests WebKitTools/Scripts/run-javascriptcore-tests GCC_GENERATE_TEST_COVERAGE_FILES=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES EXTRA_LINK= -ftest-coverage - fprofile-arcs OTHER_CFLAGS= -MD OTHER_LDFLAGS= -ftest-coverage -fprofile-arcs -framework AppKit Open issues: Some files get compiled but are not executed so no .gcda,.gcna get generated. I could guess the line numbers and add them to the statistic. I could ignore these files, or just list them. So is that of interest for anyone? Looks awesome to me. I think we should get your scripts in the repository and consider setting up a buildbot to eventually run the tests in a gcov-enabled build. Can you submit some patches? Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WebKit coverage (a little welcome present)
On May 4, 2007, at 3:45 PM, Holger Freyther wrote: Am 04.05.2007 um 23:59 schrieb Maciej Stachowiak: So is that of interest for anyone? Looks awesome to me. I think we should get your scripts in the repository and consider setting up a buildbot to eventually run the tests in a gcov-enabled build. Can you submit some patches? For now the sourcecode can be found here www.openembedded.org/ ~zecke/coverage/webkit/WebKitToolsCoverage.tar but there are probably some issues which I want to mention before posting it to the bug tracker. - The .css and image files are copied from LTP (http:// ltp.sourceforge.net/coverage/lcov.php, http:// ltp.cvs.sourceforge.net/ltp/utils/analysis/lcov/bin/genhtml? revision=1.11view=markup). Is that GPL an issue, should we recreate a green, red and amber 1x1 image? Should the css be changed/recreated? We'd prefer not to have GPL code the repository. I think for green, red and amber images, recreating them is best. For the CSS, we could probably get someone to help make a clean room version unless the excerpt was small enough to constitute fair use. - The page layout is inspired by lcov as well. I don't think this is an issue. Agreed. - The regenerate-coverage-display and cov.py originate from the monotone project. ATM I try to track the origin and find the license. I have identified the original author and will drop him a mail. Thanks! Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
