Re: [webkit-dev] Re: [webkit-changes] [25269] trunk/LayoutTests

[Adam Treat]

On Tuesday 28 August 2007, Adam Roben wrote:
> On Aug 27, 2007, at 11:35 PM, [EMAIL PROTECTED] wrote:
> > Modified: trunk/LayoutTests/ChangeLog (25268 => 25269)
> > --- trunk/LayoutTests/ChangeLog 2007-08-28 05:59:26 UTC (rev 25268)
> > +++ trunk/LayoutTests/ChangeLog 2007-08-28 06:35:23 UTC (rev 25269)
> > @@ -1,5 +1,16 @@
> >  2007-08-27  Oliver Hunt  <[EMAIL PROTECTED]>
> >
> > +Reviewed by NOBODY (layout test result fix).
> > +
> > +Output of layoutTestController.dumpChildFramesAsText
> > changes in non-relevant way
> > +when running this test on its own vs. running as part of
> > the full suite.
> > +
> > +Correcting test result for the output produced while
> > running the full suite.
>
> Yikes! I wonder why this happens? I hate that we have all these tests
> that have differing results depending on which other tests have been
> run.
>
> -Adam

Interestingly enough, this patch fixes exactly this issue for the Qt port:

http://bugs.webkit.org/show_bug.cgi?id=14842

However, I based the fix off of what the Windows DRT does for testing.

Must be multiple bugs where this is happening...

Cheers,

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Re: [webkit-changes] [25269] trunk/LayoutTests

[Adam Roben]

On Aug 27, 2007, at 11:35 PM, [EMAIL PROTECTED] wrote:


Modified: trunk/LayoutTests/ChangeLog (25268 => 25269)
--- trunk/LayoutTests/ChangeLog 2007-08-28 05:59:26 UTC (rev 25268)
+++ trunk/LayoutTests/ChangeLog 2007-08-28 06:35:23 UTC (rev 25269)
@@ -1,5 +1,16 @@
 2007-08-27  Oliver Hunt  <[EMAIL PROTECTED]>

+Reviewed by NOBODY (layout test result fix).
+
+Output of layoutTestController.dumpChildFramesAsText  
changes in non-relevant way
+when running this test on its own vs. running as part of  
the full suite.

+
+Correcting test result for the output produced while  
running the full suite.
Yikes! I wonder why this happens? I hate that we have all these tests  
that have differing results depending on which other tests have been  
run.


-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] RE:Re: build QTwebkit errors on windows

[OYO]

Hi Jeff,

Enter the full URL, such as
http://www.google.com





pj_wh120 wrote:
> 
> hi  Adam  and Simon,
> Thanks for you reply, I changed the code as you said, the latter one,the
> error miss.
> Another, I want to know that the QTwebkit part have been finished basic
> browse function like "open a URL and display web page",because  I run
> per WebKitBuild\Release\bin\QtLauncher.exe 
> just a simple frame,I enter a URL link, no response, or maybe because I
> changed the 'WIN_OS' to 'WIN'?
> Thanks!
> Jeff.
>  
>  
>  
> 
>> Sounds like the build is legitimately broken. It would be great if
>> you could file a bug at !
>>
>> I think we have two options here:
>>
>> 1) Make the Windows Qt build link against shlwapi.lib (the library
>> that defines PathFindFileName)
>> 2) Change the call to PathFindFileName to only be #if PLATFORM(WIN)
>> (currently it's PLATFORM(WIN_OS), which includes Qt), and make a
>> PLATFORM(QT) version.
>>
>> I don't know which is the better choice for the Qt build. Perhaps
>> Lars or Simon have a better idea?
> 
> I like the latter idea :)
> 
> 
> Simon
> 
> ---
> 吉贝克 ——商业智能的领军者(
> http://d1.sina.com.cn/sina/limeng3/mail_zhuiyu/2007/mail_zhuiyu_20070723.html
> )
> 
> ===
> 注册新浪2G免费邮箱（http://mail.sina.com.cn/）
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 

-- 
View this message in context: 
http://www.nabble.com/RE%3ARe%3A-build-QTwebkit-errors-on-windows-tf4334048.html#a12364841
Sent from the Webkit mailing list archive at Nabble.com.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev