Re: [webkit-dev] Rounded border rendering

2008-02-21 Thread Fabian Jakobs
Hi David,
 Please file two bugs on http://bugs.webkit.org/:

 - One for the rounded border rendering (with screenshots of both 
 Firefox and
 Safari).
   
done: http://bugs.webkit.org/show_bug.cgi?id=17468

 - One for supporting short-hand notation with -webkit-border-radius.
   
I am no longer sure about this one. The spec 
http://www.w3.org/TR/2005/WD-css3-background-20050216/#the-border-radius 
does not mention shorthand mode for border-radius. I don't even know how 
this is supposed to work since e.g. border-top-right-radius allows two 
values. One for the horizontal radius and one for the vertical radius. 
This would be be eight values for shorthand mode. Firefox can do it 
because they only support one radius per corner.

BTW the documentation for border-radius at 
http://developer.apple.com/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/doc/uid/TP30001266-BoxModel
 
is incomplete. It does not mention that two radii for each corner can be 
specified.

Best Fabian

 Thanks!

 Dave


 Fabian Jakobs [EMAIL PROTECTED] wrote:

  
 Hi,

 I've been trying to implement cross browser rounded border support 
 for qooxdoo [1]. One thing I noticed was that webkit renders rounded 
 borders really strange if the border widths are different. The result 
 in firefox is much more pleasant. I have attached a small html test 
 file and screenshots in firefox 3 and webkit to illustrate it. I 
 couldn't  find any hints in the CSS3 draft of how rounded borders 
 should be rendered but I think the FF approach looks much better.

 Another issue is that the '-webkit-border-radius' does not support 
 the shorthand mode but '-moz-border-radius' does.

 Is this behaviour intended or should I report this as a bug?

 Best Fabian

 -- 
 Fabian Jakobs
 JavaScript Framework Developer

 11 Internet AG
 Brauerstraße 48
 76135 Karlsruhe

 Amtsgericht Montabaur HRB 6484

 Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Andreas 
 Gauger,
 Thomas Gottschlich, Matthias Greve, Robert Hoffmann, Markus Huhn, 
 Achim Weiss
 Aufsichtsratsvorsitzender: Michael Scheeren


 
 -
 Border Radius Test   #round {   
 margin: 30px;   width:
 100px;   height: 60px;  border-color: red 
 green blue purple;
border-style: solid;   border-width: 5px 10px 20px 
 10px; -moz-border-radius: 40px 10px 50px 
 20px;   /*
 -webkit-border-radius: 40px 10px 50px 20px;  DOES NOT WORK*/  
 -webkit-border-top-left-radius: 40px;  
 -webkit-border-top-right-radius: 10px;  
 -webkit-border-bottom-right-radius: 50px;  
 -webkit-border-bottom-left-radius: 20px;  
 background-color:
 gray;   } 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

 



   


-- 
Fabian Jakobs
JavaScript Framework Developer

11 Internet AG
Brauerstraße 48
76135 Karlsruhe

Amtsgericht Montabaur HRB 6484

Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Andreas 
Gauger, Thomas Gottschlich, Matthias Greve, Robert Hoffmann, Markus 
Huhn, Achim Weiss
Aufsichtsratsvorsitzender: Michael Scheeren


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Cairo WebKit with Windows XP

2008-02-21 Thread Joonwon Yi
Hi, Brent.

I'm trying to build on Windows now. I applied your patch 17442.
I failed to build Project WebKit because CGContextRef could not be converted to 
PlatformGraphicsContext * in the following files.

..\WebDragClient.cpp(235) : error C2664: 
'WebCore::GraphicsContext::GraphicsContext(PlatformGraphicsContext *)' :
..\WebFrame.cpp(2696) : error C2664: 'CGContextSaveGState' :

Did I miss something?
Thanks in advance.

- joonwon -


- Original Message - 
From: Brent Fulgham [EMAIL PROTECTED]
To: WebKit Development webkit-dev@lists.webkit.org
Sent: Thursday, February 21, 2008 1:26 PM
Subject: [webkit-dev] Cairo WebKit with Windows XP


 To all aspiring Windows hackers:
 
 The Font support patch (http://bugs.webkit.org/show_bug.cgi?id=17336)  
 and the WinLauncher/Spinneret patch 
 (http://bugs.webkit.org/show_bug.cgi?id=17428 
 ) have landed in the trunk, which should simplify the process of  
 getting a Cairo Windows build up and running.
 
 There is an important pending patch 
 (http://bugs.webkit.org/show_bug.cgi?id=17442 
 ) which corrects some bugs I created when mixing and matching the  
 original Cairo and new CoreGraphics internal GraphicsContext  
 representations.  This basically prevents some graphic image effects  
 (rotation of images, etc.) from working properly.
 
 I have another set of patches that need to be landed as well that re- 
 enable the Windows Theme support and provides a rudimentary scroll  
 bar.  I hope to get that posted today or tomorrow.
 
 Enjoy!
 
 -Brent
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] How to abstract text drag delay and hysteresis

2008-02-21 Thread Tor Arne Vestbø
Hi,

First of all, this is my first post to the webkit-dev list, so hi
everyone! :)

Now...we would like to provide values for text drag delay and hysteresis
based on Qt defaults. What would be the preferred way of abstracting this?

Adding #if PLATFORM(QT) in EventHandler.cpp does not sit quite right
with me, but maybe a global function?

Tor Arne

-- 
Tor Arne Vestbø, Software Engineer
Trolltech ASA, Oslo, Norway
http://www.trolltech.com/

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to abstract text drag delay and hysteresis

2008-02-21 Thread Maciej Stachowiak

On Feb 21, 2008, at 5:37 AM, Tor Arne Vestbø wrote:

 Hi,

 First of all, this is my first post to the webkit-dev list, so hi
 everyone! :)

 Now...we would like to provide values for text drag delay and  
 hysteresis
 based on Qt defaults. What would be the preferred way of abstracting  
 this?

 Adding #if PLATFORM(QT) in EventHandler.cpp does not sit quite right
 with me, but maybe a global function?

Ideally some code in WebCore/platform should abstract this out. Using  
global functions would be ok.

  - Maciej



 Tor Arne

 -- 
 Tor Arne Vestbø, Software Engineer
 Trolltech ASA, Oslo, Norway
 http://www.trolltech.com/

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Cairo WebKit with Windows XP

2008-02-21 Thread Brent Fulgham
Hi Joonwon:

On Thu, Feb 21, 2008 at 5:05 AM, Joonwon Yi [EMAIL PROTECTED] wrote:

 Hi, Brent.

 I'm trying to build on Windows now. I applied your patch 17442.
 I failed to build Project WebKit because CGContextRef could not be
 converted to PlatformGraphicsContext * in the following files.

 ..\WebDragClient.cpp(235) : error C2664:
 'WebCore::GraphicsContext::GraphicsContext(PlatformGraphicsContext *)' :
 ..\WebFrame.cpp(2696) : error C2664: 'CGContextSaveGState' :

 Did I miss something?


I apologize.  I did not generate a patch of my WebKit/WebKit directory
changes, as I had torn some things up getting scrollbars to work.

I will generate a patch this afternoon and send a link for the patch.

Sorry,

-Brent
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] autotools build q

2008-02-21 Thread Dozier, Bill
Hi,

I can build the GTK+ port with the build-webkit script, but I've been 
periodically trying the autotools way (since that will be the future supported 
route). Right now, it fails for me on:

checking for Hildon UI extensions... no
./configure: line 22777: syntax error near unexpected token `HILDON,'
./configure: line 22777: `PKG_CHECK_MODULES(HILDON, hildon-1)'
$

Thanks,
Bill




BEGIN:VCARD
VERSION:2.1
N:Dozier;Bill
FN:Dozier, Bill
ORG:amazon.com;Digital Technology (7801)
TITLE:Software Development Engineer
TEL;WORK;VOICE: 
TEL;HOME;VOICE: 
TEL;CELL;VOICE: 
TEL;PAGER;VOICE:None
ADR;WORK:;US1/794B
LABEL;WORK:US1/794B
EMAIL;PREF;INTERNET:[EMAIL PROTECTED]
REV:20060628T204323Z
END:VCARD
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] autotools build q

2008-02-21 Thread Dozier, Bill
There are brackets in configure.ac, but not in the configure that autogen 
builds.

 -Original Message-
 From: Mike Hommey [mailto:[EMAIL PROTECTED]
 Sent: Thursday, February 21, 2008 1:57 PM
 To: Dozier, Bill
 Cc: webkit-dev@lists.webkit.org
 Subject: Re: [webkit-dev] autotools build q

 On Thu, Feb 21, 2008 at 01:48:13PM -0800, Dozier, Bill wrote:
  Hi,
 
  I can build the GTK+ port with the build-webkit script, but I've been
 periodically trying the autotools way (since that will be the future
 supported route). Right now, it fails for me on:
 
  checking for Hildon UI extensions... no
  ./configure: line 22777: syntax error near unexpected token `HILDON,'
  ./configure: line 22777: `PKG_CHECK_MODULES(HILDON, hildon-1)'

 It should be better with brackets around HILDON, i.e. [HILDON].

 Mike
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] autotools build q

2008-02-21 Thread Mike Hommey
On Thu, Feb 21, 2008 at 01:58:31PM -0800, Dozier, Bill wrote:
 There are brackets in configure.ac, but not in the configure that autogen 
 builds.

Oh I see, the PKG_CHECK_MODULES wasn't expanded. Do you have pkg-config
installed ?

Mike
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] autotools build q

2008-02-21 Thread Dozier, Bill
I have the current releases of pkg-config, automake, autoconf and libtool 
installed.

$ for p in `echo pkg-config libtool automake autoconf`; do echo $p;$p 
--version; done
pkg-config
0.23
libtool
ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.492 2008/01/30 06:40:56)

Copyright (C) 2008  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
automake
automake (GNU automake) 1.10.1
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey [EMAIL PROTECTED]
   and Alexandre Duret-Lutz [EMAIL PROTECTED].
autoconf
autoconf (GNU Autoconf) 2.61
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software.  You may redistribute copies of it under the terms of
the GNU General Public License http://www.gnu.org/licenses/gpl.html.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.
$

 -Original Message-
 From: Mike Hommey [mailto:[EMAIL PROTECTED]
 Sent: Thursday, February 21, 2008 2:12 PM
 To: Dozier, Bill
 Cc: webkit-dev@lists.webkit.org
 Subject: Re: [webkit-dev] autotools build q

 On Thu, Feb 21, 2008 at 01:58:31PM -0800, Dozier, Bill wrote:
  There are brackets in configure.ac, but not in the configure that
 autogen builds.

 Oh I see, the PKG_CHECK_MODULES wasn't expanded. Do you have pkg-config
 installed ?

 Mike
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Displaying a message box

2008-02-21 Thread Ben Murdoch
Hi,

In the chrome client there is a function runJavaScriptAlert() that calls the
UI delegate to show an alert panel with JavaScript branding - I was
wondering if there was another function I could call to display a message
box without the JavaScript stuff? I couldn't see anything in the chrome or
delegate ...

Cheers, Ben
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Additional Windows Patches

2008-02-21 Thread Brent Fulgham
I've just opened two new Bugs:

http://bugs.webkit.org/show_bug.cgi?id=17484; -- Changes to WebKit to
permit building with Cairo.
http://bugs.webkit.org/show_bug.cgi?id=17483; -- Native Windows scrollbars
for WebKit.

I believe that with these two patches you should be able to build the same
WebKit instance I am running.

Please let me know if you have any problems.

Thanks,

-Brent
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Additional Windows Patches

2008-02-21 Thread Eric Seidel
I think conditionalizing the Apple windows code is the wrong way to
go.  We should instead move the CG parts out of those files (and out
of win/) and implement cairo and curl versions in a separate files (or
in TemporaryLinkStubs.cpp)

Oliver (and others in the WebKit project) are currently working to
remove #ifdefs from the source, not add them.  These patches are a
step backwards in that regard.

-eric

On Thu, Feb 21, 2008 at 5:46 PM, Brent Fulgham [EMAIL PROTECTED] wrote:
 I've just opened two new Bugs:

 http://bugs.webkit.org/show_bug.cgi?id=17484; -- Changes to WebKit to
 permit building with Cairo.
 http://bugs.webkit.org/show_bug.cgi?id=17483; -- Native Windows scrollbars
 for WebKit.

 I believe that with these two patches you should be able to build the same
 WebKit instance I am running.

 Please let me know if you have any problems.

 Thanks,

 -Brent


 ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Additional Windows Patches

2008-02-21 Thread Brent Fulgham
Hi Eric,

On Feb 21, 2008, at 5:58 PM, Eric Seidel wrote:
 I think conditionalizing the Apple windows code is the wrong way to
 go.  We should instead move the CG parts out of those files (and out
 of win/) and implement cairo and curl versions in a separate files (or
 in TemporaryLinkStubs.cpp)

That's exactly the approach taken in the scrollbar patch.  I mainly  
wanted the WebKit patch posted so some of the people on the list could  
access the changes and try out the Cairo build.

I'll update the patch moving the very small number of routines with  
CoreGraphics/Ciaro things into WebCore.

-Brent
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Rounded border rendering

2008-02-21 Thread Darin Adler
On Feb 21, 2008, at 1:41 AM, Fabian Jakobs wrote:

 BTW the documentation for border-radius at 
 http://developer.apple.com/documentation/AppleApplications/Reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/doc/uid/TP30001266-BoxModel
  
  is incomplete. It does not mention that two radii for each corner  
 can be specified.


Thanks for pointing that out.

Bug reports for that documentation should go to http://bugreport.apple.com 
 . The team responsible for the documentation will get them directly  
and I'm not sure they read this mailing list.

If you'd prefer not to file the bug yourself and would like me to do  
it for you, please let me know.

 -- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Additional Windows Patches

2008-02-21 Thread Joonwon Yi
Hi, Brent.

When I'm applying your patch 17483, my Tortoise Merge showed the following 
error.
An unknown line type was found in line 726 !

Line 471~475: There are some sentences without leading // in the middle of 
sources, which seem to be wrong.

Could you upload another patch?

- joonwon -


  - Original Message - 
  From: Brent Fulgham 
  To: Webkit Development List 
  Sent: Friday, February 22, 2008 10:46 AM
  Subject: [webkit-dev] Additional Windows Patches


  I've just opened two new Bugs:

  http://bugs.webkit.org/show_bug.cgi?id=17484; -- Changes to WebKit to permit 
building with Cairo.
  http://bugs.webkit.org/show_bug.cgi?id=17483; -- Native Windows scrollbars 
for WebKit.

  I believe that with these two patches you should be able to build the same 
WebKit instance I am running.

  Please let me know if you have any problems.

  Thanks,

  -Brent




--


  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] KJS Test Program

2008-02-21 Thread Brent Fulgham
Is it possible to pass command line arguments to a Javascript program  
on the command line?

E.g.,:

[EMAIL PROTECTED]:/opt/shootout/shootout/bench/nsieve$ /opt/local/bin/ 
testkjs nsieve.kjs 3
[9074] nsieve.kjs line 32: ReferenceError: Can't find variable:  
arguments
Could not open file: 3
[EMAIL PROTECTED]:/opt/shootout/shootout/bench/nsieve$ /opt/local/bin/ 
testkjs nsieve.kjs -- 3
[9076] nsieve.kjs line 32: ReferenceError: Can't find variable:  
arguments
Could not open file: --
[EMAIL PROTECTED]:/opt/shootout/shootout/bench/nsieve$

Looking over the 'testkjs.cpp' sources, it doesn't appear that you can  
pass arguments to the javascript program.

Is there some way to do so?  Or should I modify the testkjs.cpp  
sources to add the ability to do this?

Thanks,

-Brent


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev