Re: [webkit-dev] problems in cross compiling webkit - Execution of JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

2008-10-30 Thread Bn, Sharath
I modified the line
- my $fh = new File::Temp(
+ my $fh = File::Temp-tempfile(

And I get some error like this

JavaScriptCore/pcre/dftables JavaScriptCore/pcre/chartables.c
Error in tempfile() using /tmp/File::Temp.in: The template must contain at least
 4 'X' characters
 at JavaScriptCore/pcre/dftables line 245
make: *** [JavaScriptCore/pcre/chartables.c] Error 255

I modified the line
- my $fh = new File::Temp( to
+ my $fh = File::Temp-new(

And I get some error like this

JavaScriptCore/pcre/dftables JavaScriptCore/pcre/chartables.c
Can't locate object method new via package File::Temp at JavaScriptCore/pcre
/dftables line 245.
make: *** [JavaScriptCore/pcre/chartables.c] Error 255

Pls let me know how to solve this build error



Sharath

-Original Message-
From: David Kilzer [mailto:[EMAIL PROTECTED]
Sent: Friday, October 24, 2008 12:00 AM
To: Bn, Sharath
Cc: webkit-dev@lists.webkit.org
Subject: RE: [webkit-dev] problems in cross compiling webkit - Execution of 
JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

Filed this bug to cover the create_hash_table fix for Perl 5.10:

https://bugs.webkit.org/show_bug.cgi?id=21831

It would seem the Object Interface for File::Temp has changed in Perl 5.10:

$fh = File::Temp-new(TEMPLATE = $template);

Originally you could do this:

$fh = new File::Temp($template);

It looks like the only way to fix this is to use the File::Temp-tempfile() 
method instead.  What a pain.

These scripts appear to have the same issue (because I wrote them?!):

WebKitTools/Scripts/bisect-builds
WebKitTools/Scripts/sort-Xcode-project-file

I filed:

https://bugs.webkit.org/show_bug.cgi?id=21832

I should have a patch up shortly to fix all three scripts.

Dave


On Thu, 10/23/08, Bn, Sharath [EMAIL PROTECTED] wrote:

 The FIX worked. Thanks a lot.
 Perl version was v5.8.0. I have upgraded the perl to
 v5.10.0.
 The fix is required for v5.10.0 version as well. Without
 your fix even 5.10.0 cribs.
 However now I get some other error as mentioned below.

 JavaScriptCore/pcre/dftables
 JavaScriptCore/pcre/chartables.c
 Can't locate object method new via package
 File::Temp at JavaScriptCore/pcre
 /dftables line 245.
 make: *** [JavaScriptCore/pcre/chartables.c] Error 255

 Regards
 Sharath.B.N

 -Original Message-
 From: David Kilzer [mailto:[EMAIL PROTECTED]
 Sent: Wednesday, October 22, 2008 7:44 PM
 To: Bn, Sharath
 Cc: webkit-dev@lists.webkit.org
 Subject: Re: [webkit-dev] problems in cross compiling
 webkit - Execution of JavaScriptCore/kjs/create_hash_table
 aborted due to compilation errors.

 On Wed, 10/22/08, Bn, Sharath
 [EMAIL PROTECTED] wrote:

  /usr/bin/perl JavaScriptCore/kjs/create_hash_table
  JavaScriptCore/kjs/keywords.table 
  DerivedSources/lexer.lut.h
  Global symbol @nameEntries requires
 explicit
  package name at JavaScriptCore/kjs/create_hash_table
 line
  218.
  Execution of JavaScriptCore/kjs/create_hash_table
 aborted
  due to compilation errors.
  make: *** [DerivedSources/lexer.lut.h] Error 255

 Ha!  What version of Perl are you using (run perl
 -v)?  It looks like Perl is interpreting a print()
 statement differently.  Try making this change (adding
 backslashes before the square brackets in
 create_hash_table):

 -print \nstatic const struct HashTableValue
 ${nameEntries}[$count] = {\n;
 +print \nstatic const struct HashTableValue
 ${nameEntries}\[$count\] = {\n;

 Let me know if that fixes the problem.

 Dave



 The information contained in this message may be
 confidential and legally protected under applicable law. The
 message is intended solely for the addressee(s). If you are
 not the intended recipient, you are hereby notified that any
 use, forwarding, dissemination, or reproduction of this
 message is strictly prohibited and may be unlawful. If you
 are not the intended recipient, please contact the sender by
 return e-mail and destroy all copies of the original
 message.

The information contained in this message may be confidential and legally 
protected under applicable law. The message is intended solely for the 
addressee(s). If you are not the intended recipient, you are hereby notified 
that any use, forwarding, dissemination, or reproduction of this message is 
strictly prohibited and may be unlawful. If you are not the intended recipient, 
please contact the sender by return e-mail and destroy all copies of the 
original message.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] problems in cross compiling webkit - Execution of JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

2008-10-30 Thread David Kilzer
You need to change more than that.  Did you look at the patch in Bug 21832?

https://bugs.webkit.org/attachment.cgi?id=24615

You could also update to svn r37819 or newer to pick up the fix.

Dave


On Thu, 10/30/08, Bn, Sharath [EMAIL PROTECTED] wrote:

 I modified the line
 - my $fh = new File::Temp(
 + my $fh = File::Temp-tempfile(
 
 And I get some error like this
 
 JavaScriptCore/pcre/dftables
 JavaScriptCore/pcre/chartables.c
 Error in tempfile() using /tmp/File::Temp.in: The template
 must contain at least
  4 'X' characters
  at JavaScriptCore/pcre/dftables line 245
 make: *** [JavaScriptCore/pcre/chartables.c] Error 255
 
 I modified the line
 - my $fh = new File::Temp( to
 + my $fh = File::Temp-new(
 
 And I get some error like this
 
 JavaScriptCore/pcre/dftables
 JavaScriptCore/pcre/chartables.c
 Can't locate object method new via package
 File::Temp at JavaScriptCore/pcre
 /dftables line 245.
 make: *** [JavaScriptCore/pcre/chartables.c] Error 255
 
 Pls let me know how to solve this build error
 
 
 
 Sharath
 
 -Original Message-
 From: David Kilzer [mailto:[EMAIL PROTECTED]
 Sent: Friday, October 24, 2008 12:00 AM
 To: Bn, Sharath
 Cc: webkit-dev@lists.webkit.org
 Subject: RE: [webkit-dev] problems in cross compiling
 webkit - Execution of JavaScriptCore/kjs/create_hash_table
 aborted due to compilation errors.
 
 Filed this bug to cover the create_hash_table fix for Perl
 5.10:
 
 https://bugs.webkit.org/show_bug.cgi?id=21831
 
 It would seem the Object Interface for
 File::Temp has changed in Perl 5.10:
 
 $fh = File::Temp-new(TEMPLATE = $template);
 
 Originally you could do this:
 
 $fh = new File::Temp($template);
 
 It looks like the only way to fix this is to use the
 File::Temp-tempfile() method instead.  What a pain.
 
 These scripts appear to have the same issue (because I
 wrote them?!):
 
 WebKitTools/Scripts/bisect-builds
 WebKitTools/Scripts/sort-Xcode-project-file
 
 I filed:
 
 https://bugs.webkit.org/show_bug.cgi?id=21832
 
 I should have a patch up shortly to fix all three scripts.
 
 Dave
 
 
 On Thu, 10/23/08, Bn, Sharath
 [EMAIL PROTECTED] wrote:
 
  The FIX worked. Thanks a lot.
  Perl version was v5.8.0. I have upgraded the perl to
  v5.10.0.
  The fix is required for v5.10.0 version as well.
 Without
  your fix even 5.10.0 cribs.
  However now I get some other error as mentioned below.
 
  JavaScriptCore/pcre/dftables
  JavaScriptCore/pcre/chartables.c
  Can't locate object method new via
 package
  File::Temp at JavaScriptCore/pcre
  /dftables line 245.
  make: *** [JavaScriptCore/pcre/chartables.c] Error 255
 
  Regards
  Sharath.B.N
 
  -Original Message-
  From: David Kilzer [mailto:[EMAIL PROTECTED]
  Sent: Wednesday, October 22, 2008 7:44 PM
  To: Bn, Sharath
  Cc: webkit-dev@lists.webkit.org
  Subject: Re: [webkit-dev] problems in cross compiling
  webkit - Execution of
 JavaScriptCore/kjs/create_hash_table
  aborted due to compilation errors.
 
  On Wed, 10/22/08, Bn, Sharath
  [EMAIL PROTECTED] wrote:
 
   /usr/bin/perl
 JavaScriptCore/kjs/create_hash_table
   JavaScriptCore/kjs/keywords.table 
   DerivedSources/lexer.lut.h
   Global symbol @nameEntries requires
  explicit
   package name at
 JavaScriptCore/kjs/create_hash_table
  line
   218.
   Execution of JavaScriptCore/kjs/create_hash_table
  aborted
   due to compilation errors.
   make: *** [DerivedSources/lexer.lut.h] Error 255
 
  Ha!  What version of Perl are you using (run
 perl
  -v)?  It looks like Perl is interpreting a
 print()
  statement differently.  Try making this change (adding
  backslashes before the square brackets in
  create_hash_table):
 
  -print \nstatic const struct
 HashTableValue
  ${nameEntries}[$count] = {\n;
  +print \nstatic const struct
 HashTableValue
  ${nameEntries}\[$count\] = {\n;
 
  Let me know if that fixes the problem.
 
  Dave
 
 
 
  The information contained in this message may be
  confidential and legally protected under applicable
 law. The
  message is intended solely for the addressee(s). If
 you are
  not the intended recipient, you are hereby notified
 that any
  use, forwarding, dissemination, or reproduction of
 this
  message is strictly prohibited and may be unlawful. If
 you
  are not the intended recipient, please contact the
 sender by
  return e-mail and destroy all copies of the original
  message.
 
 The information contained in this message may be
 confidential and legally protected under applicable law. The
 message is intended solely for the addressee(s). If you are
 not the intended recipient, you are hereby notified that any
 use, forwarding, dissemination, or reproduction of this
 message is strictly prohibited and may be unlawful. If you
 are not the intended recipient, please contact the sender by
 return e-mail and destroy all copies of the original
 message.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org

[webkit-dev] NPP_GetValue with 'NPPVpluginScriptableNPObject' is not invoked automatically in XHTML content for a NS Plugin embedded object.

2008-10-30 Thread Deshpande, Raghavendra
I have embedded an NS plugin object using object /object .

When the page is served as XHTML, the NS plugin  scriptable object is NOT 
instantiated, even when the plugin implements NPP_Get() for 
NPPVpluginScriptableNPObject . Whereas, if the same page is served as HTML 
content, then, the scriptable object gets instantiated.

I also noticed that, in xhtml content , the scriptable NS plugin object gets 
instantiated only upon first call to 'getElementById'. Thus making 
'getElementById' mandatory for Javascript binding to the embedded object.

XHTML specification doesn't specify any rules related to 'auto instantiation' 
of NS Pligin object. But, the behavior should not vary from HTML to XHTML.

So, Is it a bug?

-Raghu







The information contained in this message may be confidential and legally 
protected under applicable law. The message is intended solely for the 
addressee(s). If you are not the intended recipient, you are hereby notified 
that any use, forwarding, dissemination, or reproduction of this message is 
strictly prohibited and may be unlawful. If you are not the intended recipient, 
please contact the sender by return e-mail and destroy all copies of the 
original message.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] problems in cross compiling webkit - Execution of JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

2008-10-30 Thread Bn, Sharath
The patch works, thanks

Sharath

-Original Message-
From: David Kilzer [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 30, 2008 3:34 PM
To: Bn, Sharath
Cc: webkit-dev@lists.webkit.org
Subject: RE: [webkit-dev] problems in cross compiling webkit - Execution of 
JavaScriptCore/kjs/create_hash_table aborted due to compilation errors.

You need to change more than that.  Did you look at the patch in Bug 21832?

https://bugs.webkit.org/attachment.cgi?id=24615

You could also update to svn r37819 or newer to pick up the fix.

Dave


On Thu, 10/30/08, Bn, Sharath [EMAIL PROTECTED] wrote:

 I modified the line
 - my $fh = new File::Temp(
 + my $fh = File::Temp-tempfile(

 And I get some error like this

 JavaScriptCore/pcre/dftables
 JavaScriptCore/pcre/chartables.c
 Error in tempfile() using /tmp/File::Temp.in: The template
 must contain at least
  4 'X' characters
  at JavaScriptCore/pcre/dftables line 245
 make: *** [JavaScriptCore/pcre/chartables.c] Error 255

 I modified the line
 - my $fh = new File::Temp( to
 + my $fh = File::Temp-new(

 And I get some error like this

 JavaScriptCore/pcre/dftables
 JavaScriptCore/pcre/chartables.c
 Can't locate object method new via package
 File::Temp at JavaScriptCore/pcre
 /dftables line 245.
 make: *** [JavaScriptCore/pcre/chartables.c] Error 255

 Pls let me know how to solve this build error



 Sharath

 -Original Message-
 From: David Kilzer [mailto:[EMAIL PROTECTED]
 Sent: Friday, October 24, 2008 12:00 AM
 To: Bn, Sharath
 Cc: webkit-dev@lists.webkit.org
 Subject: RE: [webkit-dev] problems in cross compiling
 webkit - Execution of JavaScriptCore/kjs/create_hash_table
 aborted due to compilation errors.

 Filed this bug to cover the create_hash_table fix for Perl
 5.10:

 https://bugs.webkit.org/show_bug.cgi?id=21831

 It would seem the Object Interface for
 File::Temp has changed in Perl 5.10:

 $fh = File::Temp-new(TEMPLATE = $template);

 Originally you could do this:

 $fh = new File::Temp($template);

 It looks like the only way to fix this is to use the
 File::Temp-tempfile() method instead.  What a pain.

 These scripts appear to have the same issue (because I
 wrote them?!):

 WebKitTools/Scripts/bisect-builds
 WebKitTools/Scripts/sort-Xcode-project-file

 I filed:

 https://bugs.webkit.org/show_bug.cgi?id=21832

 I should have a patch up shortly to fix all three scripts.

 Dave


 On Thu, 10/23/08, Bn, Sharath
 [EMAIL PROTECTED] wrote:

  The FIX worked. Thanks a lot.
  Perl version was v5.8.0. I have upgraded the perl to
  v5.10.0.
  The fix is required for v5.10.0 version as well.
 Without
  your fix even 5.10.0 cribs.
  However now I get some other error as mentioned below.
 
  JavaScriptCore/pcre/dftables
  JavaScriptCore/pcre/chartables.c
  Can't locate object method new via
 package
  File::Temp at JavaScriptCore/pcre
  /dftables line 245.
  make: *** [JavaScriptCore/pcre/chartables.c] Error 255
 
  Regards
  Sharath.B.N
 
  -Original Message-
  From: David Kilzer [mailto:[EMAIL PROTECTED]
  Sent: Wednesday, October 22, 2008 7:44 PM
  To: Bn, Sharath
  Cc: webkit-dev@lists.webkit.org
  Subject: Re: [webkit-dev] problems in cross compiling
  webkit - Execution of
 JavaScriptCore/kjs/create_hash_table
  aborted due to compilation errors.
 
  On Wed, 10/22/08, Bn, Sharath
  [EMAIL PROTECTED] wrote:
 
   /usr/bin/perl
 JavaScriptCore/kjs/create_hash_table
   JavaScriptCore/kjs/keywords.table 
   DerivedSources/lexer.lut.h
   Global symbol @nameEntries requires
  explicit
   package name at
 JavaScriptCore/kjs/create_hash_table
  line
   218.
   Execution of JavaScriptCore/kjs/create_hash_table
  aborted
   due to compilation errors.
   make: *** [DerivedSources/lexer.lut.h] Error 255
 
  Ha!  What version of Perl are you using (run
 perl
  -v)?  It looks like Perl is interpreting a
 print()
  statement differently.  Try making this change (adding
  backslashes before the square brackets in
  create_hash_table):
 
  -print \nstatic const struct
 HashTableValue
  ${nameEntries}[$count] = {\n;
  +print \nstatic const struct
 HashTableValue
  ${nameEntries}\[$count\] = {\n;
 
  Let me know if that fixes the problem.
 
  Dave
 
 
 
  The information contained in this message may be
  confidential and legally protected under applicable
 law. The
  message is intended solely for the addressee(s). If
 you are
  not the intended recipient, you are hereby notified
 that any
  use, forwarding, dissemination, or reproduction of
 this
  message is strictly prohibited and may be unlawful. If
 you
  are not the intended recipient, please contact the
 sender by
  return e-mail and destroy all copies of the original
  message.

 The information contained in this message may be
 confidential and legally protected under applicable law. The
 message is intended solely for the addressee(s). If you are
 not the intended recipient, you are hereby notified that any
 use, forwarding, dissemination, or reproduction of this
 message is 

[webkit-dev] Save Page - Ideas

2008-10-30 Thread zaheer ahmad
hi,

iam working on implementing save page functionality. Looks like its not
already supported in the core. Following are some high level ideas and iam
not sure if some or all of these are the right approaches to this problem

- write the page data to the file system as and when is received - but this
is not optimal since this incurs constant overhead on page load
- apis to retreive the source (html, js, css) and image/object data
(original form) from the document. I think the parsers/loaders incrementally
handle the data and throw off the parsed text - pls validate my
understanding here.
- parse and convert all the html absolute/relative URIs to relative URIs on
the file system
- any other optimized storage methods - e.g. storing the entire page as a
single file using multipart content

please advise.

thanks,
Zaheer
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Save Page - Ideas

2008-10-30 Thread David Kilzer
On Thu, 10/30/08, zaheer ahmad [EMAIL PROTECTED] wrote:

 iam working on implementing save page functionality. Looks
 like its not
 already supported in the core.

Apple's Mac port saves .webarchive files.  The format is specific to the 
CoreFoundation framework, but there is platform-specific code that does this 
nevertheless.

 Following are some high
 level ideas and iam
 not sure if some or all of these are the right approaches
 to this problem
 
 - write the page data to the file system as and when is
 received - but this
 is not optimal since this incurs constant overhead on page
 load

Don't do this.

 - apis to retreive the source (html, js, css) and
 image/object data
 (original form) from the document. I think the
 parsers/loaders incrementally
 handle the data and throw off the parsed text - pls
 validate my
 understanding here.

There should be API to do this already.  Look at how content for .webarchive 
files is retrieved.

 - parse and convert all the html absolute/relative URIs to
 relative URIs on
 the file system

Bug 7211: Support save as Web page, complete in Firefox format
https://bugs.webkit.org/show_bug.cgi?id=7211

 - any other optimized storage methods - e.g. storing the
 entire page as a
 single file using multipart content

Bug 7169: Support exporting of MHTML web archives
https://bugs.webkit.org/show_bug.cgi?id=7169

I would strongly encourage you to reuse an existing format rather than 
inventing your own.  (In my opinion the Firefox format is preferred because 
it's readable by all web browsers.)

Dave


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Save Page - Ideas

2008-10-30 Thread Darin Fisher
On Thu, Oct 30, 2008 at 9:33 AM, David Kilzer [EMAIL PROTECTED] wrote:

 On Thu, 10/30/08, zaheer ahmad [EMAIL PROTECTED] wrote:

  iam working on implementing save page functionality. Looks
  like its not
  already supported in the core.

 Apple's Mac port saves .webarchive files.  The format is specific to the
 CoreFoundation framework, but there is platform-specific code that does this
 nevertheless.

  Following are some high
  level ideas and iam
  not sure if some or all of these are the right approaches
  to this problem
 
  - write the page data to the file system as and when is
  received - but this
  is not optimal since this incurs constant overhead on page
  load

 Don't do this.

  - apis to retreive the source (html, js, css) and
  image/object data
  (original form) from the document. I think the
  parsers/loaders incrementally
  handle the data and throw off the parsed text - pls
  validate my
  understanding here.

 There should be API to do this already.  Look at how content for
 .webarchive files is retrieved.

  - parse and convert all the html absolute/relative URIs to
  relative URIs on
  the file system

 Bug 7211: Support save as Web page, complete in Firefox format
 https://bugs.webkit.org/show_bug.cgi?id=7211


We have code to support this feature in the Chromium code base.  You can
find it here:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.h?view=markup
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_serializer.cc?view=markup

It is something we would love to one day see as part of WebKit.

-Darin


https://bugs.webkit.org/show_bug.cgi?id=7211

  - any other optimized storage methods - e.g. storing the
  entire page as a
  single file using multipart content

 Bug 7169: Support exporting of MHTML web archives
 https://bugs.webkit.org/show_bug.cgi?id=7169

 I would strongly encourage you to reuse an existing format rather than
 inventing your own.  (In my opinion the Firefox format is preferred because
 it's readable by all web browsers.)

 Dave


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] NPP_GetValue with 'NPPVpluginScriptableNPObject' is not invoked automatically in XHTML content for a NS Plugin embedded object.

2008-10-30 Thread Anders Carlsson


On Oct 30, 2008, at 3:35 AM, Deshpande, Raghavendra wrote:


I have embedded an NS plugin object using object /object .

When the page is served as XHTML, the NS plugin  scriptable object  
is NOT instantiated, even when the plugin implements NPP_Get()  
forNPPVpluginScriptableNPObject . Whereas, if the same page is  
served as HTML content, then, the scriptable object gets instantiated.


I also noticed that, in xhtml content , the scriptable NS plugin  
object gets instantiated only upon first call to ‘getElementById’.  
Thus making ‘getElementById’ mandatory for Javascript binding to the  
embedded object.


XHTML specification doesn’t specify any rules related to ‘auto  
instantiation’ of NS Pligin object. But, the behavior should not  
vary from HTML to XHTML.


So, Is it a bug?



Yes, this sounds like a bug. Please file it at http://bugs.webkit.org

Thanks,
Anders

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev