Re: [webkit-dev] Setting Unlimited Capacity to BackForwardList

2009-01-19 Thread Brady Eidson

Hi,

There is no way to change the *default* capacity for all back forward  
lists.


BackForwardList in WebCore has a method void setCapacity(int); which  
accomplishes this, but of course your platform's WebKit API layer  
should also provide a call through to that.  On Mac, for example,  
WebBackForwardList provides -(void)setCapacity:(int)size


Setting the capacity for a given list to INT_MAX would effectively  
make it unlimited, but I'm sure you'd run out of memory long before it  
approached that limit  ;)


~Brady

On Jan 18, 2009, at 11:31 PM, mwas wrote:


Hi,

I would like to know, is there a way to set Unlimited Capacity to  
History BackForwardList. The current WebKit Code contains 100 as the  
default capacity as shown below


static const unsigned DefaultCapacity = 100;
BackForwardList::BackForwardList(Page* page)
  : m_page(page)
  , m_current(NoCurrentItemIndex)
  , m_capacity(DefaultCapacity)
  , m_closed(true)
  , m_enabled(true)
{
}


Any Ideas would be much appreciated!

Thanks

mwas





___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Using LGPL-derived source in one of the wtf files.

2009-01-19 Thread Dmitry Titov
Hi,
There was an IRC discussion about
https://bugs.webkit.org/show_bug.cgi?id=23373, and there was no clear
solution..

In the proposed patch the ThreadingWin.cpp would contain 2 licenses -
standard WebKit one and a copy of Pthread-win32 license (LGPL). The latter
is there because the code for ThreadCondition is derived from the sources of
that library (removing the need to pull in the whole library for 50 lines of
code).

Does this idea look acceptable? Can we use LGPL'ed source this way and how
should we go about the license if we can?

Thanks,
Dmitry
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Using LGPL-derived source in one of the wtf files.

2009-01-19 Thread Darin Adler

On Jan 19, 2009, at 12:12 PM, Dmitry Titov wrote:

In the proposed patch the ThreadingWin.cpp would contain 2 licenses  
- standard WebKit one and a copy of Pthread-win32 license (LGPL).  
The latter is there because the code for ThreadCondition is derived  
from the sources of that library (removing the need to pull in the  
whole library for 50 lines of code).


Does this idea look acceptable? Can we use LGPL'ed source this way  
and how should we go about the license if we can?


The WebKit contribution terms are on the attachment creation page in  
bugs.webkit.org:


	1) If you are sending in a patch to existing WebKit code, you agree  
by clicking below that your changes are licensed under the existing  
license terms of the file you are modifying (i.e., BSD license or GNU  
Lesser General Public License v.2.1, LGPL v. 2.1). Please also add  
your copyright (name and year) to the relevant files for changes that  
are more than 10 lines of code.
	2) If you are sending in a new file for inclusion in WebKit (no code  
copied from another source), the preferred license is BSD, but LGPL  
2.1 is an option as well. Please include your copyright (name and  
year) and license preference (BSD or LGPL 2.1). By clicking below you  
agree that your file is licensed under either the BSD license or LGPL  
2.1, as indicated in your file.
	3) If you aren't the author of the patch, you agree to include the  
original copyright notices and licensing terms with it, to the extent  
that they exist. If there wasn't a copyright notice or license, please  
make a note of it. Generally we can only take in patches that are BSD-  
or LGPL-licensed in order to maintain license compatibility within the  
project.


Is there something in this case that isn’t covered by those terms?

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev