[webkit-dev] A question regarding to JavaScriptCore's C/C++ API.

2009-03-04 Thread Zhe Su 
Hi,
   I'm developing an application which uses webkit's JavaScriptCore and a
customized global object (by providing a special class when creating the
context). My customized global object provides some built-in properties that
can be accessed by javascript code. Now, I want to support a special
behavior: allows javascript code to override a built-in property of global
object by using variable declaraction statement. For example, assuming the
global object has a built-in property, named "foo", a "var foo;" statement
shall create a javascript variable, named "foo" and the original built-in
"foo" shall be overrid by this new javascript variable. But if there is no
"var foo;" statement, the built-in foo shall be able to get and set from
javascript code.

Now the problem is, current JavaScriptCore's C API (especially those
HasProperty, GetProperty, SetProperty callbacks of a class definition) can't
distinguish variable delcaration statement and variable assigment statement.
I checked SpiderMonkey's API and found it can distinguish such things by
providing a flag when calling ResolveProperty callback.

Do you have any idea on this issue? How can I implement such behavior based
on current API?

Regards
James Su
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Plug in support on DirectFB Webkit

2009-03-04 Thread Sriram Neelakandan 
Attached is a small patch to get the DFB compilation going (against r40351)
and apart from this patch,
we need to add support code for DFB for the plugin's view
So see all the checks with  "#if PLATFORM(X11)" in
WebCore/plugins/gtk/PluginViewGtk.cpp
and do the necessary stuff for DFB.
NOTE: The Xembed and XtBin will not work for DFB

Also i still need to figure out how to send DFBEvents to the plugin ?


On Thu, Mar 5, 2009 at 10:39 AM, Sriram Neelakandan
 wrote:
>> I have built Webkit in order to get rid of X11  calls.
>
> This is fine
>
>> Tried to replace the X11 API  with GDK calls.
>
> If  you need true DFB support  this will not work. (X11 != GDK, but X11 == 
> DFB)
> As per 
> "https://developer.mozilla.org/en/Gecko_Plugin_API_Reference/Drawing_and_Event_Handling";
> the "void * window"  should be directly mapped to DFB surface or sub-surface.
> Then it would work great for even Window-ed and window-less plugins.
>
> More over all browser plugins today are written for X11 / Win32 / Mac
> and not for GTK / QT / WxWindows / Skia
>
> So going the DFB way is the right step forward.. and you can hope to
> get your code inside Webkit some day.
>
>> But it fails when there is conversion from GtkXtBin to GtkSocket
>
> No GTK if you want true DFB support. The XtBin is basically a X11 bridge
>
>>
>> And one more thing I found  gdk_window_add_filter()'s call back
>> function is not getting called in my plug in library.
>>
>> I doubt its because, the plug in window creation may be a problem.
>>
>>
>>
>> On Mon, Mar 2, 2009 at 11:00 PM, Sriram Neelakandan
>>  wrote:
>>> Well, what u need is a build time flag, which should first get rid of
>>> all X11 headers.
>>> Then you end up having to define or mapping the missing structure /
>>> defines in npruntime,h & npapi.h to appropriate DFB equivalents
>>>
>>> Now, after that, you will get stuck with gtk_socket_new .. a well
>>> known issue with DFB windowing which is currently not implemented in
>>> the gtk/dfb backend.
>>>
>>> I remember some how the mozilla guys managed to get DFB SWFDEC player
>>> plugin working.. wonder how ?
>>> I think mostly they rendered the plugin on a different Window !
>>>
>>> I heard that gtk_socket_new may get fixed in DFB-2.0.. untill then DFB
>>> plugins will have to wait !
>>> Not sure if there is a better way to render DFB plugins on to
>>> Webframe/view 's surface directly !
>>>
>>>
>>>
>>> On Mon, Mar 2, 2009 at 8:53 PM, Rick  wrote:
 Having just looked up DirectFB on Wikipedia, I see it is an interface
 that skips X and talks directly to the framebuffer.

 There is mention of an API called XDirectFB that mimics X11 calls.
 You might look for that.

 On Mon, Mar 2, 2009 at 8:38 AM, Ariya Hidayat
  wrote:
>
>> I am running Webkit on DirectFB.
>> AFAIK, plug in support is not there on DirectFB/Webkit.
>> I found in WebCore/plugin calls are all Xt/X11 based.
>> Can any one suggest me , how can I modify these call for DirectFB ?
>
> DirectFB is a complete different beast, compared to X11. AFAICS you have 
> to
> implement the whole plugin infrastructure for that.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>



 --
 Cheers!
 Rick
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

>>>
>>>
>>>
>>> --
>>> Sriram Neelakandan
>>> Author - Embedded Linux System Design And Development
>>> (http://tinyurl.com/2doosu)
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
>
> --
> Sriram Neelakandan
> Author - Embedded Linux System Design And Development
> (http://tinyurl.com/2doosu)
>



-- 
Sriram Neelakandan
Author - Embedded Linux System Design And Development
(http://tinyurl.com/2doosu)
diff -puNr WebKit-r40351/GNUmakefile.am WebKit-r40351_m/GNUmakefile.am
--- WebKit-r40351/GNUmakefile.am	2009-01-21 10:43:27.0 +0530
+++ WebKit-r40351_m/GNUmakefile.am	2009-02-03 19:57:10.0 +0530
@@ -264,8 +264,15 @@ endif
 
 if TARGET_X11
 global_cppflags += -DXP_UNIX
+webcore_libadd += -lXt
+global_cppflags += -DGDK_BACKEND_X11
 endif
 
+if TARGET_DIRECTFB
+global_cppflags += -DXP_UNIX
+global_cppflags += -DGDK_BACKEND_DIRECTFB
+endif
+ 
 if !ENABLE_DEBUG
 global_cppflags += -DNDEBUG
 else
diff -puNr WebKit-r40351/WebCore/bridge/npapi.h WebKit-r40351_m/WebCore/bridge/npapi.h
--- WebKit-r40351/WebCore/bridge/npapi.h	2009-01-21 10:44:14.0 +0530
+++ WebKit-r40351_m/WebCore/bridge/npapi.h	20

Re: [webkit-dev] Plug in support on DirectFB Webkit

2009-03-04 Thread Sriram Neelakandan 
> I have built Webkit in order to get rid of X11  calls.

This is fine

> Tried to replace the X11 API  with GDK calls.

If  you need true DFB support  this will not work. (X11 != GDK, but X11 == DFB)
As per 
"https://developer.mozilla.org/en/Gecko_Plugin_API_Reference/Drawing_and_Event_Handling";
the "void * window"  should be directly mapped to DFB surface or sub-surface.
Then it would work great for even Window-ed and window-less plugins.

More over all browser plugins today are written for X11 / Win32 / Mac
and not for GTK / QT / WxWindows / Skia

So going the DFB way is the right step forward.. and you can hope to
get your code inside Webkit some day.

> But it fails when there is conversion from GtkXtBin to GtkSocket

No GTK if you want true DFB support. The XtBin is basically a X11 bridge

>
> And one more thing I found  gdk_window_add_filter()'s call back
> function is not getting called in my plug in library.
>
> I doubt its because, the plug in window creation may be a problem.
>
>
>
> On Mon, Mar 2, 2009 at 11:00 PM, Sriram Neelakandan
>  wrote:
>> Well, what u need is a build time flag, which should first get rid of
>> all X11 headers.
>> Then you end up having to define or mapping the missing structure /
>> defines in npruntime,h & npapi.h to appropriate DFB equivalents
>>
>> Now, after that, you will get stuck with gtk_socket_new .. a well
>> known issue with DFB windowing which is currently not implemented in
>> the gtk/dfb backend.
>>
>> I remember some how the mozilla guys managed to get DFB SWFDEC player
>> plugin working.. wonder how ?
>> I think mostly they rendered the plugin on a different Window !
>>
>> I heard that gtk_socket_new may get fixed in DFB-2.0.. untill then DFB
>> plugins will have to wait !
>> Not sure if there is a better way to render DFB plugins on to
>> Webframe/view 's surface directly !
>>
>>
>>
>> On Mon, Mar 2, 2009 at 8:53 PM, Rick  wrote:
>>> Having just looked up DirectFB on Wikipedia, I see it is an interface
>>> that skips X and talks directly to the framebuffer.
>>>
>>> There is mention of an API called XDirectFB that mimics X11 calls.
>>> You might look for that.
>>>
>>> On Mon, Mar 2, 2009 at 8:38 AM, Ariya Hidayat
>>>  wrote:

> I am running Webkit on DirectFB.
> AFAIK, plug in support is not there on DirectFB/Webkit.
> I found in WebCore/plugin calls are all Xt/X11 based.
> Can any one suggest me , how can I modify these call for DirectFB ?

 DirectFB is a complete different beast, compared to X11. AFAICS you have to
 implement the whole plugin infrastructure for that.
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

>>>
>>>
>>>
>>> --
>>> Cheers!
>>> Rick
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
>>
>>
>> --
>> Sriram Neelakandan
>> Author - Embedded Linux System Design And Development
>> (http://tinyurl.com/2doosu)
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>



-- 
Sriram Neelakandan
Author - Embedded Linux System Design And Development
(http://tinyurl.com/2doosu)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] want to port JIT to MIPS - how patchOffset* constant determined?

2009-03-04 Thread x yz 

Hi,
this really helps! The two pointers may also help Mips. In Mips dest offset 
patches are in two instructions, no constant biase can be used as in X86. 
Currently I do check instruction syntax to determine the patch offset.
thanks again!
joe

--- On Wed, 3/4/09, Zoltan Herczeg  wrote:

> From: Zoltan Herczeg 
> Subject: Re: [webkit-dev] want to port JIT to MIPS - how patchOffset* 
> constant determined?
> To: webkit-dev@lists.webkit.org
> Date: Wednesday, March 4, 2009, 3:33 PM
> Hi,
> 
> they generate instructions, which size is known in advance.
> 
> Think about the following sequence:
> hotPathBegin:
>   mov regX, 32bit_const <- 6 bytes (*) (**)
>   add regX, regY <- 2 bytes
>   jo 32bit_addr <- 5 bytes (*)
> 
> * (Note) : these instructions will be modified during
> runtime.
> 
> ** (Note) : there is a short form for "mov regX,
> 8bit_const", which length
> is only 3 bytes, but they force the longer version in such
> cases to keep
> the size of the instruction.
> 
> As you can see, the address of "jo" is always
> (hotPathBegin + 6 + 2). They
> simply introduce a new constant: patchOffsetXXX = 8, and
> use this constant
> to access the "jo" instruction later.
> 
> In ARM we can't rely on such constant, because the
> constant pool can be
> placed after any instruction.
> 
> hotPathBegin:
>   ldr rX, [pc + const_pool_addr] ; 32 bit const
>   [...] <- the const pool can be placed here
>   add rX, rX, rY
>   [...] <- the const pool can be placed here
> hotPath2:
>   ldr pc, [pc + const_pool_addr] ; 32 bit target address
> 
> We need to store both pointers (hotPathBegin and hotPath2).
> 
> Zoltan
> 
> > Zoltan,
> > Thanks for reply, I'm trying to understand your
> example. But,X86
> > instruction size is from 1 to 17bytes, not constant. I
> may misunderstand
> > your comments?
> > Many X86 instruction can have imm32 at the end, thus
> this pointer can be
> > used for patch as well as next address after call.
> Does Arm have similar
> > things? or else you still need to figure out why
> > "patchOffsetOpCallCompareToJump = 9;"? may
> be some instruction lengths
> > relates to the 9?
> > rgds
> > joe
> >
> >
> > --- On Wed, 3/4/09, Zoltan Herczeg
>  wrote:
> >
> >> From: Zoltan Herczeg
> 
> >> Subject: Re: [webkit-dev] want to port JIT to MIPS
> - how patchOffset*
> >> constant determined?
> >> To: webkit-dev@lists.webkit.org
> >> Date: Wednesday, March 4, 2009, 3:45 AM
> >> On x86, the size of the instructions are fixed. If
> you want
> >> to access
> >> multiple instructions in the instruction stream,
> you only
> >> need to store
> >> the address of the first one, and can access the
> others by
> >> their relative
> >> address. This saves a little memory.
> >>
> >> Example (see JIT::linkCall):
> >>   instruction at callLinkInfo->hotPathBegin:
> points to
> >> callee comparison
> >>   instruction at
> >> callLinkInfo->hotPathBegin +
> >> patchOffsetOpCallCompareToJump:
> >>points to the slow case entry jump
> >>
> >> Zoltan
> >>
> >> > in jit.h, for example:
> >> > static const int
> >> patchOffsetOpCallCompareToJump = 9;
> >> > static const int
> patchOffsetPutByIdStructure =
> >> 7;
> >> > static const int
> >> patchOffsetPutByIdPropertyMapOffset = 22;
> >> > static const int
> >> patchOffsetGetByIdBranchToSlowCase = 13;
> >> > thanks for help, I'm stucked here now.
> >> > joe
> >> >
> >> >
> >> > --- On Sat, 2/28/09, Gavin Barraclough
> >>  wrote:
> >> >
> >> >> From: Gavin Barraclough
> >> 
> >> >> Subject: Re: [webkit-dev] want to port
> JIT to MIPS
> >> - JIT reg usage clean
> >> >> up?
> >> >> To: "WebKit Development"
> >> 
> >> >> Date: Saturday, February 28, 2009, 12:19
> PM
> >> >> On Feb 27, 2009, at 4:55 PM, x yz wrote:
> >> >>
> >> >> > The regTx seems to be working
> registers here,
> >> yet
> >> >> their definition are regparm(3) registers
> for
> >> function
> >> >> arugments. Such usage would cause
> conflict on
> >> other
> >> >> platforms. May I suggest that we use
> individual
> >> defined set
> >> >> of regs for func i/o argument and
> working?
> >> >>
> >> >> First up, I think you're getting
> slightly
> >> confused
> >> >> about regparm(3).  This is not used
> anywhere in
> >> the JS
> >> >> language JIT, only in WREC.  In some
> >> configurations of the
> >> >> JIT we use fastcall semantics on x86...
> but none
> >> of this is
> >> >> really relevant to MIPS.  Just ignore all
> this.
> >> Stick to
> >> >> the default MIPS ABI for stub functions.
> >> >>
> >> >> Reading between the lines, I'm
> guessing your
> >> concern
> >> >> here is that in setting up arguments for
> a JIT
> >> stub call you
> >> >> may trample the JIT's temporary
> registers?  If
> >> so, I
> >> >> think you need to look at the argument
> passing
> >> more closely.
> >> >>  The mechanisms to pass arguments to stub
> >> functions pass all
> >> >> arguments in memory – typically passing
> a single
> >> pointer
> >> >> to the stub functions, which can be used
> to
> >> r

Re: [webkit-dev] Applying transforms to box-reflect

2009-03-04 Thread David Hyatt 
That's not possible (mainly just a syntactic limitation).   Right now  
the transform is essentially determined by the first keyword, e.g.,  
below.  Internally the code could handle an arbitrary transform, but  
the syntax doesn't support it.


dave
(hy...@apple.com)

On Mar 4, 2009, at 12:04 PM, Jonathan Smiley wrote:

Is it possible to apply a transform (like skew) to the reflection  
generated by -webkit-box-reflect?  My current style is:

-webkit-box-reflect: below 4px
-webkit-gradient(linear, left top, left bottom,
from(transparent),
color-stop(0.8, transparent),
to(rgba(255, 255, 255, 0.25)));

I'd like to skew the reflection only (not the reflected object) such  
that the reflection's bottom edge is wider than the top.  I've  
checked the relatively sparse documentation and can't seem to find a  
definitive answer...if it's possible I imagine it's a syntactical  
thing.  Thanks!

- Jonathan Smiley

--
Jonathan Smiley
ZURB | Designer
jonat...@zurb.com
www.zurb.com
Office: 408.341.0600
Mobile: 205.514.1897
--
Read the ZURB blog:
http://www.zurb.com/blog
--

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Applying transforms to box-reflect

2009-03-04 Thread Simon Fraser 

On Mar 4, 2009, at 10:04 AM, Jonathan Smiley wrote:

Is it possible to apply a transform (like skew) to the reflection  
generated by -webkit-box-reflect?  My current style is:

-webkit-box-reflect: below 4px
-webkit-gradient(linear, left top, left bottom,
from(transparent),
color-stop(0.8, transparent),
to(rgba(255, 255, 255, 0.25)));

I'd like to skew the reflection only (not the reflected object) such  
that the reflection's bottom edge is wider than the top.  I've  
checked the relatively sparse documentation and can't seem to find a  
definitive answer...if it's possible I imagine it's a syntactical  
thing.  Thanks!




That's not possible. Reflections are simply a flip around one of the  
axes.


You'd have to generate the reflection yourself, with a combination of  
a transform and mask, to get this effect.


Simon

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Applying transforms to box-reflect

2009-03-04 Thread Jonathan Smiley 
Is it possible to apply a transform (like skew) to the reflection  
generated by -webkit-box-reflect?  My current style is:

-webkit-box-reflect: below 4px
-webkit-gradient(linear, left top, left bottom,
from(transparent),
color-stop(0.8, transparent),
to(rgba(255, 255, 255, 0.25)));

I'd like to skew the reflection only (not the reflected object) such  
that the reflection's bottom edge is wider than the top.  I've checked  
the relatively sparse documentation and can't seem to find a  
definitive answer...if it's possible I imagine it's a syntactical  
thing.  Thanks!

- Jonathan Smiley

--
Jonathan Smiley
ZURB | Designer
jonat...@zurb.com
www.zurb.com
Office: 408.341.0600
Mobile: 205.514.1897
--
Read the ZURB blog:
http://www.zurb.com/blog
--

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Detecting paste with cmd-v on Mac

2009-03-04 Thread Rush Manbert 


On Mar 3, 2009, at 11:21 PM, Alexey Proskuryakov wrote:



03.03.2009, в 23:21, Rush Manbert написал(а):

I checked the values of the DOM even modifiers alyKey, ctrlKey, and  
shiftKey and they are all false on a cmd-v paste


That's expected, Cmd maps to metaKey.


Is the difference between Safari and WebKit expected?



Yes, WebKit preserves legacy keyboard event behavior for  
applications linked against old SDK, see . The behavior was changed to be IE-compatible in version 3.1.


I expect that checking for evt.metaKey will make it easy to filter  
out Cmd+V.


- WBR, Alexey Proskuryakov



Thank you. I had missed the fact that metaKey exists as an event  
property (and had wondered why there was nothing like that). Checking  
for it works perfectly.


Best regards,
Rush
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Plug in support on DirectFB Webkit

2009-03-04 Thread Manoj Bhatta 
I have built Webkit in order to get rid of X11  calls.
Tried to replace the X11 API  with GDK calls.
But it fails when there is conversion from GtkXtBin to GtkSocket

And one more thing I found  gdk_window_add_filter()'s call back
function is not getting called in my plug in library.

I doubt its because, the plug in window creation may be a problem.



On Mon, Mar 2, 2009 at 11:00 PM, Sriram Neelakandan
 wrote:
> Well, what u need is a build time flag, which should first get rid of
> all X11 headers.
> Then you end up having to define or mapping the missing structure /
> defines in npruntime,h & npapi.h to appropriate DFB equivalents
>
> Now, after that, you will get stuck with gtk_socket_new .. a well
> known issue with DFB windowing which is currently not implemented in
> the gtk/dfb backend.
>
> I remember some how the mozilla guys managed to get DFB SWFDEC player
> plugin working.. wonder how ?
> I think mostly they rendered the plugin on a different Window !
>
> I heard that gtk_socket_new may get fixed in DFB-2.0.. untill then DFB
> plugins will have to wait !
> Not sure if there is a better way to render DFB plugins on to
> Webframe/view 's surface directly !
>
>
>
> On Mon, Mar 2, 2009 at 8:53 PM, Rick  wrote:
>> Having just looked up DirectFB on Wikipedia, I see it is an interface
>> that skips X and talks directly to the framebuffer.
>>
>> There is mention of an API called XDirectFB that mimics X11 calls.
>> You might look for that.
>>
>> On Mon, Mar 2, 2009 at 8:38 AM, Ariya Hidayat
>>  wrote:
>>>
 I am running Webkit on DirectFB.
 AFAIK, plug in support is not there on DirectFB/Webkit.
 I found in WebCore/plugin calls are all Xt/X11 based.
 Can any one suggest me , how can I modify these call for DirectFB ?
>>>
>>> DirectFB is a complete different beast, compared to X11. AFAICS you have to
>>> implement the whole plugin infrastructure for that.
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>
>>
>>
>> --
>> Cheers!
>> Rick
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
>
> --
> Sriram Neelakandan
> Author - Embedded Linux System Design And Development
> (http://tinyurl.com/2doosu)
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Curl Cookie Handling

2009-03-04 Thread ARaj 
Hi,
There is a small problem with that patch.
In the function CookieManager::getCookie(const KURL& url), a shallow local
copy of the cookie map is being created at this line:
   *HashMap curMap =
it->second->getCookieMap();*

So, when you do a "take" on this, you are essentially removing the
pointer(and subsequently deleting it) from this local copy only. Since the
original m_cookieMap still holds the deleted pointer, the next time this is
accessed, it results in a crash.

An ideal fix for this would be to get a reference from *getCookieMap() *and
use that reference in this function.

Regards,

Raj.

On Wed, Feb 11, 2009 at 1:27 AM, Kevin Ollivier 
wrote:
> Hi Julien,
>
> On Feb 10, 2009, at 7:08 AM, Julien Chaffraix wrote:
>
>> Hi Kevin,
>>
>>> Is this patch still valid, i.e. not made obsolete by another approach?
>>
>> As far as I know, there is no work towards storing the cookies inside
>> the database as it is done in Firefox. Furthermore I know no work in
>> cURL toward exposing the cookies so that we could add / remove /
>> update them simply in our database.
>>
>> This patch may be a bit special because it is not really cURL
>> specific. The only dependency to cURL is a method to parse a date (the
>> 'max-age' field), which I found later is already in JavaScriptCore and
>> would need to be exported to WebCore and maybe need to be adapted.
>> Thus it could be a base toward a cross-platform cookie implementation.
>> I do not know if it would be ok for all ports to replicate their
>> network library's cookie engine.
>
> Well, each port could of course decide for themselves. I know wx would
like
> to use this. :-) I wonder if the GTK or other ports are also interested?
> Maybe they should voice their support if so.
>
>>
>>> Also,
>>> was it a complete patch (sans any bugs, of course) for cookie support
>>> using
>>> SQLite? I could only test it using wx right now but I would definitely
be
>>> interested in using the SQLite approach.
>>
>> It is a complete patch in the sense that it stores and fetch the
>> cookies from the database. About the bug-free part, we have an answer
>> in this thread I guess :-)
>> Basically I could not find a test suite for cookies to validate the
>> approach when I started so I tested it with real world websites
>> (mostly google app suite, yahoo, mapquest and a few other sites) but
>> it did not get the testing it deserves and I will not hide it.
>
> Yes, I did look at your patch earlier but I myself wasn't confident that
I'd
> know how to properly test cookie support, so I hoped someone more
> knowledgeable would step in. :(
>
>> To get it moving, I think a rewrite is necessary because I made tons
>> of small mistakes (I started as a contributor at that time and did not
>> know the code and coding conventions as I do now) that could be more
>> easily tackled by a rewrite. It will also need a test suite to fully
>> valide the changes.
>> All in all, it means a lot of work that I am willing to do it *if* I
>> see enough interest in a cross-platform cookie engine for WebKit.
>
> Well, knowing this project, I doubt you'll find anyone who would object to
> starting a series of unit tests for cookies. :-) From there, it is a
matter
> of reworking your patch, but I can say if there is a test suite I can run
> that handles common usage, I'll feel a lot more comfortable reviewing your
> patch.
>
>>
>>> I know someone a while back proposed a strategy for dealing with port
>>> enhancements that end up bit rotting in the review tree, whatever
>>> happened
>>> to that? Sometimes new feature patches cannot be broken down into
smaller
>>> pieces, and I realize large patches tend to be intimidating especially
to
>>> people who can't test them themselves, but there has to be some strategy
>>> for
>>> dealing with that so that important new stuff doesn't just sit in a
patch
>>> tracker for months or years...
>>
>> I think you refer to the Gtk port here? IIRC the main issue for Gtk
>> was validating the API which is not relevant here.
>
> That sounds familiar, I guess I mistook the discussion to be about "port
> specific" rather than "API specific" patches. Still, I think there ought
to
> be some recourse when a patch submitter cannot find a willing reviewer
after
> some long period of time.
>
> Thanks,
>
> Kevin
>
>>
>> Regards,
>> Julien
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] how to store javascript identifier

2009-03-04 Thread Gavin Barraclough 

On Mar 4, 2009, at 2:22 AM, zhenghe zhang wrote:


When running a webpage, and the javascriptcore will parse the
javascript function, and will obtain some identifiers.  I don't know  
how to

store these identifiers and where to store these identifiers.


These identifiers are stored in the identifierTable on the  
globalData.  The identifiers are represented by objects of type  
Identifier.  If you look in parse.h, the nodes that have an identifier  
as a one of their properties typically have a field called m_ident.   
Within the Identifer constructor it calls Identifer::add() (which is  
in Identifier.cpp), and this ensures each identifier is represented by  
a unique string in the identifierTable.


I hope this helps to answer your question.

G.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to show text message on browser

2009-03-04 Thread Nilesh Patil 
hi

Yes ... very correct !!


Thanks & regards
Niilesh

On Wed, Mar 4, 2009 at 4:04 PM, arj123  wrote:
>
> Hi Nilesh,
> Will these static HTML pages stay on local hard disk and loaded in WebView
> from there?
>
> Thanks
>
>
> Nilesh Patil-2 wrote:
>>
>> Hi
>>
>> Do you mean that you want to show it as a part of HTML page ( like how
>> its shown for 404).
>>
>> If  Yes then i have the simpler way. Create some staic HTML pages with
>> good CSS styles ( i mean attractive styles) for appropriate errors.
>> These pages will contains
>> appropriate error message. Then just load them when error occurs. This
>> way you will have more control on how to show the message.
>>
>> Thanks & Regards
>> Niilesh
>>
>> On Mon, Feb 23, 2009 at 7:58 PM, Nitin Walke  wrote:
>>> Hi all,
>>>
>>> I have to show some user defined message in browser.How can I show in
>>> browser? pop-window is one where we can show, but I want to show it in
>>> browser main window.I am using gtk as front end.
>>>   suggestion will be appreciated
>>>
>>> Regards,
>>> Nitin
>>>
>>>
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
> --
> View this message in context: 
> http://www.nabble.com/How-to-show-text-message-on-browser-tp22162492p22327420.html
> Sent from the Webkit mailing list archive at Nabble.com.
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to show text message on browser

2009-03-04 Thread arj123 

Hi Nilesh,
Will these static HTML pages stay on local hard disk and loaded in WebView
from there?

Thanks


Nilesh Patil-2 wrote:
> 
> Hi
> 
> Do you mean that you want to show it as a part of HTML page ( like how
> its shown for 404).
> 
> If  Yes then i have the simpler way. Create some staic HTML pages with
> good CSS styles ( i mean attractive styles) for appropriate errors.
> These pages will contains
> appropriate error message. Then just load them when error occurs. This
> way you will have more control on how to show the message.
> 
> Thanks & Regards
> Niilesh
> 
> On Mon, Feb 23, 2009 at 7:58 PM, Nitin Walke  wrote:
>> Hi all,
>>
>> I have to show some user defined message in browser.How can I show in
>> browser? pop-window is one where we can show, but I want to show it in
>> browser main window.I am using gtk as front end.
>>   suggestion will be appreciated
>>
>> Regards,
>> Nitin
>>
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> 

-- 
View this message in context: 
http://www.nabble.com/How-to-show-text-message-on-browser-tp22162492p22327420.html
Sent from the Webkit mailing list archive at Nabble.com.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] how to store javascript identifier

2009-03-04 Thread zhenghe zhang 
Hi all
Now I have a diffcult problem, and I don't how to solve it.
I hope you help me, thank you!
When running a webpage, and the javascriptcore will parse the
javascript function, and will obtain some identifiers.  I don't know how to
store these identifiers and where to store these identifiers.
Thank you
Regards
zh

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev