Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-05-24 Thread Maciej Stachowiak
On May 23, 2009, at 9:38 AM, David Kilzer wrote: Another aspect of this proposal is how to handle source files that have #if ENABLE(FEATURE)/#endif guards around all of their source code, for example: Bug 25756: Explicit guards for ENABLE_GEOLOCATION

[webkit-dev] Does anyone encounter this problem on NY times while using QWebKit?

2009-05-24 Thread TianShijun
Hi All, I cannot open the www.nytimes.com correctly on a Qt port of WebKit. Can anyone help to verify or analysis the problem? While open nytimes in Qtlauncher(built with QT4.5, QT4.3.3) or QTDIR/examples/webkit/previewer(webkit integrated in QT 4.3.3), the topmost bar cannnot be rendered.

Re: [webkit-dev] Browser issue with multiple tabulators

2009-05-24 Thread Sebastian Hennebrueder
Jeremy Orlow schrieb: This is _exactly_ the use case SessionStorage was developed for. :-) On Fri, May 22, 2009 at 2:41 PM, Darin Adler da...@apple.com wrote: I believe HTML 5’s sessionStorage is intended to resolve this issue. -- Darin ___

Re: [webkit-dev] Does anyone encounter this problem on NY times while using QWebKit?

2009-05-24 Thread tonikitoo (Antonio Gomes)
I am seeing it too. Firefox 3.5preb4 renders its top bar all fine, fwiw. see http://farm4.static.flickr.com/3638/3560998719_d26d476d73.jpg?v=0 have you tried w/ other webkit ports ? it can be not qt-specific (?) br 2009/5/24 TianShijun tians...@hotmail.com: Hi All, I cannot open the

[webkit-dev] lib change questions

2009-05-24 Thread sitan2006
There're many 3rd and self libraries in default WebKit. Some of them may be replaced while building , but I think not all. nbsp; Here is a list, I wonder which of them could be replaced through building configuration , which of them are tightly coupled with webkit and could hardly be replaced.

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-05-24 Thread sitan2006
nbsp;Well , It seems we're on thenbsp;similar problem. I posted a question in lib change questions, for I found migrating webkit on other platformnbsp; or replacing some libs is very time-costing. nbsp; So, if all the work can be fixed through building, it must be a big

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-05-24 Thread Peter Kasting
On Sun, May 24, 2009 at 12:19 AM, Maciej Stachowiak m...@apple.com wrote: On May 23, 2009, at 9:38 AM, David Kilzer wrote: There are essentially two options here: 1. Add #if/#endif guards to entire source files, but include every file in every build system. 2. Make each build system smart

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-05-24 Thread Maciej Stachowiak
On May 24, 2009, at 9:28 PM, Peter Kasting wrote: On Sun, May 24, 2009 at 12:19 AM, Maciej Stachowiak m...@apple.com wrote: On May 23, 2009, at 9:38 AM, David Kilzer wrote: There are essentially two options here: 1. Add #if/#endif guards to entire source files, but include every file in

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-05-24 Thread Adam Barth
On Sun, May 24, 2009 at 10:08 PM, Maciej Stachowiak m...@apple.com wrote: I don't think it should be discounted. It might be helpful to clarify why you think ifdefs are a bad solution. When I made changes that affect several ports, I try to be good WebKit citizen and update all the ports, but