[webkit-dev] How to maintain order of bookmark

2009-06-04 Thread Arsh Kapoor
I have maintained a list of bookmarks with some serial no. and timestamps. The display is according to the serial no. Now if I drag a bookmark say serial no. 6th and drop it in place of serial no. 2nd. My bookmarks should be arranged accordingly with the 6th bookmark occupying the 2nd slot and pre

Re: [webkit-dev] Rendering Video using video overlay rather than on a Cairo surface (Graphics overlay)

2009-06-04 Thread Sriram Neelakandan
On Fri, Jun 5, 2009 at 9:56 AM, Ajit Singh wrote: > The first problem which i'm facing in this endaveour is of translating the > coordinates from WebKit domain to the BCM Framebuffer. Basically the > coordinates supplied in paint/setsize cannot be directly used on the native > graphics software

Re: [webkit-dev] Rendering Video using video overlay rather than on a Cairo surface (Graphics overlay)

2009-06-04 Thread Ajit Singh
The first problem which i'm facing in this endaveour is of translating the coordinates from WebKit domain to the BCM Framebuffer. Basically the coordinates supplied in paint/setsize cannot be directly used on the native graphics software layer. Let me explain: I'm trying to render a web page of

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Toshiyasu Morita
Thanks guys. One request - please write more comments in the code to clarify situations like this. Toshi --- On Thu, 6/4/09, Darin Adler wrote: From: Darin Adler Subject: Re: [webkit-dev] cti_op_call_ArityCheck question To: "Toshiyasu Morita" Cc: webkit-dev@lists.webkit.org Date: Thursday,

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Gavin Barraclough
On Jun 4, 2009, at 5:49 AM, Zoltan Herczeg wrote: Hi Gavin, the alignment error was not your fault. When you start porting the JIT, you need to keep many things in your head, and I totally forgot about stack alignment. The entry and exit functions are not portable, and you have to arrange

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 1:50 PM, Toshiyasu Morita wrote: I don't understand this code in JITStubs::cti_op_call_arityCheck(): ASSERT(argCount != newCodeBlock->m_numParameters); It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could u

Re: [webkit-dev] Question about CSS in Webkit

2009-06-04 Thread David Hyatt
On Jun 4, 2009, at 3:24 PM, Darin Adler wrote: On Jun 4, 2009, at 1:19 PM, Nathan Summer wrote: My question is if the CSS information stored Twice? onces are in the internal data structure built after parsing the CSS and other is in RenderStyle? The CSS stores the style rules. The RenderS

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Gavin Barraclough
We check in JIT code for cases where arity match, and skip the call to the stub; this function is only called if there is a mismatch to be resolved. The function would probably be better named something like 'cti_op_call_handleArityMismatch'. cheers, G. On Jun 4, 2009, at 1:50 PM, Toshiya

[webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Toshiyasu Morita
I don't understand this code in JITStubs::cti_op_call_arityCheck():     ASSERT(argCount != newCodeBlock->m_numParameters); It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could understand if it was ensuring the argCount was the same, b

Re: [webkit-dev] Question about CSS in Webkit

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 1:19 PM, Nathan Summer wrote: My question is if the CSS information stored Twice? onces are in the internal data structure built after parsing the CSS and other is in RenderStyle? The CSS stores the style rules. The RenderStyle stores the actual style chosen for each el

[webkit-dev] Question about CSS in Webkit

2009-06-04 Thread Nathan Summer
Hi, I guess Webkit will parse each CSS files into some internal data structure to store CSS information. And from http://webkit.org/blog/114/webcore-rendering-i-the-basics/: During attachment the DOM queries CSS to obtain style information for an element. The resultant information is stored in an

Re: [webkit-dev] Automatically generated -expected.txt is missing editing delegate

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 12:41 PM, Ryosuke Niwa wrote: it seems like run-webkit-tests doesn't generate editing delegate. Is it platform specific problem (I'm trying to do this on Windows)? Yes, that's not implemented on Windows yet. -- Darin ___ we

[webkit-dev] Automatically generated -expected.txt is missing editing delegate

2009-06-04 Thread Ryosuke Niwa
Hi, I'm trying to generate -expected.txt with editing delegate information for test cases in editing/execCommand (revision: 44389), but it seems like run-webkit-tests doesn't generate editing delegate. Is it platform specific problem (I'm trying to do this on Windows)? Or is there some option to

Re: [webkit-dev] Coding style

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 11:28 AM, David Levin wrote: I've thought rule of the rule as this "Control clauses (including any preceeding comments) that are one physical line should not use braces". So something like if (test) { myFunction(reallyLongParam1, reallyLongParam2, ...

Re: [webkit-dev] Coding style

2009-06-04 Thread David Levin
I've thought rule of the rule as this "Control clauses (including any preceeding comments) that are one* physical *line should not use braces". So something like if (test) { myFunction(reallyLongParam1, reallyLongParam2, ... reallyLongParam4); } would also have braces. Is that how others interpr

Re: [webkit-dev] Coding style

2009-06-04 Thread Kenneth Christiansen
OK, done! :-) https://bugs.webkit.org/show_bug.cgi?id=26188 Cheers, Kenneth On Thu, Jun 4, 2009 at 12:13 PM, David Kilzer wrote: > Hi Kenneth, > The examples you give below are correct (with the exception of the number of > spaces used to indent the code in the else blocks). > Please file a bug

Re: [webkit-dev] How to disable webkit image loading

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 9:40 AM, James Howlett wrote: Is there any configuration/setting in the code which can dynamically enable/disable image loading? If yes, can you please tell me how to do that in the code? Sure. [[webView preferences] setLoadsImagesAutomatically:NO] You didn’t speci

[webkit-dev] How to disable webkit image loading

2009-06-04 Thread James Howlett
Hi, Is there any configuration/setting in the code which can dynamically enable/disable image loading? If yes, can you please tell me how to do that in the code? Thank you. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/m

Re: [webkit-dev] Coding style

2009-06-04 Thread David Kilzer
Hi Kenneth, The examples you give below are correct (with the exception of the number of spaces used to indent the code in the else blocks). Please file a bug on bugs.webkit.org and attach a patch. The webkit.org web site is in the svn repository, so you may create patches against the HTML. T

Re: [webkit-dev] Coding style

2009-06-04 Thread Alexey Proskuryakov
Hi Kenneth, All the code snippets you gave are correct per our coding style. - WBR, Alexey Proskuryakov 04.06.2009, в 18:52, Kenneth Christiansen написал(а): Hi there, I'm having a question regarding the coding style. According to 2. An else statement should go on the same line as a preced

[webkit-dev] Coding style

2009-06-04 Thread Kenneth Christiansen
Hi there, I'm having a question regarding the coding style. According to 2. An else statement should go on the same line as a preceding close brace. I would always need a brace when using if-else, in order to but the else statement on the same line as the preceding close brace, is this right? or

[webkit-dev] What's going on with the debug Leopard bot on build.webkit.org?

2009-06-04 Thread Adam Roben
This bot has had 93 tests failing for quite some time. Does anyone know what's causing these failures? -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Zoltan Herczeg
Hi Gavin, the alignment error was not your fault. When you start porting the JIT, you need to keep many things in your head, and I totally forgot about stack alignment. The entry and exit functions are not portable, and you have to arrange the stack frame by yourself for your architecture. I am h

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Gavin Barraclough
Hi Zoltan, I'm a little confused – maybe I'm misunderstanding you, but the JIT does just subtract a fixed amount from the stack pointer on entry (28 on x86, for a total frame size including return address, caller frame pointer and callee preserved registers of 48, a multiple of 16 to pres

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Zoltan Herczeg
Hi, actually there was a bug which took me a day to find out what happened. It was somewhere deep in libc, called by a function in DateMath.cpp. It seemed that the stack was overwritten. By libc??? I can't belive it. Finally I realized that gcc's alloca realigned the stack (to 8 bytes on ARM), so