Re: [webkit-dev] WinCE Font work

[George Staikos]

Yes I agree; I was just going to r- this patch in fact.

Some of these problems arose from the fact that we started this work  
nearly two years ago and were working outside of SVN so it's taking  
some time to realign.


On 5-Aug-09, at 2:13 PM, Dan Bernstein wrote:


Hi,

Today while looking at the patch at  I noticed that the WinCE version of  
FontCustomPlatformData includes CachedFont.h and uses CachedFont.


It is incorrect for classes in the platform layer to have any  
knowledge of higher WebCore layers (essentially, anything outside  
the platform hierarchy). In this case, it also necessitated a  
platform difference in the createFontCustomPlatformData call site  
in CachedFont::ensureCustomFontData(), which is how I noticed it.


I think once you should correct this and any other layering  
violations in the WinCE platform layer, and only then submit  
patches with changes to cross-platform code, if any such changes  
are still deemed necessary. I don’t think  and  should be reviewed until then.


Thanks,
—Dan


--
George Staikos
Torch Mobile Inc.
http://www.torchmobile.com/

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] WinCE Font work

[Dan Bernstein]

Hi,

Today while looking at the patch at  I noticed that the WinCE version of FontCustomPlatformData includes  
CachedFont.h and uses CachedFont.


It is incorrect for classes in the platform layer to have any  
knowledge of higher WebCore layers (essentially, anything outside the  
platform hierarchy). In this case, it also necessitated a platform  
difference in the createFontCustomPlatformData call site in  
CachedFont::ensureCustomFontData(), which is how I noticed it.


I think once you should correct this and any other layering violations  
in the WinCE platform layer, and only then submit patches with changes  
to cross-platform code, if any such changes are still deemed  
necessary. I don’t think  and  should  
be reviewed until then.


Thanks,
—Dan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] useless mov instructions

[Oliver Hunt]

For "program" and "eval" code the result of the execution is result of  
the last evaluated expression.  To deal with this we somewhat  
pessimistically always copy results to the return register.  We could  
theoretically improve this, but some testing i did a while ago (that  
broke correctness by simply returning undefined for program and eval  
code) did not impact performance in any real way.  If you have an  
example that you believe is impacted by this pessimism it would be  
great if you could file a bug at http://bugs.webkit.org


--Oliver

On Aug 5, 2009, at 8:35 AM, Ágoston Róbert wrote:


hi!

I just experiment with squirrelfish bytecode generating, and I think I
find something
strange. After each mov instruction, where the source is a constant
register, there is
an other mov instruction, which moves the previous destination to r0.
I think these instructions are useless. Is there any reason why are
they generated?

There is an example:
js:

var r_15;
var r_16;
var r_17;
var r_18;
r_15 = 1;
r_16 = 2;
r_17 = 3;
r_17 = 4;

generated:
[   0] enter
[   1] mov   r-15, r1073741824
[   4] mov   r-16, r1073741824
[   7] mov   r-17, r1073741824
[  10] mov   r-18, r1073741824
[  13] mov   r0, r1073741824
[  16] mov   r-15, r1073741825
[  19] mov   r0, r-15
[  22] mov   r-16, r1073741826
[  25] mov   r0, r-16
[  28] mov   r-17, r1073741827
[  31] mov   r0, r-17
[  34] mov   r-17, r1073741828
[  37] mov   r0, r-17
[  40] end   r0

-Robert
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] useless mov instructions

[Ágoston Róbert]

hi!

I just experiment with squirrelfish bytecode generating, and I think I
find something
strange. After each mov instruction, where the source is a constant
register, there is
an other mov instruction, which moves the previous destination to r0.
I think these instructions are useless. Is there any reason why are
they generated?

There is an example:
js:

var r_15;
var r_16;
var r_17;
var r_18;
r_15 = 1;
r_16 = 2;
r_17 = 3;
r_17 = 4;

generated:
[   0] enter
[   1] mov   r-15, r1073741824
[   4] mov   r-16, r1073741824
[   7] mov   r-17, r1073741824
[  10] mov   r-18, r1073741824
[  13] mov   r0, r1073741824
[  16] mov   r-15, r1073741825
[  19] mov   r0, r-15
[  22] mov   r-16, r1073741826
[  25] mov   r0, r-16
[  28] mov   r-17, r1073741827
[  31] mov   r0, r-17
[  34] mov   r-17, r1073741828
[  37] mov   r0, r-17
[  40] end   r0

-Robert
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Can someone give current status for Webkit/GTK build under mingw

[Zoltan Herczeg]

Hi,

>Im not sure if Im asking the right place 
yes :), such qestions should go to webkit-help

Cheers,
Zoltan


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Can someone give current status for Webkit/GTK build under mingw

[Nevo]

hi :
   Im not sure if Im asking the right place 
   Can someone give the current status for Webkit/GTK  build under MinGW ?
   Now I've tried to configure and compile Webkit/gtk 1.1.5 under my Mingw
cross toolchain (gcc 4.2 g++ 4.2 ).  Directly "configure/make" was not
working as I expected, and after some tunings in generated GNUmakefile and
modifications in the code , I was able to compile the webkit libraries. But
interestingly , even with "--enable-shared" , I couldnot produce .dll files
at all, only .a and .la files are placed under .libs dir.
   So if someone can point out which version is supporting MinGW without the
need of hack, that would be helpful . Thanks

Nevo
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev