[webkit-dev] layout test expectation files without tests

2009-10-21 Thread Shinichiro Hamaji
Hi WebKit, I found there are several expectation files which don't have corresponding tests. Most of them are fine. People just forgot to remove expectation files when they removed the tests. However, there are some cases in which people forgot to add test files. For such cases, I think we should

Re: [webkit-dev] layout test expectation files without tests

2009-10-21 Thread Darin Adler
On Oct 21, 2009, at 2:17 AM, Shinichiro Hamaji wrote: However, there are some cases in which people forgot to add test files. Thanks for tackling this! - fast/dynamic/8952-reduction author: darin trac: http://trac.webkit.org/changeset/15459 comment: now the png file is in platform/mac In

Re: [webkit-dev] JIT for arm is dependant on gcc

2009-10-21 Thread Zoltan Herczeg
Hi, these entry/leave functions are implemented in assembly for all ports. It is faster this way. (Previously, the jit generated these functions, but the reviewers convinced us to do this way). External .asm files would be a nightmare, since we have to create (and maintain) the build rules for

Re: [webkit-dev] JIT for arm is dependant on gcc

2009-10-21 Thread Jason Rukman
The Microsoft ARM toolchain does not support inline assembler so I'm unable to compile any inline assembler. I'm trying to understand how to make these functions external but it doesn't appear to be straightforward (e.g. The first problem I hit was that the asm push instruction is unknown,

Re: [webkit-dev] layout test expectation files without tests

2009-10-21 Thread Ojan Vafai
On Wed, Oct 21, 2009 at 2:17 AM, Shinichiro Hamaji ham...@chromium.orgwrote: - fast/forms/basic-textareas-quirks author: ojan trac: http://trac.webkit.org/changeset/41792 Doh. The quirks version of this test was rolled into the basic-textareas.html test before checking in. I'll remove the

Re: [webkit-dev] JIT for arm is dependant on gcc

2009-10-21 Thread Zoltan Herczeg
Hi, sorry, I don't know anything about ms arm tools (ok, not just their arm tools). push/pop {regs} is an alias for stmdb/ldmia sp!, { regs } I presume you use ms os, which means you have to implement the cacheflush() for your own os as well. (The current implementation is designed for Linux)

[webkit-dev] Compiling webkit

2009-10-21 Thread Alexander Cohen
Hello, I've been fiddling with WebKit a bit but for the life of me, i can't seem to get it to compile on Mac. I've followed all the instructions on webkit.org. Are there any dependencies or tools that might not be mentionned on the building webkit pages? I can include the build errors

Re: [webkit-dev] Compiling webkit

2009-10-21 Thread Alexander Cohen
On Oct 21, 2009, at 3:33 PM, Evan Martin wrote: On Wed, Oct 21, 2009 at 12:29 PM, Alexander Cohen naft...@me.com wrote: I've been fiddling with WebKit a bit but for the life of me, i can't seem to get it to compile on Mac. I've followed all the instructions on webkit.org . Are there any

Re: [webkit-dev] Compiling webkit

2009-10-21 Thread Alexander Cohen
I'm guessing i need QT installed since that installing it fixed the problem. I should have seen that. Is there anyway to build WebKit without QT or is it a required tool? thx AC On Oct 21, 2009, at 4:00 PM, Alexander Cohen wrote: On Oct 21, 2009, at 3:33 PM, Evan Martin wrote: On Wed,

Re: [webkit-dev] Compiling webkit

2009-10-21 Thread Alexander Cohen
On Oct 21, 2009, at 4:23 PM, Mark Rowe wrote: On 2009-10-21, at 13:06, Alexander Cohen wrote: I'm guessing i need QT installed since that installing it fixed the problem. I should have seen that. Is there anyway to build WebKit without QT or is it a required tool? Unset the QTDIR

Re: [webkit-dev] Cross-port localized strings

2009-10-21 Thread Darin Adler
On Oct 20, 2009, at 1:25 PM, Michelangelo De Simone wrote: I need to understand whether or not I am supposed to provide a blind implementation for every available port in the trunk, even if this means a potential port specific break. Yes, that’s what I usually do. -- Darin