Re: [webkit-dev] SVG Filters

2009-12-07 Thread Maciej Stachowiak
On Dec 6, 2009, at 3:00 PM, Dirk Schulze wrote: Hi Maciej and Darin, you both suggested to add fuzz tests for SVG Filters. I looked at the fuzz test LayoutTest/svg/dom/fuzz-path-parser.html. As an analogy to this test, I would suggest an array with the effects to test, it's number of inputs

[webkit-dev] AJAX requests from local files to network stopped working in 4.6

2009-12-07 Thread Alexander Vassilev
Hi all, I am using qt and qtwebkit in my application, it embeds webkit and loads some local html and javascript files, which do XMLHTTP requests over the network. With qtwebkit 4.5.x I had no problems doing so, no cross-site scripting blocking by webkit, everything just worked (i did security

Re: [webkit-dev] AJAX requests from local files to network stopped working in 4.6

2009-12-07 Thread Darin Adler
On Dec 7, 2009, at 6:28 AM, Alexander Vassilev wrote: With qtwebkit 4.5.x I had no problems doing so, no cross-site scripting blocking by webkit, everything just worked (i did security control by myself). With qt 4.6 however, I get an empty responseText of the XMLHttpRequest object. I

[webkit-dev] Accessibility: Usage of node in TextMarkerData not reference counting... leading to crashes

2009-12-07 Thread Chris Fleizach
When we create TextMarkerData in AXObjectCache.cpp We just stick in a Node, like so textMarkerData.axID = obj.get()-axObjectID(); textMarkerData.node = domNode; textMarkerData.offset = deepPos.deprecatedEditingOffset(); textMarkerData.affinity = visiblePos.affinity(); It seems

[webkit-dev] Renaming WebCore/dom/ClassNames

2009-12-07 Thread Nate Chapin
(https://bugs.webkit.org/show_bug.cgi?id=32250 is the relevant bug) Summary: ClassNames used to be used only for class names, but its behavior meets the requirements for HTML5's strings of space separated tokens. If folks are ok with it, I'd like to rename ClassNames to something more generic so

Re: [webkit-dev] Renaming WebCore/dom/ClassNames

2009-12-07 Thread Darin Adler
On Dec 7, 2009, at 3:33 PM, Nate Chapin wrote: I was thinking of renaming it to SpaceSplitString, or AtomicStringList (it's previous name), but I'm not hung up on any particular name. Renaming seems OK. Of the two I definitely prefer SpaceSplitString. Generally I think we should only use

Re: [webkit-dev] using statement clarifications

2009-12-07 Thread Chris Jerdonek
On Mon, Dec 7, 2009 at 9:30 AM, Darin Adler da...@apple.com wrote: Sorry, I wasn’t able to follow all the logic in the style guideline and the email message nor fully understand what the script enforces. So I’ll give my view on this and hope it helps. Thanks. To be clear, I will restate

Re: [webkit-dev] using statement clarifications

2009-12-07 Thread Darin Adler
On Dec 7, 2009, at 8:42 PM, Chris Jerdonek wrote: The existing guidelines single out the case of nested namespaces and says they should appear further down when the parent exists. For example, instead of this-- using namespace WebCore::HTMLNames; namespace WebCore { do this--