Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-21 Thread Tor Arne Vestbø
Darin Adler wrote: Hi folks. We’ve never formalized this, but I believe that patches tagged with a particular platform name such as [Qt] Add new API for fluffy bunnies should be limited to one particular platform’s code. If the patch changes more than a trivial bit of platform-independent

Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-21 Thread Anton Muhin
On Thu, Jan 21, 2010 at 10:58 AM, Maciej Stachowiak m...@apple.com wrote: On Jan 20, 2010, at 8:18 AM, Darin Adler wrote: Hi folks. We’ve never formalized this, but I believe that patches tagged with a particular platform name such as     [Qt] Add new API for fluffy bunnies should be

Re: [webkit-dev] Font layout features

2010-01-21 Thread Jason Rukman
Any pointers at all would be greatly appreciated! -Original Message- From: Jason Rukman Sent: Wednesday, January 20, 2010 9:49 AM To: webkit-dev@lists.webkit.org Subject: Font layout features As part of our port to windows CE we are using a Cairo configuration combined with freetype. 

Re: [webkit-dev] Font layout features

2010-01-21 Thread Evan Martin
On Wed, Jan 20, 2010 at 9:49 AM, Jason Rukman jas...@bsquare.com wrote: As part of our port to windows CE we are using a Cairo configuration combined with freetype.  This is fairly similar to the Windows port but we are not using the native Windows GDI/cairo layer for fonts (instead we are

[webkit-dev] Anonymous Rendering Objects in Web Inspector

2010-01-21 Thread Alex Milowski
In my MathML code I often wrap the direct rendering objects for a particular element in an anonymous rendering object. When I inspect these elements I get the particular rendering object for the element but between that element and the parent's rendering object there are these anonymous objects

Re: [webkit-dev] Font layout features

2010-01-21 Thread Jason Rukman
Thanks for the reply Evan! We are using the same code as the windows Cairo port for glyph rendering so FontCairo which only uses cairo_show_glyphs. The only difference is that our port of Cairo is using cairo-ft instead of cairo-win32-font and we've brought the freetype font support over from

Re: [webkit-dev] Font layout features

2010-01-21 Thread Evan Martin
On Thu, Jan 21, 2010 at 10:23 AM, Jason Rukman jas...@bsquare.com wrote: I guess my main question is; What does pango do for the gtk port? Do I need to worry that we are not using it and just using freetype? Complex text. Without Pango or Harfbuzz or ICU you won't properly display Arabic,

Re: [webkit-dev] Font layout features

2010-01-21 Thread Evan Martin
On Thu, Jan 21, 2010 at 10:41 AM, Evan Martin e...@chromium.org wrote: On Thu, Jan 21, 2010 at 10:23 AM, Jason Rukman jas...@bsquare.com wrote: I guess my main question is; What does pango do for the gtk port? Do I need to worry that we are not using it and just using freetype? Complex text.

Re: [webkit-dev] Font layout features

2010-01-21 Thread Jason Rukman
I'm also using icu... does this mean I should be ok? -Original Message- From: ev...@google.com [mailto:ev...@google.com] On Behalf Of Evan Martin Sent: Thursday, January 21, 2010 10:41 AM To: Jason Rukman Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Font layout features On

Re: [webkit-dev] Font layout features

2010-01-21 Thread Jason Rukman
Just to clarify. Using freetype with ICU alone isn't sufficient without pango or harfbuzz for Arabic et al? -Original Message- From: ev...@google.com [mailto:ev...@google.com] On Behalf Of Evan Martin Sent: Thursday, January 21, 2010 10:45 AM To: Jason Rukman Cc:

Re: [webkit-dev] Font layout features

2010-01-21 Thread Evan Martin
On Thu, Jan 21, 2010 at 10:59 AM, Jason Rukman jas...@bsquare.com wrote: Just to clarify.  Using freetype with ICU alone isn't sufficient without pango or harfbuzz for Arabic et al? ICU is a big library. It depends on where and how you're using it. Why not just try some Arabic text and see?

Re: [webkit-dev] Anonymous Rendering Objects in Web Inspector

2010-01-21 Thread Alex Milowski
On Thu, Jan 21, 2010 at 10:43 AM, Dan Bernstein m...@apple.com wrote: On Jan 21, 2010, at 9:44 AM, Alex Milowski wrote: In my MathML code I often wrap the direct rendering objects for a particular element in an anonymous rendering object.  When I inspect these elements I get the particular

Re: [webkit-dev] Anonymous Rendering Objects in Web Inspector

2010-01-21 Thread Darin Adler
On Jan 21, 2010, at 11:22 AM, Alex Milowski wrote: So, when I try this with the trunk I get an error on the console: 2010-01-21 11:17:24.288 Safari[20905:80f] *** -[WebRenderNode initWithWebFrameView:]: unrecognized selector sent to instance 0x1f930270 and nothing happens. This was

Re: [webkit-dev] +R mode on #webkit IRC channel

2010-01-21 Thread Philippe Normand
Maybe it was a countermeasure for yesterday's CTCP flood attacks? Philippe On Tue, 2010-01-19 at 10:25 +0200, Xan Lopez wrote: Hi, I woke up this morning to find #webkit set up with mode +R (http://docs.dal.net/docs/modes.html#2.17), so basically you can't speak unless you have your nick

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-21 Thread Jedrzej Nowacki
On Thursday 14. January 2010 12.49.40 ext Kenneth Christiansen wrote: In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software

[webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Dirk Pranke
Hi all, I'm about to upload a patch that depends on third-party python code (simplejson). The patch is a bunch of scripts that'll live under WebKitTools/Scripts . Is there an appropriate place for the simplejson code? In the absence of a better location, I'll probably check it in under

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread David Levin
So far, things have been put in place with other files (like the python websockets code) but I think that is confusing for a number of reasons: 1. The level of review needed varies imo between 3rd party code that is being used vs new code added to wk. 2. The style never seems to match what is done

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Eric Seidel
We also have webkitpy/autoinstall.py which knows how to download modules on-demand. This is useful in the case that you're using code with an incompatible license. see webkitpy/__init__.py for an example of how we pull in mechanize (which is a HUGE module, with a compatible license for most

Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-21 Thread Chang.Shu
Just want to add my two cents. Based on my own experience, I think a patch that targets to fix a platform-specific problem but ends up making changes in platform-independent code, often means either the fix is problematic or a new bug/test case needs to be created for the independent part only.

Re: [webkit-dev] MathML Patch - Current Code

2010-01-21 Thread Alex Milowski
On Thu, Jan 14, 2010 at 8:23 PM, Alex Milowski a...@milowski.org wrote: I plan on creating smaller patches that contain code from this patch and as that gets committed, I'll update this bug with a new patch against the trunk. Here's my first patch that splits off some of the basic setup:

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Adam Barth
This page makes it looks like we can just autoinstall simplejson: http://pypi.python.org/pypi/simplejson/ IMHO, that's better than checking it in. Adam On Thu, Jan 21, 2010 at 1:58 PM, Eric Seidel e...@webkit.org wrote: We also have webkitpy/autoinstall.py which knows how to download

[webkit-dev] Build bots

2010-01-21 Thread KwangYul Seo
It seems gtk and qt build bots are never for run for 33937. Do I need to do something here? https://bugs.webkit.org/show_bug.cgi?id=33937 Regards, Kwang Yul Seo ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Dirk Pranke
Autoinstall appears to be pretty flaky for me at the moment, and these aren't the sort of scripts that can be flaky :) I'll install simplejson into WebKitTools/simplejson as part of the patch and we can clean it up once things are stable. -- Dirk On Thu, Jan 21, 2010 at 2:45 PM, Eric Seidel

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Adam Barth
According to that site, the package is available under: License :: OSI Approved :: MIT License Is that compatible with being landed in the svn.webkit.org tree? Adam On Thu, Jan 21, 2010 at 5:58 PM, Dirk Pranke dpra...@chromium.org wrote: Autoinstall appears to be pretty flaky for me at the

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Eric Seidel
To make things simpler when upstreaming, lets start by just requiring users have simplejson installed to use run-chromium-webkit-tests. I can fix the autoinstall stuff later. On Thu, Jan 21, 2010 at 6:01 PM, Adam Barth aba...@webkit.org wrote: According to that site, the package is available

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread David Levin
I didn't see a web page about it, but when you submit a patch, every single bullet mentions only BSD or LGPL 2.1 is accepted. If you are sending in a patch to existing WebKit code, you agree by clicking below that your changes are licensed under the existing license terms of the file you are

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Maciej Stachowiak
The MIT license is equivalent to the standard no-advertising-clause BSD license that we use in WebKit. It would be acceptable. - Maciej On Jan 21, 2010, at 6:11 PM, David Levin wrote: I didn't see a web page about it, but when you submit a patch, every single bullet mentions only BSD or

Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-21 Thread Maciej Stachowiak
On Jan 21, 2010, at 3:37 AM, Anton Muhin wrote: On Thu, Jan 21, 2010 at 10:58 AM, Maciej Stachowiak m...@apple.com wrote: On Jan 20, 2010, at 8:18 AM, Darin Adler wrote: Hi folks. We’ve never formalized this, but I believe that patches tagged with a particular platform name such as

[webkit-dev] ENABLE(SINGLE_THREADED)

2010-01-21 Thread KwangYul Seo
Hi, Currently, ENABLE(SINGLE_THREADED) guard seems to be used by Qt alone. I think it is good to have ENABLE(SINGLE_THREADED) for other ports. Qt adds appropriate guards for ENABLE(SINGLE_THREADED) in the build script, WebKit.pri. For other ports to use it, we need to move theses guards to

[webkit-dev] IndexedDB API

2010-01-21 Thread Jeremy Orlow
A couple of us at Google are starting to look at implementing the IndexedDB API [1] in WebKit. We thought a good first step would be to create the IDL files. The first thing I noticed is that it and the Web SQL Database API [2] have quite a few conflicts in terms of their interface names. I'm

Re: [webkit-dev] IndexedDB API

2010-01-21 Thread Maciej Stachowiak
On Jan 21, 2010, at 9:53 PM, Jeremy Orlow wrote: A couple of us at Google are starting to look at implementing the IndexedDB API [1] in WebKit. We thought a good first step would be to create the IDL files. The first thing I noticed is that it and the Web SQL Database API [2] have quite