Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

Hi, > It's also a big help when peers (which aren't necessarily WebKit > reviewers) > look over it and give review-style feedback as well. Especially when said > peers know more about that code than any of the official reviewers. Is that really help? Sometimes when a patch looks good to me, it s

[webkit-dev] Questions regarding memory debugging

HI All, I'm currently running the iexploder tests on GtkLauncher and I'm observing a growth in memory usage of that process. I have used the GNOME memprof utilitiy to look at it and the best candidate for the "leak" is SharedBuffer::append which will allocate memory. Now SharedBuffer is refcou

Re: [webkit-dev] Leopard Release Builder offline

We're having hardware troubles with this machine. It might not *be* back for a bit. I apologize for the negative effect this has on commit-queue users, but it's out of our control at this point. ~Brady On Mar 9, 2010, at 7:27 PM, Eric Seidel wrote: > http://build.webkit.org/builders/Leopard%2

[webkit-dev] Leopard Release Builder offline

http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Tests%29/ Looks like the build slave is offline. Any Apple person able to kick the slave? -eric p.s. For any commit-queue users: Since the build was red when it went offline, the commit-queue will be blocked until it's back. http:/

Re: [webkit-dev] WebKitGTK+ on Snow Leopard

Hi, > Has someone actually been able to compile WebKitGTK+ on Snow Leopard?  I have > retrieved all the dependancies via Mac > ports and fink and always seem to get hung up on libjpeg where the compiles > believes the library is missing when it is > not. This is not the right mailing list for

Re: [webkit-dev] JavaScriptCore and the V8 debugger protocol

Hey Jamey, Thanks for the links and explanation. I am still incredibly new to the codebase, but it looks like you have done much of what I need. However, I am only using the JavaScriptCore portion of Webkit. I am under the impression the changes you made require WebCore to perform the remote d

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

On Tue, Mar 9, 2010 at 11:45 AM, Adam Barth wrote: > Q: Why are you doing this? You should stick to reviewing code in your own > area. > A: The pending-review queue is out of control. It's past the tipping > point where there are too many patches for someone to reasonably look > at the queue.

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

On Tue, Mar 9, 2010 at 9:39 PM, David Levin wrote: > >> (3) Someone reviewed an earlier version of the patch but then didn't >> follow up. I think having a partial review by one person encourages >> other people to assume that person will finish the review. That cause >> the patch to float upw

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

> > > (3) Someone reviewed an earlier version of the patch but then didn't > follow up. I think having a partial review by one person encourages > other people to assume that person will finish the review. That cause > the patch to float upwards in pending-review until it gets lost in the > sea

Re: [webkit-dev] Announcing a WebKit Contributors Meeting on April 12 and 13 at Apple's campus in Cupertino, CA

On Mar 9, 2010, at 1:14 PM, Adam Roben wrote: > On Mar 9, 2010, at 4:05 PM, Eric Seidel wrote: > >> Is there any way to see who has registered? Or is that something >> we'll need to make a wiki signup list for or similar? > > There isn't currently. Bill Siegrist (_wms) set up the page and knows

Re: [webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

On Mar 9, 2010, at 1:45 PM, Adam Barth wrote: > > (1) The patch needs to be reviewed by David Hyatt. David Hyatt > appears to be a bottleneck in the project because he's an expert on a > number of components that no one else understands as well but he > doesn't spend as much time reviewing pa

Re: [webkit-dev] Announcing a WebKit Contributors Meeting on April 12 and 13 at Apple's campus in Cupertino, CA

On Mar 9, 2010, at 4:05 PM, Eric Seidel wrote: Is there any way to see who has registered? Or is that something we'll need to make a wiki signup list for or similar? There isn't currently. Bill Siegrist (_wms) set up the page and knows the details of how hard that would be to do. -Adam

Re: [webkit-dev] Announcing a WebKit Contributors Meeting on April 12 and 13 at Apple's campus in Cupertino, CA

Is there any way to see who has registered? Or is that something we'll need to make a wiki signup list for or similar? Thanks! -eric On Tue, Mar 9, 2010 at 12:52 PM, Adam Roben wrote: > Hi all- > > Apple will be hosting a WebKit Contributors Meeting at its campus in > Cupertino, CA on Monday,

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On 09.03.2010, at 12:37, Drew Wilson wrote: This gives us lots of places to hook. scheduleDispatchFunctionsFromMainThread() could be a no-op on the mac, if we just always invoke dispatchFunctionsFromMainThread() at a specified point in the loop (e.g. kCFRunLoopBeforeWaiting). Something

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

Yeah, that seems to be the least invasive. And we're already confident that creating a zero-delay timer won't cause event source starvation, since that's how postTask() used to work. -atw On Tue, Mar 9, 2010 at 12:53 PM, Dmitry Titov wrote: > I've tried to post a timer if the scheduleDispatchF

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

I've tried to post a timer if the scheduleDispatchFunctionsFromMainThread comes on main thread - this fixes the test and it is a minimal change. Drew, let me know if you want to dig deeper in CFRunLoopObserver, otherwise I could whip up a patch (post a timer from main thread + postTask change from

[webkit-dev] Announcing a WebKit Contributors Meeting on April 12 and 13 at Apple's campus in Cupertino, CA

Hi all- Apple will be hosting a WebKit Contributors Meeting at its campus in Cupertino, CA on Monday, April 12 and Tuesday, April 13 from 9am to 6pm PDT. The meeting is targeted at contributors to the WebKit Open Source Project. The meeting will have an "unconference"-like format, allowin

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

That's a great idea: http://developer.apple.com/Mac/library/documentation/CoreFoundation/Reference/CFRunLoopObserverRef/Reference/reference.html#//apple_ref/c/tdef/CFRunLoopActivity

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On 09.03.2010, at 11:51, Drew Wilson wrote: That actually is an interesting idea - perhaps we could implement scheduleDispatchFunctionsFromMainThread() using a 0-delay timer in the case where it's called from the main thread... As an unsubstantiated idea, we could also consider using a run

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On Tue, Mar 9, 2010 at 11:34 AM, Dmitry Titov wrote: > On Tue, Mar 9, 2010 at 11:13 AM, Alexey Proskuryakov wrote: > >> >> On 09.03.2010, at 9:45, Drew Wilson wrote: >> >> Yeah, it's a race condition - it seems to all depend on whether the >>> worker resource gets loaded before the postMessage l

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On 09.03.2010, at 11:23, Michael Nordman wrote: 1) We feel the need to change how Document::postTask() behaves, because otherwise, the patch for doesn't work. We feel the need because it makes little sense for it to have drastically different

[webkit-dev] Why I'm reviewing patches outside my area (and why you should too)

Over the past 24 hours, I've been aggressively reviewing patches in pending-review that have been sitting around for over a month. My approach as been to review the patches in order from oldest to newest with a "the buck stops here" perspective. That means I'm g

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On Tue, Mar 9, 2010 at 11:13 AM, Alexey Proskuryakov wrote: > > On 09.03.2010, at 9:45, Drew Wilson wrote: > > Yeah, it's a race condition - it seems to all depend on whether the worker >> resource gets loaded before the postMessage loop starts. Failure rate is >> around 30-50% on my machine. >>

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On Tue, Mar 9, 2010 at 11:13 AM, Alexey Proskuryakov wrote: > > On 09.03.2010, at 9:45, Drew Wilson wrote: > > Yeah, it's a race condition - it seems to all depend on whether the worker >> resource gets loaded before the postMessage loop starts. Failure rate is >> around 30-50% on my machine. >>

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

On 09.03.2010, at 9:45, Drew Wilson wrote: Yeah, it's a race condition - it seems to all depend on whether the worker resource gets loaded before the postMessage loop starts. Failure rate is around 30-50% on my machine. It would help to have a more detailed description of the problem. I've

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

Another alternative is for us to add a flag to scheduleDispatchFunctionsOnMainThread() which is passed as true in the case where we are calling it from dispatchFunctionsOnMainThread(): // If we are running accumulated functions for too long so UI may become unresponsive, we need to

Re: [webkit-dev] WTF::callOnMainThread() and re-entrancy

Yeah, it's a race condition - it seems to all depend on whether the worker resource gets loaded before the postMessage loop starts. Failure rate is around 30-50% on my machine. It looks like events have priority in Cocoa, and I'm guessing that performSelectorOnMainThread() creates events with a hi

Re: [webkit-dev] CookieJar needs client interface?

On Tue, Mar 9, 2010 at 8:21 AM, Mike Marchywka wrote: > I wrote one from scratch but tried to document sources of wisdom > such as any standards used or "this is what wget/curl left in their > cookie files" or "this dosn't work on foo" etc. I'm glad someone > else thinks this is "subtle." That is

Re: [webkit-dev] CookieJar needs client interface?

> From: aba...@webkit.org > Date: Tue, 9 Mar 2010 06:54:32 -0800 > To: supersti...@gmx.de > CC: webkit-dev@lists.webkit.org > Subject: Re: [webkit-dev] CookieJar needs client interface? > > Implementing cookies is surprisingly subtle, mostly because

Re: [webkit-dev] CookieJar needs client interface?

Implementing cookies is surprisingly subtle, mostly because the protocol is quite brittle. If you're implementing your own cookie store, a decent starting point might be to look at: http://src.chromium.org/viewvc/chrome/trunk/src/net/base/cookie_monster.cc?view=markup http://tools.ietf.org/html/d

Re: [webkit-dev] Objective-C Plug-in for Linux

Sorry for the dumb question. i found my answer further below in the "What Kind Of Plug-in Should I Develop?". On Tue, Mar 9, 2010 at 4:55 AM, Christopher White wrote: > From: > > > http://developer.apple.com/mac/library/documentation/InternetWeb/Conceptual/WebKit_PluginProgTopic/Concepts/AboutPlu

Re: [webkit-dev] JavaScriptCore and the V8 debugger protocol

Hi Jonathan, I've been working on remote debugging/profiling of webkit and I've been leveraging work that the webkit and chromium guys did to separate the Web Inspector frontend from backend. I was actually thinking about sending email to the list this morning about agreeing on a remote/on-dev

[webkit-dev] WebKitGTK+ on Snow Leopard

Has someone actually been able to compile WebKitGTK+ on Snow Leopard? I have retrieved all the dependancies via Mac ports and fink and always seem to get hung up on libjpeg where the compiles believes the library is missing when it is not. Cheers, Chris __

[webkit-dev] Objective-C Plug-in for Linux

From: http://developer.apple.com/mac/library/documentation/InternetWeb/Conceptual/WebKit_PluginProgTopic/Concepts/AboutPlugins.html#//apple_ref/doc/uid/30001248-BAJGJJAH It states that "Although the API is not cross-platform, any plug-in created in this fashion can be used in Safari and all other

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

On Tue, Mar 9, 2010 at 9:19 AM, Robert O'Callahan wrote: > > Mozilla has been using this technique for years. Perhaps we can pick their >> brains for some good tricks. Or, dare I say it, share some tests. >> >> >> > Hi, hope I'm not crashing the party, and sorry I'm late :-). Let me just > say a f

[webkit-dev] CookieJar needs client interface?

Hi all, I am currently implementing the cookie jar backend for the Haiku port and browser. Looking at the other implementations, most of them do it in their network platform code, many are still incomplete. Isn't handling of cookies something browser specific? Looking at the Qt port, it seems l

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

> Mozilla has been using this technique for years. Perhaps we can pick their > brains for some good tricks. Or, dare I say it, share some tests. > > Hi, hope I'm not crashing the party, and sorry I'm late :-). Let me just say a few things about reftests... Maciej mentioned that a reftest can asser