Re: [webkit-dev] "jsc -d" does not dump bytecode in debug builds

2010-05-13 Thread Oliver Hunt
What's your testcase? One potential issue you could be seeing is that we don't dump the bytecode until we compile code so the code for a function won't be dumped until you call it for instance, but you should at the very least be getting an bc dump for the containing global code. --Oliver On

[webkit-dev] "jsc -d" does not dump bytecode in debug builds

2010-05-13 Thread Auro Tripathy
What gives? The documentation says, Usage: jsc [options] [files] [-- arguments]   -d Dumps bytecode (debug builds only)   -e Evaluate argument as script code   -f Specifies a source file (deprecated)   -h|--help  Prints this help message   -i Enables interactive

Re: [webkit-dev] webkit-patch, check-webkit-style and git now support --squash and --git-commit

2010-05-13 Thread Chris Jerdonek
On Thu, May 13, 2010 at 11:13 AM, Ojan Vafai wrote: > I finally updated this > page http://trac.webkit.org/wiki/UsingGitWithWebKit#webkit-patchcheck-webkit-styleandgit. > As is clear from that, my earlier description of --no-squash was totally > inaccurate. Sorry, I was being rushed. --no-squash a

Re: [webkit-dev] webkit-patch, check-webkit-style and git now support --squash and --git-commit

2010-05-13 Thread Ojan Vafai
I finally updated this page http://trac.webkit.org/wiki/UsingGitWithWebKit#webkit-patchcheck-webkit-styleandgit . As is clear from that, my earlier description of --no-squash was totally inaccurate. Sorry, I was being rushed. --no-squash and --git-commit still need significant work before they wil

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Alexey Proskuryakov
13.05.2010, в 10:19, David Levin написал(а): Should we just r- and ask that it wait for "conceptual issues to be resolved in IETF spec review first" (unless for some reason it is needed quickly and that takes too long)? I am not aware of any specific conceptual issues, just the fact that

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Adam Roben
On May 13, 2010, at 12:12 PM, Adam Barth wrote: > * 34953: Implement DEFINE_STUB_FUNCTION for WinCE I think this bug (and bug 36050, which it depends on) should be reviewed by Gavin Barraclough. -Adam ___ webkit-dev mailing list webkit-dev@lists.webk

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread David Levin
On Thu, May 13, 2010 at 10:15 AM, Alexey Proskuryakov wrote: > > 13.05.2010, в 9:41, David Levin написал(а): > > > * 35573: WebSocket add new event: CloseEvent >> >> I think ap is much more familiar with WebSockets -- though I am willing to >> look if needed. >> > > Anyone can review this patch

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Alexey Proskuryakov
13.05.2010, в 9:41, David Levin написал(а): * 35573: WebSocket add new event: CloseEvent I think ap is much more familiar with WebSockets -- though I am willing to look if needed. Anyone can review this patch - the key to reviewing is to decide whether a "close event" actually makes sens

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Jeremy Orlow
On Thu, May 13, 2010 at 5:41 PM, David Levin wrote: > > > On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > >> One of the least fun things in the project is to pour a bunch of >> effort into writing a patch only to see it sit forever waiting for >> review. In the past, I've tried to single-h

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread David Levin
On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > One of the least fun things in the project is to pour a bunch of > effort into writing a patch only to see it sit forever waiting for > review. In the past, I've tried to single-handedly tackle the patches > that have been up for review for mo

Re: [webkit-dev] Python on the Tiger build bot

2010-05-13 Thread Alexey Proskuryakov
13.05.2010, в 06:15, Eric Seidel написал(а): > That error looks like its trying to use python < 2.5. > > Skipping the websocket tests on Tiger (manually at least) is bad. > Would be better to do it based on detected python. Filed: > https://bugs.webkit.org/show_bug.cgi?id=39058 > about doing ju

[webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Adam Barth
One of the least fun things in the project is to pour a bunch of effort into writing a patch only to see it sit forever waiting for review. In the past, I've tried to single-handedly tackle the patches that have been up for review for more than a month. That approach is less than ideal because (1

Re: [webkit-dev] Python on the Tiger build bot

2010-05-13 Thread Eric Seidel
That error looks like its trying to use python < 2.5. Skipping the websocket tests on Tiger (manually at least) is bad. Would be better to do it based on detected python. Filed: https://bugs.webkit.org/show_bug.cgi?id=39058 about doing just that. -eric On Thu, May 13, 2010 at 2:14 AM, Fumitoshi

Re: [webkit-dev] Python on the Tiger build bot

2010-05-13 Thread 鵜飼文敏
I heard on #webkit that the Tiger bot has been on Python 2.5 for some time, and found r+ for https://bugs.webkit.org/show_bug.cgi?id=38886 and https://bugs.webkit.org/show_bug.cgi?id=38822. I believe we have consensus to use Python 2.5 (or later) for webkit development environment. I tried to land