Re: [webkit-dev] Enabling the HTML5 tree builder soon

2010-07-29 Thread Stephanie Lewis
No change in iBench. -- Stephanie On Jul 28, 2010, at 8:15 PM, Stephanie Lewis wrote: > I believe it is somewhere, but the setup is a hassle, so I'll run it tomorrow > for you. > > -- Stephanie > > On Jul 28, 2010, at 8:13 PM, Adam Barth wrote: > >> On Wed, Jul 28, 2010 at 7:39 AM, Maciej St

Re: [webkit-dev] focusin/focusout events

2010-07-29 Thread Ojan Vafai
On Tue, Jul 27, 2010 at 10:37 AM, Darin Adler wrote: > This sequence doesn’t sound too terrible to me. But I don’t fully >> understand the proposal. At the time the focusin event fires we won’t yet >> know what item is getting focus? >> > > I think we do know this and it wouldn't be too hard to

Re: [webkit-dev] Sharing WebKit mocks across platforms

2010-07-29 Thread Adam Barth
WebCore::LayoutTestController would be exposed to JavaScript running in LayoutTests directly (like the DOM), so we can skip the type conversions. Adam On Thu, Jul 29, 2010 at 9:20 AM, Satish Sampath wrote: > With a WebCore::LayoutTestController, would there be a need for code in > WebKit to con

Re: [webkit-dev] Handling IME composition events

2010-07-29 Thread Ojan Vafai
On Thu, Jul 29, 2010 at 9:18 AM, Joone Hur wrote: > On Thu, Jul 29, 2010 at 3:13 AM, Oliver Hunt wrote: > > On Jul 28, 2010, at 8:45 AM, Joone Hur wrote: > >> 3) Keyboard events should not be dispatched during a composition. > > Key events must be sent while an IME is active otherwise sites bre

Re: [webkit-dev] Name nitpick: "layout tests"

2010-07-29 Thread Kenneth Christiansen
I'm fine with it as well; the name confuses a lot of new contributors. Kenneth On Thu, Jul 29, 2010 at 3:15 PM, Dirk Pranke wrote: > On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler wrote: >> Hi folks. >> >> WebKit regression tests are in a directory named LayoutTests. The object the >> tests use

Re: [webkit-dev] Name nitpick: "layout tests"

2010-07-29 Thread Dirk Pranke
On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler wrote: > Hi folks. > > WebKit regression tests are in a directory named LayoutTests. The object the > tests uses to do special test-specific operations is "layoutTestController". > Both of these names are unwanted baggage, left over from when the tes

Re: [webkit-dev] Name nitpick: "layout tests"

2010-07-29 Thread Darin Adler
On Jul 29, 2010, at 11:09 AM, Ryosuke Niwa wrote: > But I'm not sure if converting all the existing tests is feasible or worth > the effort. Is there any practical problem other than being semantically > "wrong"? This is not something we have to decide up front. Converting the existing tests i

Re: [webkit-dev] Name nitpick: "layout tests"

2010-07-29 Thread Ryosuke Niwa
On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler wrote: > The directory should be eventually be named Tests or WebKitTests or > RegressionTests. Eric Seidel can probably remember talking this over with me > the day after we added the LayoutTests directory; sorry that I never fixed > it! > This soun

[webkit-dev] Name nitpick: "layout tests"

2010-07-29 Thread Darin Adler
Hi folks. WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is "layoutTestController". Both of these names are unwanted baggage, left over from when the test machinery was only good for testing layout. The directory s

Re: [webkit-dev] Sharing WebKit mocks across platforms

2010-07-29 Thread Satish Sampath
With a WebCore::LayoutTestController, would there be a need for code in WebKit to convert the call parameters from WebKit types (which DRT uses) to WebCore types (which the mocks may use) ? If yes seems like we need wrappers to proxy the mock calls anyway on different platforms.. Cheers Satish On

Re: [webkit-dev] Handling IME composition events

2010-07-29 Thread Joone Hur
On Thu, Jul 29, 2010 at 3:13 AM, Oliver Hunt wrote: > > On Jul 28, 2010, at 8:45 AM, Joone Hur wrote: > >> 3) Keyboard events should not be dispatched during a composition. > Key events must be sent while an IME is active otherwise sites break.  IIRC > you get keydown and keyup events, but not ke

Re: [webkit-dev] Sharing WebKit mocks across platforms

2010-07-29 Thread Adam Barth
Thanks for bring this question to the list. I don't have a strong opinion here, but I want to make sure we think project-wide and pick something scalable. This discussion is also related to the discussion about adding something like a layoutTestController object to WebCore. Plumbing this mock AP