Re: [webkit-dev] Testing XHR
I don't think that the suite is testing much besides what we already have regression tests for. For the most part, it just has different expectations. There doesn't seem to be any harm in importing it as a whole now, but looking over the failing tests, categorizing them and sending feedback to public-webapps working groups is more important at this point. Jian Li from Chromium team is currently filing bugs for tests that fail in WebKit. - WBR, Alexey Proskuryakov 20.09.2010, в 22:34, Ojan Vafai написал(а): Filed https://bugs.webkit.org/show_bug.cgi?id=46164 for the script to pull the tests into our repo. On Tue, Sep 21, 2010 at 3:27 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 20, 2010, at 10:19 PM, Ojan Vafai wrote: How about we create http/tests/xmlhttprequest/w3c-experimental or something like that? That can tide us over until the official version comes out, at which point, we can delete the w3c-experimental directory and just add a w3c directory. It would be nice if we could start fixing these things before they become part of the official test suite as a way of evaluating whether there are issues with the spec and/or test suite. That is in fact exactly what we should be doing at this stage of the standards process for XHR. Also, it seems to me like to does make sense to add an update-experimental-w3c-xhr-tests script or something until there is an official version. Indeed. And even after the test suite is official, it is likely to expand over time. We should also look over our own XHR tests to see if there are any that it would make sense to contribute to the W3C. Cheers, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Ruby Text Enhancements
Great to see someone else interested in doing ruby implementation! :) I did the original ruby implementation, so I'm very happy to help with any questions/problems/issues (bugs? there are not bugs!). BTW, please note that there is another ruby patch in the review pipeline: https://bugs.webkit.org/show_bug.cgi?id=41040 (had to modify and re-submit this one after in-flight clashes with another patch) that might affect the implementation. On Tue, Sep 21, 2010 at 3:12 AM, David Hyatt hy...@apple.com wrote: On Sep 17, 2010, at 8:07 PM, Eric Mader wrote: Hi, I'm working on making the following enhancements to Ruby Text: 1) Implement the behavior of ruby-overhang:auto Oh vey, that's ambituous! :) There's so many corner cases I foresee on this one that I was just too happy to postpone it when we originally discussed to leave out CSS3 ruby stuff from the initial implementation, which is purely based off HTML5 - including supporting multiple base/text pairs within a single ruby, and line-breaking within the ruby. 2) implement the behavior of ruby-line-stacking:exclude-ruby Which way do you intend to implement this? AFAICT the current consensus seems to go towards having ruby included by default rather than excluded. 3) Add some Mac OS specific character properties to the ruby text 4) Turn off the underline when the ruby text is in a link I've looked at the code enough to know that the layout or ruby text is done by the normal block stacking in BlockLayout. I'm guessing that I can do at lest the first two tasks by changing the RenderRuby code to report a different width and / or height for the ruby block. Does this seem like the right way to do what I want? Assuming for the moment that it is, I have some questions: 1) What methods should I subclass to report the adjusted width and height? I'm very hazy on the Ruby implementation. I believe it makes an inline-block with two block children vertically stacked, and then it uses text-align:center to center the ruby base. If so, this behavior has to be preserved when the ruby text is wider than the base. Yes, that's the basic layout for a single ruby text/base pair. Note that multiple such pairs may be contained within a single ruby element (which is normally an inline element, unless it's floated or positioned). A ruby may also include renderers for :before and :after content, which are outside of the inline-blocks for base/text pairs. This is implemented in the aforementioned patch for 41040, which also fixes some issues with RenderRubyAsBlock and supersedes the patch for 43722). I think a reasonable way to implement overhang therefore would be with negative margins applied to the ruby run. This way the correct layout of the Ruby object is preserved, and the surrounding text will just naturally get pushed inside the Ruby object to overlap it. Basically you can compare the delta in width between the base and the text and then apply margins to either side of the ruby run based off how you want to overhang. That's also what I'd suggest. However, there are the following additional things to consider: .) The margin on the left side may need to be reduced because of line start (setting it to 0), or neighboring elements that reduce how much it can overhand (larger text or other element, a neighboring ruby element, etc.). .) The same goes for the right margin - however, this one is vastly more tricky, since the following elements are probably not yet layouted. Depending on what follows (text you can overhang, stuff that turns out you can't overhang, the line end) you might need to increase the projected width of the whole ruby run, which in turn might push out following elements. There might even be extreme cases where ruby text overhangs multiple following objects if those are very small. You also need to be careful caching any values inside used for this inside the ruby, because whether a ruby text may/may not overhang (or by how much) may change dependent on changes inside _neighboring_ elements. Also, please note that currently the size of rt is set at 60% of the base, which is different from the standard 50%. This was chosen because it improves readability on (low dpi) screens. If you implement ruby overhang properly, esp. for the purposes of CJK rendering (see http://www.w3.org/TR/2009/NOTE-jlreq-20090604/#en-subheading2_3_3), you may want/need to reconsider this, or adjust your implementation to take the difference into consideration. 2) If the ruby text is wider than the ruby base and I report the width of the base as the width of the whole block will some of the ruby text get clipped, or will it all still draw? It would all still draw as long as you set up overflow correctly. You can look for addLayoutOverflow methods. I think you may be able to use negative margins for overhang though without altering your reported width. 3) Ruby text is only allowed to overhang the base in
Re: [webkit-dev] Testing XHR
Yes, I have just gone through all the tests in this suite and categorized and filed some WebKit bugs. Some other test failures seem to be due to something wrong with tests themselves. I am pinging Anne about these issues. Thanks, Jian On Mon, Sep 20, 2010 at 11:43 PM, Alexey Proskuryakov a...@webkit.org wrote: I don't think that the suite is testing much besides what we already have regression tests for. For the most part, it just has different expectations. There doesn't seem to be any harm in importing it as a whole now, but looking over the failing tests, categorizing them and sending feedback to public-webapps working groups is more important at this point. Jian Li from Chromium team is currently filing bugs for tests that fail in WebKit. - WBR, Alexey Proskuryakov 20.09.2010, в 22:34, Ojan Vafai написал(а): Filed https://bugs.webkit.org/show_bug.cgi?id=46164 for the script to pull the tests into our repo. On Tue, Sep 21, 2010 at 3:27 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 20, 2010, at 10:19 PM, Ojan Vafai wrote: How about we create http/tests/xmlhttprequest/w3c-experimental or something like that? That can tide us over until the official version comes out, at which point, we can delete the w3c-experimental directory and just add a w3c directory. It would be nice if we could start fixing these things before they become part of the official test suite as a way of evaluating whether there are issues with the spec and/or test suite. That is in fact exactly what we should be doing at this stage of the standards process for XHR. Also, it seems to me like to does make sense to add an update-experimental-w3c-xhr-tests script or something until there is an official version. Indeed. And even after the test suite is official, it is likely to expand over time. We should also look over our own XHR tests to see if there are any that it would make sense to contribute to the W3C. Cheers, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] testing
-- Regards Navigate Today For Better Tomorrow!!! mEeT mE LivE wItH tEcH cAkE @ http://hitechi.19.forumer.com/ http://go4expert.com/ http://www.liveperson.com/asadullah-ansari/ http://go4hitech.wordpress.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Testing XHR
On Tue, Sep 21, 2010 at 8:43 AM, Alexey Proskuryakov a...@webkit.org wrote: I don't think that the suite is testing much besides what we already have regression tests for. For the most part, it just has different expectations. FWIW, if you find cases the test suite is missing I'm happy to add them. The only reason the W3C is not hosting this test suite at the moment is because they cannot handle server-side scripts on the test server at the moment. PLH is looking into a solution on their side as I understand things. -- Anne van Kesteren http://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Ruby Text Enhancements
On Sep 21, 2010, at 2:52 AM, Roland Steiner wrote: We'd probably need to add a new value to that property if Ruby is supposed to be skipped. Ergh Looking at it, I'm not sure that's a good proposal at all - at least it has still lots to address (it doesn't address list bullets, or :before/:after generated content, for one). I think that the best approach for ruby would be to view the whole ruby run (i.e., base and text combined) as the main object for text-decoration, and not the base and text individually. That is: .) underline: line painted below the base only, over the width of base and text (but excluding any overhangs!) .) overline: overline painted above the text, same as above - note that the line width doesn't (!) change .) line-through: either just the base is decorated, or both base and text. I can see arguments for either way, although I think painting a line-through through the text may overly obscure it, since it's quite small - note that the line width for the ruby text would need to be different in this case as well, which in turn probably means amending the spec. .) blink: all blinks ;) This however means that a rule for rt would need to affect the ruby text separately, independent of the decoration of the whole thing (which IMHO would be a good thing anyway). Yeah the main point I was trying to make with text-decoration is that in the strict mode model it's the element with text-decoration on it that draws the line. So right now if you have: a[some ruby] /a It's the line boxes for the a element that draw a line, and it just cuts through the ruby no matter where the ruby happens to be (just as it might cut through any other objects like images that might have a different vertical alignment). We have no concept of making that line skip elements or do something different, so it's a fair bit of work to customize the behavior. Even more annoying is that text-decoration has two completely different code paths for quirks vs. strict mode. In quirks mode, the underlines are drawn by the elements themselves (so e.g., you get no underlines under images in quirks mode), and so customizing the line drawing behavior will be easier to do in quirks mode. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Ruby Text Enhancements
On Sep 20, 2010, at 9:52 PM, Roland Steiner wrote: Great to see someone else interested in doing ruby implementation! :) I did the original ruby implementation, so I'm very happy to help with any questions/problems/issues (bugs? there are not bugs!). BTW, please note that there is another ruby patch in the review pipeline: https://bugs.webkit.org/show_bug.cgi?id=41040 (had to modify and re-submit this one after in-flight clashes with another patch) that might affect the implementation. On Tue, Sep 21, 2010 at 3:12 AM, David Hyatt hy...@apple.com wrote: On Sep 17, 2010, at 8:07 PM, Eric Mader wrote: Hi, I'm working on making the following enhancements to Ruby Text: 1) Implement the behavior of ruby-overhang:auto Oh vey, that's ambituous! :) There's so many corner cases I foresee on this one that I was just too happy to postpone it when we originally discussed to leave out CSS3 ruby stuff from the initial implementation, which is purely based off HTML5 - including supporting multiple base/text pairs within a single ruby, and line-breaking within the ruby. Yes, it's a bit scary. ;-) I don't think I could implement the whole thing at once, so I'm looking at doing a partial implementation. Maybe the first round would only check to be sure that the neighboring blocks aren't ruby blocks. I'm looking at using a RenderOverflow object to implement this. Can you point me at any documentation for this class, other than what's in the code? I'm having some trouble sorting out what all the various rectangles used in conjunction with this object represent. 2) implement the behavior of ruby-line-stacking:exclude-ruby Which way do you intend to implement this? AFAICT the current consensus seems to go towards having ruby included by default rather than excluded. Well, the spec. says that exclude-ruby is the default. Looking at a few example sites, it seems that they don't use big enough inter-line spacing to accommodate ruby text, so changing the exclude-ruby as the default would result in the ruby overlapping the previous line, which is probably worse than the current state where the inter-line spacing isn't uniform. (using 60% as the default size for ruby text probably makes this a bit worse) As ruby implementations with the specified default implemented become more common, I expect that sites will be updated to use correct inter-line spacing and everyone will be happy. In the near-term, though, things will look worse if we implement the default... 3) Add some Mac OS specific character properties to the ruby text 4) Turn off the underline when the ruby text is in a link I've looked at the code enough to know that the layout or ruby text is done by the normal block stacking in BlockLayout. I'm guessing that I can do at lest the first two tasks by changing the RenderRuby code to report a different width and / or height for the ruby block. Does this seem like the right way to do what I want? Assuming for the moment that it is, I have some questions: 1) What methods should I subclass to report the adjusted width and height? I'm very hazy on the Ruby implementation. I believe it makes an inline-block with two block children vertically stacked, and then it uses text-align:center to center the ruby base. If so, this behavior has to be preserved when the ruby text is wider than the base. Yes, that's the basic layout for a single ruby text/base pair. Note that multiple such pairs may be contained within a single ruby element (which is normally an inline element, unless it's floated or positioned). A ruby may also include renderers for :before and :after content, which are outside of the inline-blocks for base/text pairs. This is implemented in the aforementioned patch for 41040, which also fixes some issues with RenderRubyAsBlock and supersedes the patch for 43722). I think a reasonable way to implement overhang therefore would be with negative margins applied to the ruby run. This way the correct layout of the Ruby object is preserved, and the surrounding text will just naturally get pushed inside the Ruby object to overlap it. Basically you can compare the delta in width between the base and the text and then apply margins to either side of the ruby run based off how you want to overhang. That's also what I'd suggest. However, there are the following additional things to consider: See my comments about RenderOverflow above. Is that the right way to go? Do I set the width of the ruby block to the width of the base text, or to the width of the ruby text and then give it the appropriate margins? About turning off the underline if the ruby is in a link: I've looked at the styles and tried adding code to change the parts that I think relate to this, but haven't found anything that makes a difference. It's also occurred to me that I might be able to do this by writing
Re: [webkit-dev] Ruby Text Enhancements
Hi Eric, comments inline: On Wed, Sep 22, 2010 at 6:57 AM, Eric Mader ema...@apple.com wrote: On Sep 20, 2010, at 9:52 PM, Roland Steiner wrote: Oh vey, that's ambituous! :) There's so many corner cases I foresee on this one that I was just too happy to postpone it when we originally discussed to leave out CSS3 ruby stuff from the initial implementation, which is purely based off HTML5 - including supporting multiple base/text pairs within a single ruby, and line-breaking within the ruby. Yes, it's a bit scary. ;-) I don't think I could implement the whole thing at once, so I'm looking at doing a partial implementation. Maybe the first round would only check to be sure that the neighboring blocks aren't ruby blocks. I would actually suggest cutting it down further and at first doing it only where the neighbor is plain text - this should still catch 90% of the cases where you'd want overhang and should vastly reduce the corner cases. You can verify and compute this rather easily when layouting the ruby, and you'd not need to worry about different glyph heights of neighboring inline elements, or about replaced elements interfering. Overhang would be basically be the minimum of: maximum overhang, or length of neighboring text run, or available/remaining space on the line. The latter factor may also cause you to need to break the ruby or move it to the next line altogether. I'm looking at using a RenderOverflow object to implement this. Can you point me at any documentation for this class, other than what's in the code? I'm having some trouble sorting out what all the various rectangles used in conjunction with this object represent. I have to say I'm not personally familiar with RenderOverflow, either (haven't used it with ruby). Just judging from the description it stores overflow rectangles for stuff that is actual content (layout overflow) and stuff that is pure cosmetic rendering, such as shadows or reflections (visual overflow). For ruby overhang you'd be looking at layout overflow in principle (unless the overhang text also has shadows and stuff, which may add to the visual overflow), AFAICT. But as I said, I'm not really an expert here. Cheers, - Roland ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
