date:20100923

Re: [webkit-dev] Disable sheriffbot bug posts?

2010-09-23 Thread Brian Weinstein

I filed  about this yesterday, 
that sherifbott should include a link to the failing bot output. I originally 
filed the bug with IRC in mind, but this is also true with the comments to bugs.

Brian

On Sep 23, 2010, at 1:43 PM, Mihai Parparita wrote:

> Perhaps if they included a link to the bot output (or at least the
> build permalink for that revision on that bot) they would be more
> useful (even if they're false positives, they could be checked and
> rejected that much faster).
> 
> Mihai
> 
> On Thu, Sep 23, 2010 at 1:36 PM, Adam Barth  wrote:
>> Hi webkit-dev,
>> 
>> Does anyone find the sheriffbot bug posts useful?  My sense is that
>> they're too noisy because of flaky tests and large blamelists.  I'm
>> inclined to turn them off unless someone else is finding them useful.
>> 
>> Thanks,
>> Adam
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Disable sheriffbot bug posts?

2010-09-23 Thread Geoffrey Garen

> Does anyone find the sheriffbot bug posts useful?  My sense is that
> they're too noisy because of flaky tests and large blamelists.  I'm
> inclined to turn them off unless someone else is finding them useful.

FWIW, they've helped me on occasion and spammed me on occasion.

Typically, I don't mind the spam too much because it comes after the last 
meaningful post in the bug, so it doesn't take too much cognitive load to 
ignore it when necessary.

Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Disable sheriffbot bug posts?

2010-09-23 Thread Darin Adler

On Sep 23, 2010, at 1:36 PM, Adam Barth wrote:

> Does anyone find the sheriffbot bug posts useful?

I do.

> My sense is that they're too noisy because of flaky tests and large 
> blamelists.

I agree that they are, but they are also the only thing that leads me to the 
waterfall and console.

Hard to know what to do based on that!

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Disable sheriffbot bug posts?

2010-09-23 Thread Eric Seidel

I agree they could be very useful.  But right now, especially with so
many flaky tests in the tree, they're just spam.

I'd like to fix them and turn them back on, but I see no reason to
keep them spamming as is.

On Thu, Sep 23, 2010 at 1:43 PM, Mihai Parparita  wrote:
> Perhaps if they included a link to the bot output (or at least the
> build permalink for that revision on that bot) they would be more
> useful (even if they're false positives, they could be checked and
> rejected that much faster).
>
> Mihai
>
> On Thu, Sep 23, 2010 at 1:36 PM, Adam Barth  wrote:
>> Hi webkit-dev,
>>
>> Does anyone find the sheriffbot bug posts useful?  My sense is that
>> they're too noisy because of flaky tests and large blamelists.  I'm
>> inclined to turn them off unless someone else is finding them useful.
>>
>> Thanks,
>> Adam
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Disable sheriffbot bug posts?

2010-09-23 Thread Mihai Parparita

Perhaps if they included a link to the bot output (or at least the
build permalink for that revision on that bot) they would be more
useful (even if they're false positives, they could be checked and
rejected that much faster).

Mihai

On Thu, Sep 23, 2010 at 1:36 PM, Adam Barth  wrote:
> Hi webkit-dev,
>
> Does anyone find the sheriffbot bug posts useful?  My sense is that
> they're too noisy because of flaky tests and large blamelists.  I'm
> inclined to turn them off unless someone else is finding them useful.
>
> Thanks,
> Adam
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Disable sheriffbot bug posts?

2010-09-23 Thread Adam Barth

Hi webkit-dev,

Does anyone find the sheriffbot bug posts useful?  My sense is that
they're too noisy because of flaky tests and large blamelists.  I'm
inclined to turn them off unless someone else is finding them useful.

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] [webkit-changes] [68146] trunk/WebCore

2010-09-23 Thread Alexey Proskuryakov


23.09.2010, в 11:40, Luiz Agostini написал(а):

> This code is not used yet, I just aded it yesterday and plan to use it soon. 
> The assertion, that I have introduced, was wrong because the case callType == 
> CallTypeNone must be handled.
> 
> It is not about correcting existing problems because I just introduced this 
> code. It will not cause any regressions because the code that will use it did 
> not land yet, it is in review process. 

Yes, I understand that this didn't break any behavior in ToT.

My question was somewhat different. If you landed the code that uses 
ScriptCallback without fixing this mistake, would that have made any existing 
regression tests break? We just need test coverage for the fix, and hopefully 
existing tests provide it.

> I am sorry if I made you spend your time. Next time please contact me, it is 
> easy to find me. I have been working actively in webkit for a while, I am 
> always in iRC (lca), my name, email and IRC user can be found in 
> http://trac.webkit.org/wiki/WebKit%20Team and I am willing to help, answer, 
> change or whatever is needed. And of course I would reply to any comment in 
> the bug.

I'm sorry if this came across as an attack on you. My goal was to encourage 
reviewers to ensure that patches have adequate documentation and test coverage, 
and that's why I chose to bring this up on the list.

In earlier years of the project, we often said that it's the reviewer who is 
responsible for any problems with a landed patch. But thinking about it, this 
hasn't been the theme lately, for better or worse.

- WBR, Alexey Proskuryakov

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] [webkit-changes] [68146] trunk/WebCore

2010-09-23 Thread Luiz Agostini

Sorry. I should really have made better comments.

This code is not used yet, I just aded it yesterday and plan to use it soon.
The assertion, that I have introduced, was wrong because the case callType
== CallTypeNone must be handled.

It is not about correcting existing problems because I just introduced this
code. It will not cause any regressions because the code that will use it
did not land yet, it is in review process.

I am sorry if I made you spend your time. Next time please contact me, it is
easy to find me. I have been working actively in webkit for a while, I am
always in iRC (lca), my name, email and IRC user can be found in
http://trac.webkit.org/wiki/WebKit%20Team and I am willing to help, answer,
change or whatever is needed. And of course I would reply to any comment in
the bug.

Luiz

2010/9/23 Alexey Proskuryakov 

>
> It is unfortunate that this fix changes unused code. Will it be covered by
> existing layout tests when ScriptFunctionCall and ScriptCallback start being
> used?
>
> The patch and bug were highly confusing. Without any explanation of why
> this assertion was wrong, a test case, or an explanation of why one can't be
> made, I had to spend considerable time figuring out why it shouldn't be
> rolled out immediately.
>
> - WBR, Alexey Proskuryakov
>
> Начало переадресованного сообщения:
>
> *От: *commit-qu...@webkit.org
> *Дата: *23 сентября 2010 г. 8:57:01 Тихоокеанское летнее время
> *Кому: *webkit-chan...@lists.webkit.org
> *Тема: **[webkit-changes] [68146] trunk/WebCore*
>
>   Revision 68146 
> Author commit-qu...@webkit.org Date 2010-09-23 08:56:59 -0700 (Thu, 23 Sep
> 2010) Log Message
>
> 2010-09-23  Luiz Agostini  
>
> Reviewed by Andreas Kling.
>
> Invalid assertion in ScriptCallback
> https://bugs.webkit.org/show_bug.cgi?id=46348
>
> Removing invalid ASSERT from method ScriptCallback::call().
>
> * bindings/js/ScriptFunctionCall.cpp:
> (WebCore::ScriptCallback::call):
>
> Modified Paths
>
>- trunk/WebCore/ChangeLog
>- trunk/WebCore/bindings/js/ScriptFunctionCall.cpp
>
>  Diff
> Modified: trunk/WebCore/ChangeLog (68145 => 68146)
>
> --- trunk/WebCore/ChangeLog   2010-09-23 15:51:41 UTC (rev 68145)
> +++ trunk/WebCore/ChangeLog   2010-09-23 15:56:59 UTC (rev 68146)@@ -1,3 
> +1,15 @@+2010-09-23  Luiz Agostini  
> +
> +Reviewed by Andreas Kling.
> +
> +Invalid assertion in ScriptCallback
> +https://bugs.webkit.org/show_bug.cgi?id=46348
> +
> +Removing invalid ASSERT from method ScriptCallback::call().
> +
> +* bindings/js/ScriptFunctionCall.cpp:
> +(WebCore::ScriptCallback::call):
> + 2010-09-23  Martin RobinsonReviewed by 
> Ariya Hidayat.
>
>  Modified: trunk/WebCore/bindings/js/ScriptFunctionCall.cpp (68145 =>
> 68146)
>
> --- trunk/WebCore/bindings/js/ScriptFunctionCall.cpp  2010-09-23 15:51:41 UTC 
> (rev 68145)
> +++ trunk/WebCore/bindings/js/ScriptFunctionCall.cpp  2010-09-23 15:56:59 UTC 
> (rev 68146)@@ -215,9 +215,9 @@  CallData callData; CallType callType 
> = getCallData(m_function.jsValue(), callData);+if (callType == 
> CallTypeNone)
> +return ScriptValue(); -ASSERT(callType != CallTypeNone);
> - JSValue result = JSC::call(m_exec, m_function.jsValue(), callType, 
> callData, m_function.jsValue(), m_arguments); hadException = 
> m_exec->hadException();
>
>   ___
> webkit-changes mailing list
> webkit-chan...@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
>
>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Fwd: [webkit-changes] [68146] trunk/WebCore

2010-09-23 Thread Antonio Gomes

Find some details here: https://bugs.webkit.org/show_bug.cgi?id=37205
, specially https://bugs.webkit.org/show_bug.cgi?id=43216#c15 .and
followup comments.

Bug and changelog in bug 46348 are poor, though, I agree.

On Thu, Sep 23, 2010 at 2:03 PM, Alexey Proskuryakov  wrote:
>
> It is unfortunate that this fix changes unused code. Will it be covered by
> existing layout tests when ScriptFunctionCall and ScriptCallback start being
> used?
> The patch and bug were highly confusing. Without any explanation of why this
> assertion was wrong, a test case, or an explanation of why one can't be
> made, I had to spend considerable time figuring out why it shouldn't be
> rolled out immediately.
> - WBR, Alexey Proskuryakov
> Начало переадресованного сообщения:
>
> От: commit-qu...@webkit.org
> Дата: 23 сентября 2010 г. 8:57:01 Тихоокеанское летнее время
> Кому: webkit-chan...@lists.webkit.org
> Тема: [webkit-changes] [68146] trunk/WebCore
>
> Revision 68146 Author commit-qu...@webkit.org Date 2010-09-23 08:56:59 -0700
> (Thu, 23 Sep 2010)
>
> Log Message
>
> 2010-09-23  Luiz Agostini  
>
> Reviewed by Andreas Kling.
>
> Invalid assertion in ScriptCallback
> https://bugs.webkit.org/show_bug.cgi?id=46348
>
> Removing invalid ASSERT from method ScriptCallback::call().
>
> * bindings/js/ScriptFunctionCall.cpp:
> (WebCore::ScriptCallback::call):
>
> Modified Paths
>
> trunk/WebCore/ChangeLog
> trunk/WebCore/bindings/js/ScriptFunctionCall.cpp
>
> Diff
>
> Modified: trunk/WebCore/ChangeLog (68145 => 68146)
>
> --- trunk/WebCore/ChangeLog   2010-09-23 15:51:41 UTC (rev 68145)
> +++ trunk/WebCore/ChangeLog   2010-09-23 15:56:59 UTC (rev 68146)
> @@ -1,3 +1,15 @@
> +2010-09-23  Luiz Agostini  
> +
> +Reviewed by Andreas Kling.
> +
> +Invalid assertion in ScriptCallback
> +https://bugs.webkit.org/show_bug.cgi?id=46348
> +
> +Removing invalid ASSERT from method ScriptCallback::call().
> +
> +* bindings/js/ScriptFunctionCall.cpp:
> +(WebCore::ScriptCallback::call):
> +
>  2010-09-23  Martin Robinson  
>
>  Reviewed by Ariya Hidayat.
>
> Modified: trunk/WebCore/bindings/js/ScriptFunctionCall.cpp (68145 => 68146)
>
> --- trunk/WebCore/bindings/js/ScriptFunctionCall.cpp  2010-09-23 15:51:41 UTC
> (rev 68145)
> +++ trunk/WebCore/bindings/js/ScriptFunctionCall.cpp  2010-09-23 15:56:59 UTC
> (rev 68146)
> @@ -215,9 +215,9 @@
>
>  CallData callData;
>  CallType callType = getCallData(m_function.jsValue(), callData);
> +if (callType == CallTypeNone)
> +return ScriptValue();
>
> -ASSERT(callType != CallTypeNone);
> -
>  JSValue result = JSC::call(m_exec, m_function.jsValue(), callType,
> callData, m_function.jsValue(), m_arguments);
>  hadException = m_exec->hadException();
>
>
> ___
> webkit-changes mailing list
> webkit-chan...@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>



-- 
--Antonio Gomes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Fwd: [webkit-changes] [68146] trunk/WebCore

2010-09-23 Thread Alexey Proskuryakov


It is unfortunate that this fix changes unused code. Will it be covered by 
existing layout tests when ScriptFunctionCall and ScriptCallback start being 
used?

The patch and bug were highly confusing. Without any explanation of why this 
assertion was wrong, a test case, or an explanation of why one can't be made, I 
had to spend considerable time figuring out why it shouldn't be rolled out 
immediately.

- WBR, Alexey Proskuryakov

Начало переадресованного сообщения:

> От: commit-qu...@webkit.org
> Дата: 23 сентября 2010 г. 8:57:01 Тихоокеанское летнее время
> Кому: webkit-chan...@lists.webkit.org
> Тема: [webkit-changes] [68146] trunk/WebCore
> 
> Revision
> 68146
> Author
> commit-qu...@webkit.org
> Date
> 2010-09-23 08:56:59 -0700 (Thu, 23 Sep 2010)
> Log Message
> 
> 2010-09-23  Luiz Agostini  
> 
> Reviewed by Andreas Kling.
> 
> Invalid assertion in ScriptCallback
> https://bugs.webkit.org/show_bug.cgi?id=46348
> 
> Removing invalid ASSERT from method ScriptCallback::call().
> 
> * bindings/js/ScriptFunctionCall.cpp:
> (WebCore::ScriptCallback::call):
> Modified Paths
> 
> trunk/WebCore/ChangeLog
> trunk/WebCore/bindings/js/ScriptFunctionCall.cpp
> Diff
> 
> Modified: trunk/WebCore/ChangeLog (68145 => 68146)
> 
> --- trunk/WebCore/ChangeLog   2010-09-23 15:51:41 UTC (rev 68145)
> +++ trunk/WebCore/ChangeLog   2010-09-23 15:56:59 UTC (rev 68146)
> @@ -1,3 +1,15 @@
> +2010-09-23  Luiz Agostini  
> +
> +Reviewed by Andreas Kling.
> +
> +Invalid assertion in ScriptCallback
> +https://bugs.webkit.org/show_bug.cgi?id=46348
> +
> +Removing invalid ASSERT from method ScriptCallback::call().
> +
> +* bindings/js/ScriptFunctionCall.cpp:
> +(WebCore::ScriptCallback::call):
> +
>  2010-09-23  Martin Robinson  
>  
>  Reviewed by Ariya Hidayat.
> Modified: trunk/WebCore/bindings/js/ScriptFunctionCall.cpp (68145 => 68146)
> 
> --- trunk/WebCore/bindings/js/ScriptFunctionCall.cpp  2010-09-23 15:51:41 UTC 
> (rev 68145)
> +++ trunk/WebCore/bindings/js/ScriptFunctionCall.cpp  2010-09-23 15:56:59 UTC 
> (rev 68146)
> @@ -215,9 +215,9 @@
>  
>  CallData callData;
>  CallType callType = getCallData(m_function.jsValue(), callData);
> +if (callType == CallTypeNone)
> +return ScriptValue();
>  
> -ASSERT(callType != CallTypeNone);
> -
>  JSValue result = JSC::call(m_exec, m_function.jsValue(), callType, 
> callData, m_function.jsValue(), m_arguments);
>  hadException = m_exec->hadException();
>  
> ___
> webkit-changes mailing list
> webkit-chan...@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] http://webkit.org/demos/sticky-notes

2010-09-23 Thread Roger Purves

to the forum:

Would it be difficult to rewrite the demo
with textareas (*) replacing the sticky-notes?
For my purposes, the so modified demo
would only need to work offline, using Safari 5
to open the text file containing the code.
In particular I have no interest in using
the modified demo in any web site
delivered by a server. 

(Incidentally, in the demo as it is now,
too much text entered into a note will
result in text spilling out onto
the background.)

Any help or advice would be much
appreciated.

Thank you,

Roger Purves


(*) By textarea, I mean the resizable
entity that Safari 5 displays if
the fragment below is opened:

...








...





___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Disable sheriffbot bug posts?

Re: [webkit-dev] Disable sheriffbot bug posts?

Re: [webkit-dev] Disable sheriffbot bug posts?

Re: [webkit-dev] Disable sheriffbot bug posts?

Re: [webkit-dev] Disable sheriffbot bug posts?

[webkit-dev] Disable sheriffbot bug posts?

Re: [webkit-dev] [webkit-changes] [68146] trunk/WebCore

Re: [webkit-dev] [webkit-changes] [68146] trunk/WebCore

Re: [webkit-dev] Fwd: [webkit-changes] [68146] trunk/WebCore

[webkit-dev] Fwd: [webkit-changes] [68146] trunk/WebCore

[webkit-dev] http://webkit.org/demos/sticky-notes

11 matches

Site Navigation

Mail list logo

Footer information