[webkit-dev] Client-based Geolocation

2010-12-10 Thread John Knottenbelt
I've been working on getting Chromium's WebKit layer to support client-based Geolocation. This means that a class in the Chromium WebKit layer implements the WebCore interface GeolocationClient, and an instance of this class is provided to the Page constructor (by means of PageClients). This is a

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread Adam Barth
Is it time to throw the switch now? Adam On Sun, Nov 21, 2010 at 9:55 AM, Dan Bernstein m...@apple.com wrote: On Nov 21, 2010, at 5:41 AM, Eric Seidel wrote: That's likely to break all the ews and commit bots. Since I'm on vacation at least the ones I run will remain broken until I return

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-10 Thread Ryosuke Niwa
On Wed, Dec 8, 2010 at 11:04 PM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Hi Ryosuke, this feature is already available. I've implemented it for the svg/dynamic-updates test, DRT hooks are available. dumpAsText() takes an optional boolean parameter that toggles this. //

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-10 Thread Darin Adler
On Dec 10, 2010, at 2:05 PM, Ryosuke Niwa wrote: If Ahem allows us to have the same pixel expected results for all platforms. Why don't we switch the default font of DRT to Ahem? Ahem is a testing font where characters are all boxes. It’s quite useful for testing text layout that involves

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread Adam Roben
On Dec 10, 2010, at 5:21 PM, Eric Seidel wrote: Could we add a symlink before then? That seems unlikely to work on Windows, though if the only processes that rely on the symlink are Cygwin-based, maaybe it will. -Adam ___ webkit-dev mailing

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread Eric Seidel
That's fine. We'll move the non-windows bots over. :) On Fri, Dec 10, 2010 at 2:23 PM, Adam Roben aro...@apple.com wrote: On Dec 10, 2010, at 5:21 PM, Eric Seidel wrote: Could we add a symlink before then? That seems unlikely to work on Windows, though if the only processes that rely on

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread William Siegrist
I have an all-day meeting that day so I'm not sure if I'll be free by 4pm PST. But the changes on the master are simple, so I could easily do them sometime that evening if not right at 4pm. Slave machines should not need to restart. -Bill On Dec 10, 2010, at 2:21 PM, Eric Seidel wrote: I

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread Dan Bernstein
On Dec 10, 2010, at 2:21 PM, Eric Seidel wrote: I suspect there will be a lot of follow-on cleanup. I don't plan to be hacking much that evening, but it would be possible. grep -l -r WebKitTools * | grep -v pyc | grep -v ChangeLog Shows that at least 65 files in svn.webkit.org will need

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread Eric Seidel
On Fri, Dec 10, 2010 at 2:38 PM, Dan Bernstein m...@apple.com wrote: On Dec 10, 2010, at 2:21 PM, Eric Seidel wrote: I suspect there will be a lot of follow-on cleanup.  I don't plan to be hacking much that evening, but it would be possible. grep -l -r WebKitTools * | grep -v pyc | grep -v

[webkit-dev] Looking for a V8 bindings volunteer to fix setLocation, open, and showModalDialog

2010-12-10 Thread Darin Adler
Hi folks. I’m moved the logic of setLocation, open, and showModalDialog out of the JavaScript bindings and into the DOMWindow class. http://trac.webkit.org/changeset/73647 http://trac.webkit.org/changeset/73660 http://trac.webkit.org/changeset/73829 I was hoping to find a volunteer to change

Re: [webkit-dev] Looking for a V8 bindings volunteer to fix setLocation, open, and showModalDialog

2010-12-10 Thread Adam Barth
Sure. On Fri, Dec 10, 2010 at 6:21 PM, Darin Adler da...@apple.com wrote: Hi folks. I’m moved the logic of setLocation, open, and showModalDialog out of the JavaScript bindings and into the DOMWindow class. http://trac.webkit.org/changeset/73647 http://trac.webkit.org/changeset/73660

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-10 Thread Ryosuke Niwa
On Fri, Dec 10, 2010 at 2:21 PM, Darin Adler da...@apple.com wrote: On Dec 10, 2010, at 2:05 PM, Ryosuke Niwa wrote: If Ahem allows us to have the same pixel expected results for all platforms. Why don't we switch the default font of DRT to Ahem? Ahem is a testing font where characters

[webkit-dev] Fwd: how to extend self-defined javascript in webkit using v8 on android

2010-12-10 Thread Volter Yen
Hi all, I want to extend my javascript in webpage on android, eg. var myObj = new MYOBJ(); myObj.x =3, according to v8 guide and webkit sourcecode. the former guide us to write standalone v8-based application, and the later the target to extend. I found that the binding from domwindow object

Re: [webkit-dev] Client-based Geolocation

2010-12-10 Thread David Kilzer
On Dec 10, 2010, at 6:45 AM, John Knottenbelt jknot...@chromium.org wrote: It would be great if, ultimately, we could remove the non-client-based geolocation code from WebCore (I already have plans to do this for Chromium's WebKit layer). Such a removal would make the WebCore code more