Re: [webkit-dev] Stability problems involving Javascript GC
On 6 December 2010 22:31, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Crash in WTF::fastMalloc? Such things only happen if something overwrites memory areas belongs to the memory manager (i.e overwrites some bytes before or after a block returned by malloc). Try some valgrind equivalent on mac to detect those writings into red zones. How can you use valgrind to help on that? We had some symptoms similar to this and also came to the conclusion that probably something is overwriting the structures used by fast malloc, but couldn't find anything with valgrind. Overwriting in an area that has bee reserved is not an error vangrind finds, at least not with any options that I know. Regards -- Samuel Rivas RD and Base Development Leader m:+34 619 92 77 46 t:+34 981 17 33 44 ext:61 www.lambdastream.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Atomic read/write operations and thread safety
In MSDN there is a widely cited article about lockless programming on x86 and Xbox: http://msdn.microsoft.com/en-us/library/ee418650(v=vs.85).aspx In short: using boolean as a flag for thread termination is OK. Using boolean as a guard for multi-threaded access to data isn't OK, as read / write reordering can be made both by C++ compiler and CPU. On Thu, Dec 16, 2010 at 00:34, Alexey Proskuryakov a...@webkit.org wrote: 15.12.2010, в 10:36, Stephan Aßmus написал(а): The only thing one needs to watch out for is to declare such a boolean volatile (which I believe this code does, if memory serves). Otherwise the thread which polls the condition may read from a cached location and miss the change. Worst that can happen on a hypothecial architecture where writing a byte is not atomic is that the changed condition takes affect one loop cycle later. The behavior of volatile depends on the compiler - there is no guarantee that a memory barrier will be emitted. Historically, volatile existed not for multiprocessor systems, but for special addresses in address space (like memory mapped I/O), where it is important to actually access the address each time, and not than keep a local variable in a boolean. There is code in WebKit that doesn't care about the other thread immediately seeing the change of a boolean value, and just hopes that it will propagate soon enough in practice. I remember implementing worker thread termination in that way. This code is of course formally wrong. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Webkit Cairo Port on windows
I have successfully built the cairo port for webkit on windows. I have two Questions. 1) If i want to ship the webkit on another machine, what all dll i should bundle, with webkit. 2) When i tried to run the webkit on another machine, it did not run and instead i got an error message This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem. But when i installed sufari, on that machine, it worked. Do we need sufari to be installed? I mean as i know we can build a standalone application using cairo port..? -- View this message in context: http://old.nabble.com/Webkit-Cairo-Port-on-windows-tp30472133p30472133.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKitTools is changing to Tools
Hi, Eric Seidel írta: So that means at least the following people will need to perform restarts: - Whoever runs the Qt ews I will be online on Dec 17 at 4PM PST and will restart the Qt EWS. Additionally the master buildbot of University of Szeged ( http://webkit.sed.hu/buildbot/waterfall ) will need to be restarted too. I will do it after the patch landed. On Fri, Dec 10, 2010 at 2:10 PM, Dan Bernstein m...@apple.com wrote: How about next week, Dec 17 at around 4PM PST? And Dirk mentioned in the bug, that some Chromium wrapper scripts will need to be updated. Will this update affect the Chromium master? ( http://build.chromium.org/p/chromium/console ) Who will take care of the Chromium scripts/master update? br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Build Slave Shutdown
Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the slaves. That is what happened last night around 10:30pm PST, from 66.57.13.12, and that is why the slaves are offline. If you own a build slave that is shutdown, you need to restart the buildbot process on it and check that it reconnects to the master. If you have trouble, email me or ping _wms on irc. I landed http://trac.webkit.org/changeset/74194 to disable the shutdown feature for now. We can move to having user accounts, possibly even use trac/svn or bugs credentials, if we feel we need more fine-grained permissions. -Bill___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Stability problems involving Javascript GC
-Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Samuel Rivas Sent: Thursday, December 16, 2010 3:03 AM To: Zoltan Herczeg Cc: webkit-dev Development Subject: Re: [webkit-dev] Stability problems involving Javascript GC On 6 December 2010 22:31, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: Crash in WTF::fastMalloc? Such things only happen if something overwrites memory areas belongs to the memory manager (i.e overwrites some bytes before or after a block returned by malloc). Try some valgrind equivalent on mac to detect those writings into red zones. How can you use valgrind to help on that? We had some symptoms similar to this and also came to the conclusion that probably something is overwriting the structures used by fast malloc, but couldn't find anything with valgrind. Overwriting in an area that has bee reserved is not an error vangrind finds, at least not with any options that I know. It is possible to add macros to the code to help valgrind know which areas are being used by a custom allocator. (See VALGRIND_MALLOCLIKE_BLOCK and VALGRIND_FREELIKE_BLOCK, for example.) I'm not sure if they're useful in this situation, but they're worth taking a look at. Joe - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Webkit Cairo Port on windows
Hi, On Thu, Dec 16, 2010 at 4:27 AM, Optimus vsbho...@gmail.com wrote: I have two Questions. 1) If i want to ship the webkit on another machine, what all dll i should bundle, with webkit. The best answer to this question is to use the 'depends' tool on Windows to see what DLL's it needs to load. I believe the following libraries are sufficient: 1. libxml2.dll 2. libxslt.dll 3. JavaScriptCore.dll 4. ICUUC40.dll 5. ICUIN40.dll 6. CFLite.dll 7. libcurl.dll 8. libeay32.dll 9. ssleay32.dll However, if you enable QuickTime video support, this will pull in CoreFoundation and the rest of the apple libraries, as they are needed by QuickTime. We've been refactoring the project files a fair amount recently, and during this process I may have missed some places where Apple-specific binaries are being linked. I'll double-check my build environment and make sure the apple runtimes are not being incorrectly used. 2) When i tried to run the webkit on another machine, it did not run and instead i got an error message This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem. But when i installed sufari, on that machine, it worked. Do we need sufari to be installed? I mean as i know we can build a standalone application using cairo port..? I suspect I may have allowed the 'Apple' build environment to bleed into the WinCairo side of things. I'll take a look at it today and try to get it sorted out. Thanks for the head's up! -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Build Slave Shutdown
I've used the shutdown/restart functionality before to try to unwedge a broken bot. The most useful feature, though, is the force build feature, which I use occasionally late at night when the tree is quiet to probe for flakiness. Adam On Thu, Dec 16, 2010 at 9:05 AM, William Siegrist wsiegr...@apple.com wrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the slaves. That is what happened last night around 10:30pm PST, from 66.57.13.12, and that is why the slaves are offline. If you own a build slave that is shutdown, you need to restart the buildbot process on it and check that it reconnects to the master. If you have trouble, email me or ping _wms on irc. I landed http://trac.webkit.org/changeset/74194 to disable the shutdown feature for now. We can move to having user accounts, possibly even use trac/svn or bugs credentials, if we feel we need more fine-grained permissions. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Build Slave Shutdown
On Thu, Dec 16, 2010 at 9:05 AM, William Siegrist wsiegr...@apple.comwrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the slaves. That is what happened last night around 10:30pm PST, from 66.57.13.12, and that is why the slaves are offline. Do you know when Mac bots become online again? - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Build Slave Shutdown
Forced builds are still enabled. But you normally shutdown slaves you do not have shell access to? -Bill On Dec 16, 2010, at 11:50 AM, Adam Barth wrote: I've used the shutdown/restart functionality before to try to unwedge a broken bot. The most useful feature, though, is the force build feature, which I use occasionally late at night when the tree is quiet to probe for flakiness. Adam On Thu, Dec 16, 2010 at 9:05 AM, William Siegrist wsiegr...@apple.com wrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the slaves. That is what happened last night around 10:30pm PST, from 66.57.13.12, and that is why the slaves are offline. If you own a build slave that is shutdown, you need to restart the buildbot process on it and check that it reconnects to the master. If you have trouble, email me or ping _wms on irc. I landed http://trac.webkit.org/changeset/74194 to disable the shutdown feature for now. We can move to having user accounts, possibly even use trac/svn or bugs credentials, if we feel we need more fine-grained permissions. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Build Slave Shutdown
In the past, we've had trouble where one of the two Leopard slaves (or whatever) would consistently be failing a dozen or so tests and the other one would be fine. This causes the tree to be very confusing because the tests appear to fail randomly half the time. I've used the shutdown button to solve those problems, but perhaps I should have just talked with you directly instead. Adam On Thu, Dec 16, 2010 at 2:39 PM, William Siegrist wsiegr...@apple.com wrote: Forced builds are still enabled. But you normally shutdown slaves you do not have shell access to? On Dec 16, 2010, at 11:50 AM, Adam Barth wrote: I've used the shutdown/restart functionality before to try to unwedge a broken bot. The most useful feature, though, is the force build feature, which I use occasionally late at night when the tree is quiet to probe for flakiness. Adam On Thu, Dec 16, 2010 at 9:05 AM, William Siegrist wsiegr...@apple.com wrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the slaves. That is what happened last night around 10:30pm PST, from 66.57.13.12, and that is why the slaves are offline. If you own a build slave that is shutdown, you need to restart the buildbot process on it and check that it reconnects to the master. If you have trouble, email me or ping _wms on irc. I landed http://trac.webkit.org/changeset/74194 to disable the shutdown feature for now. We can move to having user accounts, possibly even use trac/svn or bugs credentials, if we feel we need more fine-grained permissions. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Build Slave Shutdown
You should talk to the slave owner in that case. I just own the master. For example, according to http://build.webkit.org/buildslaves/apple-xserve-5, apple-xserve-5 is owned by bdash. We should probably make sure there are contact details for each slave. -Bill On Dec 16, 2010, at 2:42 PM, Adam Barth wrote: In the past, we've had trouble where one of the two Leopard slaves (or whatever) would consistently be failing a dozen or so tests and the other one would be fine. This causes the tree to be very confusing because the tests appear to fail randomly half the time. I've used the shutdown button to solve those problems, but perhaps I should have just talked with you directly instead. Adam On Thu, Dec 16, 2010 at 2:39 PM, William Siegrist wsiegr...@apple.com wrote: Forced builds are still enabled. But you normally shutdown slaves you do not have shell access to? On Dec 16, 2010, at 11:50 AM, Adam Barth wrote: I've used the shutdown/restart functionality before to try to unwedge a broken bot. The most useful feature, though, is the force build feature, which I use occasionally late at night when the tree is quiet to probe for flakiness. Adam On Thu, Dec 16, 2010 at 9:05 AM, William Siegrist wsiegr...@apple.com wrote: Our buildbot allows for anonymous people to trigger things on the slaves, and it is like this on purpose for ease of use. However, that means it is possible for a malicious person to do things like shutdown all of the slaves. That is what happened last night around 10:30pm PST, from 66.57.13.12, and that is why the slaves are offline. If you own a build slave that is shutdown, you need to restart the buildbot process on it and check that it reconnects to the master. If you have trouble, email me or ping _wms on irc. I landed http://trac.webkit.org/changeset/74194 to disable the shutdown feature for now. We can move to having user accounts, possibly even use trac/svn or bugs credentials, if we feel we need more fine-grained permissions. -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Webkit Cairo Port on windows
Hi Brent, The best answer to this question is to use the 'depends' tool on Windows to see what DLL's it needs to load. I believe the following libraries are sufficient: 1. libxml2.dll 2. libxslt.dll 3. JavaScriptCore.dll 4. ICUUC40.dll 5. ICUIN40.dll 6. CFLite.dll 7. libcurl.dll 8. libeay32.dll 9. ssleay32.dll However, if you enable QuickTime video support, this will pull in CoreFoundation and the rest of the apple libraries, as they are needed by QuickTime. We've been refactoring the project files a fair amount recently, and during this process I may have missed some places where Apple-specific binaries are being linked. I'll double-check my build environment and make sure the apple runtimes are not being incorrectly used. I am already using the tool, but i was doubtful about QuickTime, so then we have to dissable QuickTime video support. I suspect I may have allowed the 'Apple' build environment to bleed into the WinCairo side of things. I'll take a look at it today and try to get it sorted out. Please tell me if so, then i can update my source tree. Is it possible for me to change build environment locally, if it is, where should i look into? Thanks for the head's up! My pleasure -Optimus -- View this message in context: http://old.nabble.com/Webkit-Cairo-Port-on-windows-tp30472133p30478437.html Sent from the Webkit mailing list archive at Nabble.com. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Question about StringImpl::create
I have a question about StringImpl::create(). Is it can only input latin1
data?
If it can only input the latin1 data, the following code maybe incrorect:
In WTFString.cpp :
String String::format(const char *format, ...)
{
...
Vectorchar, 256 buffer;
...
return StringImpl::create(buffer.data(), len);
}
The buffer.data() maybe utf8 data!
Thanks.
pattin___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Page Cache for web-pages with plugin
Hi All, I was wondering as to what is the current status for maintaining a page cache for webpages which contain some plugin ( https://bugs.webkit.org/show_bug.cgi?id=13634) ? The last update on that bug report said that work is ongoing towards it. If someone could point me to the right direction here that it will be very helpful.. Thanks and regards, Aneesh ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Question about StringImpl::create
On Dec 16, 2010, at 9:45 PM, 谢愈挺 wrote:
I have a question about StringImpl::create(). Is it can only input latin1
data?
Yes, this method takes latin1 data all const char* arguments in WTFString are
handled as latin1.
String::fromUTF8 can be used to create strings with utf8 data.
If it can only input the latin1 data, the following code maybe incorrect:
In WTFString.cpp :
String String::format(const char *format, ...)
{
...
Vectorchar, 256 buffer;
...
return StringImpl::create(buffer.data(), len);
}
The buffer.data() maybe utf8 data!
The short answer is that String::format should be considered deprecated - its
behavior is platform-specific, and we'd like to move away from it.
Since all const char* arguments to the String methods are treated as latin1,
format is not suitable for use with utf8 data – any code that is calling format
but that may be working with utf8 data needs to be refactored to stop using
this method (utf8 should be converted to WebCore Strings first, then use the
other conversion/concatenation methods available).
cheers,
G.
Thanks.
pattin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
