[webkit-dev] Fixing Qt and Chromium builds

2011-01-03 Thread Darin Adler
To fix Qt I need to add includes of ExceptionCode.h to two source files. To fox Chromium I have to figure out why my code change to not use defaultChecked seems to have been ineffective. I will be able to deal with these in an hour or so. If someone else can do so sooner that would be great. I

Re: [webkit-dev] Fixing Qt and Chromium builds

2011-01-03 Thread Mihai Parparita
Looks like http://trac.webkit.org/changeset/74899 will fix things. Mihai On Mon, Jan 3, 2011 at 9:56 AM, Mihai Parparita mih...@chromium.org wrote: I'm Chromium gardener, and I'll take a look at the Chromium compile errors. Mihai On Mon, Jan 3, 2011 at 9:46 AM, Darin Adler da...@apple.com

Re: [webkit-dev] git and svn out of sync?

2011-01-03 Thread William Siegrist
The git repo should be in sync within a minute after each commit, though there is no transactional guarantee that they are always in sync. If something crashes during the sync, it won't retry until the next svn commit. -Bill On Jan 2, 2011, at 12:36 PM, Robert Hogan wrote: Looks like this

Re: [webkit-dev] Apple-Mac-Pro-6 is misconfigured

2011-01-03 Thread William Siegrist
On Jan 1, 2011, at 9:20 PM, Eric Seidel wrote: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/25306 It's always failign 3 tests: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r74852%20(25306)/results.html Different tests than other bots.

[webkit-dev] Support for CSS3 gradients landed; ports will need minor changes

2011-01-03 Thread Simon Fraser
I just landed support for CSS3 gradients (see http://dev.w3.org/csswg/css3-images/#gradients), via https://bugs.webkit.org/show_bug.cgi?id=28152. The spec now allows elliptical gradients. Since some platforms may be able to render elliptical gradients natively, the code relies on the platform

Re: [webkit-dev] Support for CSS3 gradients landed; ports will need minor changes

2011-01-03 Thread Mihai Parparita
I've filed https://bugs.webkit.org/show_bug.cgi?id=51841 about making the change for Chromium/Skia. Mihai On Mon, Jan 3, 2011 at 11:45 AM, Simon Fraser simon.fra...@apple.com wrote: I just landed support for CSS3 gradients (see http://dev.w3.org/csswg/css3-images/#gradients), via

Re: [webkit-dev] Handling of feature dependencies

2011-01-03 Thread Konstantin Tokarev
Here are my thoughts on this subject matter: 1) It's bad for the WebKit project to have too many feature flags. All those ifdefs make the code both harder to read and harder to test. I think we already have too many and would like to reduce the number. 2) It’s bad for the web