Re: [webkit-dev] Text display procedure in Webkit GtK

2011-04-11 Thread Martin Robinson
On Mon, Apr 11, 2011 at 10:13 AM, Soheil Servati Beiragh wrote: > I'm working on the WebKit and Text placement. I did lots of back trace on > webkit > in Gtk to find out where actually does the webkit gives the string of text to > the text > handler like cairo to show it. Can you give me any hel

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Lucas De Marchi
On Sun, Apr 10, 2011 at 8:51 PM, Eric Seidel wrote: > We seem to have a zillion EFL patches up for review. > Who are the EFL reviewers? As other mentioned, as of now there are none. I've been doing some informal reviews, but it seems that I'm not receiving all the zillions of patches. Last Frida

[webkit-dev] Text display procedure in Webkit GtK

2011-04-11 Thread Soheil Servati Beiragh
HiI'm working on the WebKit and Text placement. I did lots of back trace on webkit in Gtk to find out where actually does the webkit gives the string of text to the text handler like cairo to show it.Can you give me any help or advise on that?Thanks Soheil Servati BeiraghPhD Candidate, ECE Depa

Re: [webkit-dev] WebKit2 build system

2011-04-11 Thread David Levin
Question answered (in irc): WebKit2 files should have config.h Thanks! On Mon, Apr 11, 2011 at 9:58 AM, David Levin wrote: > Hi, > I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) > in which it uses the OS() macro in some headers (to add a conditional > include to define

Re: [webkit-dev] WebKit2 build system

2011-04-11 Thread David Levin
Hi, I was looking at a patch (https://bugs.webkit.org/show_bug.cgi?id=57535) in which it uses the OS() macro in some headers (to add a conditional include to define time_t). Unfortunately, when these headers are included from WebKit2 files, the build breaks (on various platforms) because OS() isn'

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Leandro Pereira
On Mon, Apr 11, 2011 at 1:08 PM, David Levin wrote: >> >> Hi, >> Is it possible to promote some other peoples to reviewers in the EFL >> port? > > A step that I usually suggest to chromium folks before becoming reviewers is > to actually do reviews on patches.  Do everything except the r+ (with th

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Kenneth Rohde Christiansen
That sounds like a very good idea and I would be happy to help along giving the final r+ Kenneth On Mon, Apr 11, 2011 at 6:08 PM, David Levin wrote: > > > On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski > wrote: >> >> Hi, >> Is it possible to promote some other peoples to reviewers in the EFL

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread David Levin
On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski wrote: > Hi, > Is it possible to promote some other peoples to reviewers in the EFL > port? > A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the sub

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Tomasz Morawski
Hi, Is it possible to promote some other peoples to reviewers in the EFL port? Tomasz The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon,

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-11 Thread Kenneth Rohde Christiansen
The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes wrote: > Mostly myself and Kenneth. We do what we