Re: [webkit-dev] Code Search for webkit.org

[Mihai Parparita]

I usually search the copy of WebKit that's in the Chromium sub-index of code
search. It's at most one day behind ToT WebKit (plus Code Search
crawl/indexing delays):

http://www.google.com/codesearch#search/&exact_package=chromium&q=file%3A%5Esrc/third_party/WebKit

Mihai

Mihai

On Fri, Sep 30, 2011 at 8:33 AM, Tom Zakrajsek  wrote:

> codesearch seems very cool, but I noticed that
> http://codesearch.google.com/#**search/&q=package:webkitseems
>  to be picking up WebKit from the android repo at git://
> android.git.kernel.org/**platform/external/webkit.git.
>  Does that cause problems with the code being stale (more stale than just
> using a "cached copy")?  Is there a way to get it to look at git://
> git.webkit.org/WebKit.**git ?
>
> --tom
>
>
>
>
> On 09/08/2011 03:34 PM, Dimitri Glazkov wrote:
>
>> I<3 codesearch. It's fast, and it's accurate.
>>
>> :DG<
>>
>> On Thu, Sep 8, 2011 at 2:52 PM, Eric Seidel  wrote:
>>
>>> I'm curious how other developers search the WebKit code?
>>>
>>> I use 
>>> http://codesearch.google.com/#**search/&q=package:webkitfrom
>>>  time
>>> to time.  If others do too, we should make it a redirect from
>>> cs.webkit.org (like we do for cia.webkit.org).
>>>
>>> Or maybe folks have better code search solutions?  grep -r?
>>>
>>> -eric
>>> __**_
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev
>>>
>>>  __**_
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev
>>
> __**_
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/**mailman/listinfo.cgi/webkit-**dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Features defines: Platform.h vs build system

[Anders Carlsson]

Speaking of macros, 

I'd like to add a COMPILER_SUPPORTS macro, so we can use it for incrementally 
introducing C++11 features such as variadic templates and rvalue references…

- Anders

On Oct 3, 2011, at 9:53 AM, Darin Adler wrote:

> On Oct 3, 2011, at 8:23 AM, Adam Roben wrote:
> 
>> I think the plan is outlined here: 
>> .
> 
> That’s it! I really want to do it!
> 
> I noticed that one thing the plan doesn’t state is where the includes of the 
> PortXXX.h files go.
> 
>-- Darin
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Features defines: Platform.h vs build system

[Darin Adler]

On Oct 3, 2011, at 8:23 AM, Adam Roben wrote:

> I think the plan is outlined here: 
> .

That’s it! I really want to do it!

I noticed that one thing the plan doesn’t state is where the includes of the 
PortXXX.h files go.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Features defines: Platform.h vs build system

[Adam Roben]

On Oct 3, 2011, at 10:51 AM, Darin Adler wrote:

> But a while back, Maciej outlined a concept for where to put these platform 
> base include files; I don’t remember when that was or what the details were.

I think the plan is outlined here: 
.

-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Features defines: Platform.h vs build system

[Darin Adler]

On Oct 3, 2011, at 6:35 AM, Balazs Kelemen wrote:

> I think we lack a consistent way for setting up the set of feature defines. 
> Some of them are handled via Platform.h and some of them via the build 
> systems. Don't you think all should be handled the same way? This has came up 
> in my mind in connection with the newly introduced CSS_FILTERS define. 
> (https://bugs.webkit.org/show_bug.cgi?id=68652) The logic to set the define 
> has only been added to the Mac build system because the feature is Mac-only 
> currently. I don't think it is a good solution. As more platforms would use 
> the feature they also need to add the logic to their build system that is 
> somewhat more difficult than just adding one more ifdef branch to Platform.h. 
> Note that it is not totally avoidable to have some overhead per platform 
> because we need to handle the --css-filters build-webkit switch. However 
> build-webkit already knows how to set up a -D flag on each platform so it's 
> not a big deal.

On the Mac platform, at least, we can build without using the build-webkit 
script. I would not want to make the build-webkit script required more than it 
is today.

I believe the base values of feature defines should be controlled by a 
checked-in source file. Overrides in build scripts would be possible for the 
unusual situation where someone wants to build with an non-standard set of 
feature defines for a given platform.

We have never implemented a separate source file that sets each platform’s base 
values for feature defines. But a while back, Maciej outlined a concept for 
where to put these platform base include files; I don’t remember when that was 
or what the details were.

I think that having the defines for all platforms right there in Platform.h or 
in config.h is absolutely not what we want. Instead we want each high level 
platform’s base defines to be in a file that is just full of #define statements 
without a mix of other logic.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Features defines: Platform.h vs build system

[Balazs Kelemen]

Hi all!

I think we lack a consistent way for setting up the set of feature 
defines. Some of them are handled via Platform.h and some of them via 
the build systems. Don't you think all should be handled the same way? 
This has came up in my mind in connection with the newly introduced 
CSS_FILTERS define. (https://bugs.webkit.org/show_bug.cgi?id=68652) The 
logic to set the define has only been added to the Mac build system 
because the feature is Mac-only currently. I don't think it is a good 
solution. As more platforms would use the feature they also need to add 
the logic to their build system that is somewhat more difficult than 
just adding one more ifdef branch to Platform.h. Note that it is not 
totally avoidable to have some overhead per platform because we need to 
handle the --css-filters build-webkit switch. However build-webkit 
already knows how to set up a -D flag on each platform so it's not a big 
deal.

I wonder about your opinion on this.

-kbalazs
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev