Re: [webkit-dev] Code Search for webkit.org

2011-10-04 Thread Mihai Parparita
I usually search the copy of WebKit that's in the Chromium sub-index of code search. It's at most one day behind ToT WebKit (plus Code Search crawl/indexing delays): http://www.google.com/codesearch#search/exact_package=chromiumq=file%3A%5Esrc/third_party/WebKit Mihai Mihai On Fri, Sep 30,

[webkit-dev] runtime settings in a ~/.webkitrc

2011-10-04 Thread haithem rahmani
Hi, isn't a good idea to make webkit read ~/.webkitrc file to enable/disable features at runtime? regards. Haithem. -- * If you ask a question - you will be a fool for 5 minutes, otherwise ignorant for rest of your life * ___ webkit-dev mailing list

Re: [webkit-dev] runtime settings in a ~/.webkitrc

2011-10-04 Thread Konstantin Tokarev
04.10.2011, 11:07, haithem rahmani haithem.rahm...@gmail.com: Hi,isn't a good idea to make webkit read ~/.webkitrc file to enable/disable features at runtime? regards. IMHO it is not. 1. WebKit is a library, not a self contained application, and settings should be managed by applications

[webkit-dev] Fastest image format

2011-10-04 Thread Joe LaFritte
Hello, What is the fastest image format for wekbit ? I mean which image format (jpg, png, gif, etc.) is decoded and displayed fastest than the other ones ? I did a search on the forum and found nothing. Thank you very much. ___ webkit-dev mailing list

Re: [webkit-dev] Fastest image format

2011-10-04 Thread Konstantin Tokarev
04.10.2011, 13:22, Joe LaFritte joelafri...@yahoo.fr: Hello, What is the fastest image format for wekbit ? I mean which image format (jpg, png, gif, etc.) is decoded and displayed fastest than the other ones ? It heavily depends on hardware and used decoding libraries. -- Regards,

[webkit-dev] dispatchEvent is a noop on documents returned by parseFromString

2011-10-04 Thread Loic Dachary
Hi, In the context of https://bugs.webkit.org/show_bug.cgi?id=26147 ( No support of DOM events on a frameless document ) I am researching how to implement a fix. I'm thinking of two possible solutions, none of which is trivial. Probably because I'm new to the webkit codebase. a) modify the

Re: [webkit-dev] More feature flags for input types (Re: New Feature Flag Proposal: INPUT_COLOR)

2011-10-04 Thread TAMURA, Kent
Filed a bug: https://bugs.webkit.org/show_bug.cgi?id=68971 On Mon, Aug 8, 2011 at 11:03, TAMURA, Kent tk...@chromium.org wrote: But is there any grouping we can do? Does each need a separate feature flag? I think separated feature flags are better. Suppose that all types are in

Re: [webkit-dev] Fastest image format

2011-10-04 Thread Peter Kasting
On Tue, Oct 4, 2011 at 2:22 AM, Joe LaFritte joelafri...@yahoo.fr wrote: What is the fastest image format for wekbit ? I mean which image format (jpg, png, gif, etc.) is decoded and displayed fastest than the other ones ? That likely depends on the image, the decoder, and the system in

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Peter Kasting
On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa rn...@webkit.org wrote: In my understanding, we use pass by reference for out arguments when they have to be modified in callees. I had not heard this. Personally I weakly prefer pointers to non-const refs for outparams, but if there is convention

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Ryosuke Niwa
On Tue, Oct 4, 2011 at 2:11 PM, Peter Kasting pkast...@chromium.org wrote: On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa rn...@webkit.org wrote: In my understanding, we use pass by reference for out arguments when they have to be modified in callees. I had not heard this. As far as I

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread James Robinson
On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, It came to my attention that some people are using raw pointers to pass out-arguments (e.g. bug 69366). In my understanding, we use pass by reference for out arguments when they have to be modified in callees. If

Re: [webkit-dev] Add explicit style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Darin Adler
On Oct 4, 2011, at 2:14 PM, James Robinson wrote: Could you explain why? Is it to document the nullity of the out-param? Sure, one reason is to document the non-nullity of the out parameter. I personally find pointers for out parameters to be appropriate in many situations. It makes the

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Darin Adler
On Oct 4, 2011, at 2:06 PM, Ryosuke Niwa wrote: It came to my attention that some people are using raw pointers to pass out-arguments (e.g. bug 69366). In my understanding, we use pass by reference for out arguments when they have to be modified in callees. If there's no objection, I'm

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Eric Seidel
Interesting. I thought historical policy was universally against the word get in function names. I guess you're suggesting that get should only be applied to function names which have an out-argument? -eric On Tue, Oct 4, 2011 at 6:00 PM, Darin Adler da...@apple.com wrote: On Oct 4, 2011, at

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Hajime Morrita
At least we already have some of such mehods like: void Range::getBorderAndTextQuads(VectorFloatQuad) const; void VisiblePosition::getInlineBoxAndOffset(InlineBox* inlineBox, int caretOffset) const; void Posiiton::getInlineBoxAndOffset(EAffinity, InlineBox*, int caretOffset) const; void

Re: [webkit-dev] Add explicit style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Ryosuke Niwa
On Oct 4, 2011 5:57 PM, Darin Adler da...@apple.com wrote: I personally find pointers for out parameters to be appropriate in many situations. It makes the side effects of manipulating the parameter more obvious, and it provides a clear way for the caller to indicate that they don't care about a

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Ryosuke Niwa
On Tue, Oct 4, 2011 at 2:14 PM, James Robinson jam...@google.com wrote: Is it to document the nullity of the out-param? Yes, and it also prevents mistakes like: #include cstdio class base { ... }; class derived : public base { ... }; void getBase(base* b) { *b = base(); } int main() {

Re: [webkit-dev] Change to style guideline: should use type instead of type* for out arguments

2011-10-04 Thread Darin Adler
On Oct 4, 2011, at 6:14 PM, Eric Seidel wrote: I thought historical policy was universally against the word get in function names. The policy has been to reserve the word get to mean a function that gets a value in an out argument, as opposed to a function that returns a value, which we

[webkit-dev] Chromium PLT regression

2011-10-04 Thread Adam Barth
About a week ago, the Chromium project measured a PLT regression on Windows, Mac, and Linux: https://bugs.webkit.org/show_bug.cgi?id=69238 I don't know whether the regression affects any other ports, but according to the Chromium performance bots, the regression occurred in this range:

Re: [webkit-dev] Chromium PLT regression

2011-10-04 Thread Dan Bernstein
On Oct 4, 2011, at 10:37 PM, Adam Barth wrote: About a week ago, the Chromium project measured a PLT regression on Windows, Mac, and Linux: https://bugs.webkit.org/show_bug.cgi?id=69238 I don't know whether the regression affects any other ports, but according to the Chromium

[webkit-dev] The JSC Garbage Collector

2011-10-04 Thread Sanjoy Das
Hi! I recently started looking through the JavaScriptCore codebase, and discovered that working on the GC would be a nice way to contribute. A starting point, I think, would be to implement code that allows moving objects around. I was thinking of doing this by adding a third field to the