Re: [webkit-dev] Git/SVN is slow

[James Robinson]

On Wed, Mar 14, 2012 at 2:08 PM, William Siegrist wrote:

> On Mar 14, 2012, at 1:47 PM, Robert Hogan  wrote:
>
> > On Wednesday 14 March 2012 08:44:46 Ashod Nakashian wrote:
> >>> From: Nikolas Zimmermann 
> >>> To: WebKit Development 
> >>> Cc:
> >>> Sent: Wednesday, March 14, 2012 1:31 AM
> >>> Subject: [webkit-dev] Git/SVN is slow
> >>>
> >>> G ood morning WebKit crowd,
> >>>
> >>> since at least some weeks, updating git.webkit.org and/or
> >>> svn.webkit.org is extremely slow for me.
> >>> I have a git fetch rate below 3KiB/s average - surfing the web and/or
> >>> downloading anything else is acceptable with my 10MBit connection.
> >>> I'm located near Cologne, in Germany -- do any other european
> >>> WebKittens suffer from the same problems?
> >>
> >
> > It has always been pretty slow for me too (Ireland), occasionally as bad
> as
> > you describe but more often in the 80-100KiB/s average. Thanks for
> sharing
> > the chromium mirror tip.
> >
>
>
> Our network provider is looking into our bandwidth problems. It looks like
> this may affect more than just git or svn.
>

For the record this is not only an issue with overseas connections.   I've
seen extremely slow pull times as well and lots of 500s from various
webkit.org servers.  I'm in Mountain View, CA and have what I would
consider to be ample bandwidth available to the internet.

- James


> -Bill
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Git/SVN is slow

[William Siegrist]

On Mar 14, 2012, at 1:47 PM, Robert Hogan  wrote:

> On Wednesday 14 March 2012 08:44:46 Ashod Nakashian wrote:
>>> From: Nikolas Zimmermann 
>>> To: WebKit Development 
>>> Cc:
>>> Sent: Wednesday, March 14, 2012 1:31 AM
>>> Subject: [webkit-dev] Git/SVN is slow
>>> 
>>> G ood morning WebKit crowd,
>>> 
>>> since at least some weeks, updating git.webkit.org and/or
>>> svn.webkit.org is extremely slow for me.
>>> I have a git fetch rate below 3KiB/s average - surfing the web and/or
>>> downloading anything else is acceptable with my 10MBit connection.
>>> I'm located near Cologne, in Germany -- do any other european
>>> WebKittens suffer from the same problems?
>> 
> 
> It has always been pretty slow for me too (Ireland), occasionally as bad as 
> you describe but more often in the 80-100KiB/s average. Thanks for sharing 
> the chromium mirror tip.
> 


Our network provider is looking into our bandwidth problems. It looks like this 
may affect more than just git or svn. 

-Bill

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Removing Custom bindings for type array.

[Adam Barth]

It looks like you're getting some good comments on the bug.  Thanks
for working on removing custom bindings code.

Adam


On Wed, Mar 14, 2012 at 5:30 AM, Vineet Chaudhary  wrote:
> Hi All,
>
> I am trying to remove the custom bindings for the type Array.(ref
> : Bug 80696)
> Below is list of idls using the attribute type Array with custom bindings.
> a. Clipboard
> b. ScriptProfileNode
> c. Console
> d. Internals
> e. MessageEvent
> f. JavaScriptCallFrame
>
> All of them returns type JSArray for (JS engine) and V8Arrays for the (V8
> engine).
> I have wip attached in the bug ,modifying CodeGenerator for JS and V8 to
> auto generate bindings which works fine fine.
> But it fails for the Gtk because of the GObject bindings.
> To resolve this issue I am thinking of adding WebKitDOMArray.h
> and WebKitDOMArray.cpp to WebCore/bindings so that It can generate the
> appropriate binding.
>
> Can someone please advice if this the correct way of doing this or there is
> any other approach to do this.
>
> Thanks,
> Vineet
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Git/SVN is slow

[Robert Hogan]

On Wednesday 14 March 2012 08:44:46 Ashod Nakashian wrote:
> > From: Nikolas Zimmermann 
> > To: WebKit Development 
> > Cc:
> > Sent: Wednesday, March 14, 2012 1:31 AM
> > Subject: [webkit-dev] Git/SVN is slow
> >
> >G ood morning WebKit crowd,
> >
> > since at least some weeks, updating git.webkit.org and/or
> > svn.webkit.org is extremely slow for me.
> > I have a git fetch rate below 3KiB/s average - surfing the web and/or
> > downloading anything else is acceptable with my 10MBit connection.
> > I'm located near Cologne, in Germany -- do any other european
> > WebKittens suffer from the same problems?
> 

It has always been pretty slow for me too (Ireland), occasionally as bad as 
you describe but more often in the 80-100KiB/s average. Thanks for sharing 
the chromium mirror tip.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Anyone using NEON code on ARM builds?

[Dean Jackson]

Hi,

There are three files with embedded NEON code to speed up filters:

./Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.{h,cpp}
./Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.{h,cpp}
./Source/WebCore/platform/graphics/filters/arm/FELightingNEON.{h,cpp}

Are any ARM ports using this? (would require SVG and FILTERS both enabled) If 
so, could you contact me? Off list is fine.

I see the code came from Felician Marton via Zoltan reviewed by Dirk (eg. 
https://bugs.webkit.org/show_bug.cgi?id=65522) and it's been very slightly 
touched for some chromium build issues.

Thanks,

Dean


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebKitIDL syntax: semicolons

[Seo Sanghyeon]

2012/3/14 Kentaro Hara :
>> Is it okay to fix these in the interest of consistency?
>
> Sounds good although I don't know how much important it is.
> Please file a bug and cc me.

Done.
https://bugs.webkit.org/show_bug.cgi?id=81129

This is boring in itself, but I think aligning syntax is important.

-- 
Seo Sanghyeon
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] What is the relationship between WebIDL and WebKitIDL?

[Seo Sanghyeon]

2012/3/15 Kentaro Hara :
> We have always been trying to align WebKitIDL with WebIDL. In
> particular, last month we have removed or renamed 70~ IDL attributes
> so that they align the WebIDL spec as much as possible
> (https://docs.google.com/a/google.com/spreadsheet/ccc?key=0AlobCOyvTnPKdG1iaFJhNVZGMWI3eWZid0ZRVFdxU3c#gid=0).

This is great!

At the moment, I am more interested in aligning syntax rather than
semantics, so that WebIDL tools can process WebKitIDL, i.e.
pretty-print, index, diff. These mostly don't require understanding
IDL attributes.

-- 
Seo Sanghyeon
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Removing Custom bindings for type array.

[Žan Doberšek]

On Wed, Mar 14, 2012 at 1:30 PM, Vineet Chaudhary wrote:

>
>  All of them returns type JSArray for (JS engine) and V8Arrays for the
> (V8 engine).
> I have wip attached in the bug ,modifying CodeGenerator for JS and V8 to
> auto generate bindings which works fine fine.
> But it fails for the Gtk because of the GObject bindings.
>

The GObject bindings would probably use a GLib-specific array structure,
the GArray, meaning some additional hacking would be required on
CodeGeneratorGObject.pm. I can help with that once it is clear how the
array type should be implemented in JS and V8 generators.


> To resolve this issue I am thinking of adding WebKitDOMArray.h and
> WebKitDOMArray.cpp to WebCore/bindings so that It can generate the
> appropriate binding.
>
> Can someone please advice if this the correct way of doing this or there
> is any other approach to do this.
>
> Thanks,
> Vineet
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] What is the relationship between WebIDL and WebKitIDL?

[Kentaro Hara]

> https://lists.webkit.org/pipermail/webkit-dev/2009-June/008458.html
> expressed an intention to move WebKit IDL syntax closer to
> Web IDL syntax, with corresponding bug
> https://bugs.webkit.org/show_bug.cgi?id=26398
>
> However, there doesn't seem to be any progress on this.

We have always been trying to align WebKitIDL with WebIDL. In
particular, last month we have removed or renamed 70~ IDL attributes
so that they align the WebIDL spec as much as possible
(https://docs.google.com/a/google.com/spreadsheet/ccc?key=0AlobCOyvTnPKdG1iaFJhNVZGMWI3eWZid0ZRVFdxU3c#gid=0).

That being said, aligning WebKitIDL with WebIDL is not the only
objective of WebKitIDL. Another important objective of WebKitIDL is to
generate as much binding code as possible, because hand-written custom
binding code is likely to be buggy. This is the reason why WebKitIDL
has introduced so many IDL attributes that are not defined in the
WebIDL spec (e.g. [ActiveDOMObject], [Custom], [CheckSecurityForNode],
etc...so many:-).


> I am interested in moving this forward. Is it okay?

It is _really_ okay. If you find IDL attributes that should be aligned
with the spec or can be cleaned up, you can fix them. Please file a
bug and cc me. I am happy to take a look.


-- 
Kentaro Hara, Tokyo, Japan (http://haraken.info)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebKitIDL syntax: semicolons

[Kentaro Hara]

> It seems that the parser doesn't care

Yeah, IDLParser.pm does not care the semicolon for now. You can find
the regular expression in IDLStructure.pm.

> , but is it okay to fix these in the interest of consistency?

Sounds good (although I don't know how much important it is:-).
Please file a bug and cc me.


On Wed, Mar 14, 2012 at 11:38 PM, Seo Sanghyeon  wrote:
> An example at http://trac.webkit.org/wiki/WebKitIDL suggests that
> interface definitions have semicolons after closing braces (like WebIDL),
> while module definitions don't (unlike WebIDL).
>
> Actual IDL files in the source tree seem to follow that, except following
> 4 files:
>
> SVGAnimateColorElement.idl
> SVGAnimateElement.idl
> SVGAnimateTransformElement.idl
> SVGAnimatedRect.idl
>
> They have semicolons after module definitions but no semicolons
> after interface definitions. (Found with a crude script. There may be more,
> but I think the list is complete.)
>
> It seems that the parser doesn't care, but is it okay to fix these
> in the interest of consistency?
>
> --
> Seo Sanghyeon
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

-- 
Kentaro Hara, Tokyo, Japan (http://haraken.info)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] WebKitIDL syntax: semicolons

[Seo Sanghyeon]

An example at http://trac.webkit.org/wiki/WebKitIDL suggests that
interface definitions have semicolons after closing braces (like WebIDL),
while module definitions don't (unlike WebIDL).

Actual IDL files in the source tree seem to follow that, except following
4 files:

SVGAnimateColorElement.idl
SVGAnimateElement.idl
SVGAnimateTransformElement.idl
SVGAnimatedRect.idl

They have semicolons after module definitions but no semicolons
after interface definitions. (Found with a crude script. There may be more,
but I think the list is complete.)

It seems that the parser doesn't care, but is it okay to fix these
in the interest of consistency?

-- 
Seo Sanghyeon
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] What is the relationship between WebIDL and WebKitIDL?

[Seo Sanghyeon]

http://trac.webkit.org/wiki/WebKitIDL says:
The syntax of IDL files is fairly well documented in the Web IDL spec,
but it is too formal to read and there are several differences between
the Web IDL spec and the WebKit IDL due to implementation issues.

https://lists.webkit.org/pipermail/webkit-dev/2009-June/008458.html
expressed an intention to move WebKit IDL syntax closer to
Web IDL syntax, with corresponding bug
https://bugs.webkit.org/show_bug.cgi?id=26398

However, there doesn't seem to be any progress on this.
I am interested in moving this forward. Is it okay?

-- 
Seo Sanghyeon
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Removing Custom bindings for type array.

[Vineet Chaudhary]

Hi All,

I am trying to remove the custom bindings for the type Array.(ref : *
Bug 80696 )*
Below is list of idls using the attribute type Array with custom bindings.
a. Clipboard
b. ScriptProfileNode
c. Console
d. Internals
e. MessageEvent
f. JavaScriptCallFrame

 All of them returns type JSArray for (JS engine) and V8Arrays for the (V8
engine).
I have wip attached in the bug ,modifying CodeGenerator for JS and V8 to
auto generate bindings which works fine fine.
But it fails for the Gtk because of the GObject bindings.
To resolve this issue I am thinking of adding WebKitDOMArray.h and
WebKitDOMArray.cpp
to WebCore/bindings so that It can generate the appropriate binding.

Can someone please advice if this the correct way of doing this or there is
any other approach to do this.

Thanks,
Vineet
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] When should we turn on new features?

[Alexis Menard]

On Mon, Feb 13, 2012 at 11:09 PM, Maciej Stachowiak  wrote:
>
> I think we're talking about a couple of different things now:
>
> 1) Table of what the WebKit community as a whole (instead of individual point 
> maintainers) thinks should be enabled in stable releases. This would be input 
> to port maintainers looking to make a release.
>
> 2) Documenting what enable flags are actually on for given ports as shipped. 
> Probably hard to gather this info, but might be useful input for the WebKit 
> community.
>
> 3) Changing build systems to enable compiling "nightly" and "stable" versions 
> from the same tree, so both modes are documented in trunk. Requires some 
> coding for various build systems.
>
> I like (2) and (3), but I don't think they replace the usefulness of (1). I 
> think the mention of "the feature-table page" is blending (2) and (1), which 
> would serve different purposes.

Hi,

I think one is totally useful and more than welcome. I would say that
the page should sit in the SVN so that whenever someone add a feature
the file had to be updated too. Also when someone add some UI bits for
a given port he can also update the file/page accordingly. The closer
this file is to the code the more chance it has to be up to date.

In QtWebKit we had
http://trac.webkit.org/wiki/QtWebKitSupportedStandards (but not up to
date) to track which release comes with what. It's missing the last
release funny enough.

There will be an initial work on each port to fill the default values
but hey nothing comes for free.

>
> Regards,
> Maciej
>
>
> On Feb 13, 2012, at 4:21 PM, Hajime Morrita wrote:
>
>> (Re-sending from the right address...)
>>
>> I'd +1 Adam's point.
>>
>> It would be great if we can do something like "webkit-build --gtk
>> --stable", "webkit-build --chromium --canary" or "webkit-build
>> --nightly" where the script read the central configuration file and
>> find an appropriate configuration. In this way, there would be no
>> duplication we should maintain.
>>
>> Even though some ports currently don't support switches through
>> build-webkit, we can gradually switch over to the central list-based
>> configuration settings by, for example, generating features.gypi,
>> FeatureDefines.xcconfig or a set of flags for autoconf.
>>
>> Also the feature-table page could be generated from the list. We can
>> even start from simply generating an HTML from the machine-readable
>> configuration file, then integrate it to each build system.
>>
>> Although it might be overkill, I personally prefer this kind of "don't
>> repeat youself" direction.
>> --
>> morrita
>>
>> On Tue, Feb 14, 2012 at 8:11 AM, Maciej Stachowiak  wrote:
>>>
>>> On Feb 13, 2012, at 1:21 PM, Ryosuke Niwa wrote:
>>>
>>> On Mon, Feb 13, 2012 at 1:02 PM, Maciej Stachowiak  wrote:

 I think you raise a good point. Another point worth mentioning is that
 sometimes a feature can be complete and useful in one port, but half-baked
 in another (for example, fullscreen API was shipped in Safari and at the
 same time present but non-functional in Chrome).

 I think in the past, port owners have made clear that they want to own the
 final decisions on what features are enabled in their ports.

 But we as a community could do better, by having a shared recommendation
 of what features we think should be enabled in shipping releases. In some
 cases, this may not match the settings on trunk, as some features may be
 desirable to enable for experimental builds, but not in shipping product.
 For features that we recommended disabling, ideally we'd identify a reason.
 And in some cases, those might be port-specific issues.
>>>
>>>
>>> Right. Even just having a list of new features with flag(s) to
>>> enable/disable and the status (e.g. list of outstanding bugs) on wiki page
>>> will be helpful.
>>>
>>> For example, vertical writing mode doesn't work on Windows, Chromium, etc...
>>> but port owners may not necessarily realize that the feature is enabled by
>>> default and each port needs to modify the code that draws text.
>>>
>>>
>>> I personally think such a page would be a good idea. I'd love to hear input
>>> from more folks on whether this is a good idea and what the right approach
>>> is.
>>>
>>> Cheers,
>>> Maciej
>>>
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



-- 
Alexis Menard (darktears)
Software Engineer
INdT Recife Brazil
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Git/SVN is slow

[Ashod Nakashian]

> From: Nikolas Zimmermann 
> To: WebKit Development 
> Cc: 
> Sent: Wednesday, March 14, 2012 1:31 AM
> Subject: [webkit-dev] Git/SVN is slow
> 
>G ood morning WebKit crowd,
> 
> since at least some weeks, updating git.webkit.org and/or svn.webkit.org is 
> extremely slow for me.
> I have a git fetch rate below 3KiB/s average - surfing the web and/or 
> downloading anything else is acceptable with my 10MBit connection.
> I'm located near Cologne, in Germany -- do any other european WebKittens 
> suffer from the same problems?

I'm in Yerevan, Armenia and git-svn is painfully slow for me. I haven't 
benchmarked it but even 'git svn fetch' after 'git fetch' takes several minutes 
where 'svn up' is very fast indeed. My connection is otherwise 16Mbps symetric.

-Ash

> 
> I heard the fetch rate in the US is much faster 800+ KiB/s. Does anyone know 
> whats going on?
> 
> Cheers,
> Niko
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> - Original Message -

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Git/SVN is slow

[Nikolas Zimmermann]

Am 14.03.2012 um 09:31 schrieb Nikolas Zimmermann:

> Good morning WebKit crowd,
> 
> since at least some weeks, updating git.webkit.org and/or svn.webkit.org is 
> extremely slow for me.
> I have a git fetch rate below 3KiB/s average - surfing the web and/or 
> downloading anything else is acceptable with my 10MBit connection.
> I'm located near Cologne, in Germany -- do any other european WebKittens 
> suffer from the same problems?


For the record:
Per morritas advices, I tried "git remote add mirror 
http://git.chromium.org/external/Webkit.git && git fetch mirror".
That gives me around 500 KiB/s here, which is completely acceptable.

Still it would be great to find the cause why git.webkit.org is so slow.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Git/SVN is slow

[Nikolas Zimmermann]

Good morning WebKit crowd,

since at least some weeks, updating git.webkit.org and/or svn.webkit.org is 
extremely slow for me.
I have a git fetch rate below 3KiB/s average - surfing the web and/or 
downloading anything else is acceptable with my 10MBit connection.
I'm located near Cologne, in Germany -- do any other european WebKittens suffer 
from the same problems?

I heard the fetch rate in the US is much faster 800+ KiB/s. Does anyone know 
whats going on?

Cheers,
Niko

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev