Re: [webkit-dev] Question about Floating-point operations base SH4 JIT
What is the endianness of your platform? I think that the big endian code in
JavaScriptCore may have rotted.
This smells to me like the tag and payload getting flipped around, which might
happen if there are parts of the code that are assuming little endian and your
hardware is big endian.
-F
On Aug 1, 2012, at 11:47 PM, talking1...@gmail.com wrote:
> Hi,
>
> I have test with follow case, and cann't get correct reslut. I find that
> Floating-point operations is error, and I don't know where shold start to
> fixed this question. so if anybody can give some information for which
> function i should to check.
>
>
> Any help explaining this would be much appreciated!
>
>
> My Compiler: MSVS
>
> ARCH: SH4
>
> Feature: JIT
>
>
>
>
>
> Javascript code of test case
>
> function jitTestCode() {
>
> var tmp = -1*0;
>
> debug("tmp:" + tmp);
>
> var result = tmp + 1;
>
> debug("The result should be 1,result:" + result); //print
>
> var item1 = result - 1;
>
> debug("The item1 should be 0,item1:" + item1); //print
>
> var item2 = result - 2;
>
> debug("The item2 should be -1,item2:" + item2); //print
>
> }
>
>
>
> And the log information are:
>
> [CONSOLE-DEBUG]Message is :'tmp:0'
>
> [CONSOLE-DEBUG]Message is :'The result should be 1,result:0.0078125'
>
> [CONSOLE-DEBUG]Message is :'The item1 should be 0,item1:0'
>
> [CONSOLE-DEBUG]Message is :'The item2 should be -1,item2:-0.0078125'
>
>
> --
> BGs/Felix Shi
>
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Question about Floating-point operations base SH4 JIT
Hi,
I have test with follow case, and cann't get correct reslut. I find that
Floating-point operations is error, and I don't know where shold start to
fixed this question. so if anybody can give some information for which function
i should to check.
Any help explaining this would be much appreciated!
My Compiler:MSVS
ARCH:SH4
Feature:JIT
Javascript code of test case
function jitTestCode() {
var tmp = -1*0;
debug("tmp:" + tmp);
var result = tmp + 1;
debug("The result should be 1,result:" + result); //print
var item1 = result - 1;
debug("The item1 should be 0,item1:" + item1); //print
var item2 = result - 2;
debug("The item2 should be -1,item2:" + item2); //print
}
And the log information are:
[CONSOLE-DEBUG]Message is :'tmp:0'
[CONSOLE-DEBUG]Message is :'The result should be 1,result:0.0078125'
[CONSOLE-DEBUG]Message is :'The item1 should be 0,item1:0'
[CONSOLE-DEBUG]Message is :'The item2 should be -1,item2:-0.0078125'
--
BGs/Felix Shi
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Parallel image decoders are up for review
Hello, folks. We updated the test results. http://webkit.org/b/90375#c49 We think the performance improvement is promising. @ Summary of the results 1. The response time of interactive web pages were improved by approximately 20%. 2. An embedded device shows a similar performance enhancement as a high-end PC. Thank you. 2012/7/19 Schmindor : >> Hi, >> >> Our team at Company 100 has worked on parallel image decoders for past a >> few weeks and some patches are pending for review now. Here is the master >> bug for parallel image decoders: >> >> https://bugs.webkit.org/show_bug.cgi?id=90375 >> >> For the overall architecture and design, please refer to the following >> design document. We will update the design document as we change code after >> review. >> >> >> https://docs.google.com/document/pub?id=12gf7MhNHfupeR3GdRF-h2Vzg86viCbwXq8_JByHKlg0 >> >> Our implementation shows considerable speedup in image intensive sites and >> no performance regression in PLT. Please refer to the master bug for >> specific numbers. >> >> We do understand many paralleization techniques make code so complex to >> the level that can't be accepted. So we tried our best to reduce the >> complexity of code, but reviewers can help us reduce it further. >> >> Regards, >> Kwang Yul Seo >> >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
On Aug 1, 2012, at 4:36 PM, Elliott Sprehn wrote: > > On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader > wrote: > Hi all :) > > As suggested by Ojan, I am writing a mail to you about my intention to > implement all updated and missing text-decoration* properties from > CSS3 spec (currently in development), named below: > > -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration > Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration > Status: Proposed patch / pending review > > It seems weird to have a prefixed version of text-decoration instead of just > making text-decoration allow the new prefixed keywords. > > What's the reason for having a whole new prefixed property? Making regular text-decoration accept prefixed keywords for the new/unstable tuff sounds like a good approach to me. I too am curious why that is not proposed. - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi Elliott, On Wed, Aug 1, 2012 at 7:36 PM, Elliott Sprehn wrote: > It seems weird to have a prefixed version of text-decoration instead of just > making text-decoration allow the new prefixed keywords. > > What's the reason for having a whole new prefixed property? The rationale is that the CSS3 specification for "text-decoration" property differs from CSS2.1 one, and since it's still in development it is subject to change. But of course, the way the CSS3 "text-decoration" spec is defined, it clearly supports the CSS2.1 specification as well. Best regards, -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader wrote: > Hi all :) > > As suggested by Ojan, I am writing a mail to you about my intention to > implement all updated and missing text-decoration* properties from > CSS3 spec (currently in development), named below: > > -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) > CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration > Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration > Status: Proposed patch / pending review > It seems weird to have a prefixed version of text-decoration instead of just making text-decoration allow the new prefixed keywords. What's the reason for having a whole new prefixed property? - E ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] impending changes to how new-run-webkit-tests prints/logs stuff
On Wed, Aug 1, 2012 at 12:48 PM, Dirk Pranke wrote: > For anyone bikeshedding along at home, my current plan of record (and > changes to what has been written earlier in the thread) ... > > 1) '--verbose --verbose' to increase verbosity is right out > 2) we can't use '--debug' to get debug-level output, since that is > already used to run the debug build > 3) as Alexey pointed out on the bug, old-style verbose is really more > about debugging NRWT > > so ... > > '--debug-nrwt-logging' will replace '--verbose --verbose' > '--quiet' and '--verbose' will remain as written in my first note. > s/--debug-nrwt-logging/--debug-rwt-logging/. The shed has been painted :). -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] impending changes to how new-run-webkit-tests prints/logs stuff
For anyone bikeshedding along at home, my current plan of record (and changes to what has been written earlier in the thread) ... 1) '--verbose --verbose' to increase verbosity is right out 2) we can't use '--debug' to get debug-level output, since that is already used to run the debug build 3) as Alexey pointed out on the bug, old-style verbose is really more about debugging NRWT so ... '--debug-nrwt-logging' will replace '--verbose --verbose' '--quiet' and '--verbose' will remain as written in my first note. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Multiple inheritance in the DOM
On Wed, Aug 1, 2012 at 9:45 AM, Andrei Bucur wrote: > On 7/27/12 1:55 AM, "Adam Barth" wrote: >>Perhaps it would make sense to start with a smaller CSSOM for Regions >>that uses established patterns and techniques. That way we can gain >>experience with these patterns and techniques before jumping into API >>designs that don't follow existing patterns and introduce complexity >>across the entire platform. > > In the light of the recent discussions I think the best action to take is > not to add the Region interface in WebKit at this moment. Instead of that, > we should move the members from the Region interface to the Element > interface and implement them there. The > NamedFlow.getRegions()/getRegionsByContent() methods would then return a > sequence of Elements. > > When other types of DOM/CSSOM objects will be able to become regions (such > as pseudo-elements) we will take another look at implementing the > supplemental interfaces mechanism. > > The downside with taking this path is the region sequences returned by the > NamedFlow API functions will not contain the pseudo-elements that are > regions. However, I think this is an issue we can live with :). > > Thoughts? I think that's a wise course of action. Nothing prevents us from inventing the Regions interface in the future since nothing observable will change in JavaScript. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Multiple inheritance in the DOM
Hi Adam, On 7/27/12 1:55 AM, "Adam Barth" wrote: >Perhaps it would make sense to start with a smaller CSSOM for Regions >that uses established patterns and techniques. That way we can gain >experience with these patterns and techniques before jumping into API >designs that don't follow existing patterns and introduce complexity >across the entire platform. In the light of the recent discussions I think the best action to take is not to add the Region interface in WebKit at this moment. Instead of that, we should move the members from the Region interface to the Element interface and implement them there. The NamedFlow.getRegions()/getRegionsByContent() methods would then return a sequence of Elements. When other types of DOM/CSSOM objects will be able to become regions (such as pseudo-elements) we will take another look at implementing the supplemental interfaces mechanism. The downside with taking this path is the region sequences returned by the NamedFlow API functions will not contain the pseudo-elements that are regions. However, I think this is an issue we can live with :). Thoughts? Thanks, Andrei. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Kerning not working for SVG font when included in HTML file using @font-face
Thank you very much for reporting the bug Tony. In this case opening a bug report at http://bugs.webkit.org may be better. Greetings, Dirk On Aug 1, 2012, at 9:26 AM, Peter Beverloo wrote: > Please use the webkit-h...@lists.webkit.org mailing list for questions such > as this one, as webkit-dev is intended as a forum for WebKit developers. In > general, if exactly the same code behaves differently in WebKit compared to > other browsers, or WebKit's implementation is different from what the > specification says, you're always welcome to file a bug on > http://bugs.webkit.org/. > > Thanks, > Peter > > On Wed, Aug 1, 2012 at 5:23 PM, tony wrote: > Hi, > I created a SVG font file and wanted to try kerning between two glyphs (V and > G in the attached file). > The kerning works when open the SVG in browser but does not work if i include > it in HTML styles using @font-face. > Please let me know if i am doing something wrong or is it a bug in webkit. > > PS: The same SVG font file when converted to ttf and the ttf refered to using > @font-face in HTML works fine in Firefox14. > > Thanks > Tony > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Kerning not working for SVG font when included in HTML file using @font-face
Please use the webkit-h...@lists.webkit.org mailing list for questions such as this one, as webkit-dev is intended as a forum for WebKit developers. In general, if exactly the same code behaves differently in WebKit compared to other browsers, or WebKit's implementation is different from what the specification says, you're always welcome to file a bug on http://bugs.webkit.org/. Thanks, Peter On Wed, Aug 1, 2012 at 5:23 PM, tony wrote: > Hi, > I created a SVG font file and wanted to try kerning between two glyphs (V > and G in the attached file). > The kerning works when open the SVG in browser but does not work if i > include it in HTML styles using @font-face. > Please let me know if i am doing something wrong or is it a bug in webkit. > > PS: The same SVG font file when converted to ttf and the ttf refered to > using @font-face in HTML works fine in Firefox14. > > Thanks > Tony > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Sure, that's fine. But please make sure not to ship these CSS properties until editing code is properly fixed. On Wed, Aug 1, 2012 at 4:47 AM, Bruno Abinader wrote: > Hi Ryosuke, > > Indeed. On the proposed implementation I've assured that the original > "text-decoration" from CSS 2.1 spec remains with exactly same behavior > as before (though I've managed to get some shared code to avoid > duplication). Layout tests results from my local run points no new > failing tests due to these changes so far. > > As for the editing & execCommand, these will be handled later (you can > see none of the patches touches any files inside > Source/WebCore/editing directory). I know there are some management > with CSSPropertyTextDecoration and > CSSPropertyWebkitTextDecorationsInEffect going on there, but these > stay untouched (in edting) until I acquire more information about > -webkit-text-decorations-in-effect usage. > > On Tue, Jul 31, 2012 at 10:40 PM, Ryosuke Niwa wrote: > > Please make sure the new text decoration values don't break editing (rich > > text editing & execCommand). In particular, we probably need to update > > ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. > > > > On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader > > > wrote: > >> > >> Hi all :) > >> > >> As suggested by Ojan, I am writing a mail to you about my intention to > >> implement all updated and missing text-decoration* properties from > >> CSS3 spec (currently in development), named below: > >> > >> -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000) > >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration > >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration > >> Status: Proposed patch / pending review > >> > >> -webkit-text-decoration-line ( > >> https://bugs.webkit.org/show_bug.cgi?id=90959 ) > >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line > >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line > >> Status: Proposed patch / pending review > >> > >> -webkit-text-decoration-style ( > >> https://bugs.webkit.org/show_bug.cgi?id=90958 ) > >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style > >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style > >> Status: Proposed patch / pending review > >> > >> -webkit-text-decoration-color ( > >> https://bugs.webkit.org/show_bug.cgi?id=91638 ) > >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color > >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color > >> Status: Proposed patch / pending review > >> > >> -webkit-text-decoration-skip ( > >> https://bugs.webkit.org/show_bug.cgi?id=92801 ) > >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip > >> Status: Work in progress > >> > >> As each patch touches similar places and sometimes requires previous > >> work, this patch series requires the patches to be reviewed / commited > >> in the same order as described above ( 92000, 90959, 90958, 91638 and > >> 92801 ). > >> The decision to use "-webkit-" prefix was suggested by Alexis on > >> https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a > >> suggestion to use a specific flag to enable this feature at compile > >> time, however other CSS3 properties such as text-emphasis, for > >> example, do not use such flags, so I am a bit uncertain about it > >> still. > >> > >> I am really looking forward for comments and review on the proposed > >> patches :) > >> > >> Best regards, > >> > >> -- > >> Bruno de Oliveira Abinader > >> ___ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > > > > -- > Bruno de Oliveira Abinader > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can we remove webkit prefix from Battery Status API and from Vibration API?
On Tue, Jul 31, 2012 at 10:05 PM, Kihong Kwon wrote: > > Has a test suite been published we can test against? > > I didn't see a test suite which is opened to everyone yet. > Is this a problem for dropping prefix? > It's not strictly required for dropping the prefix. But it would be good to have some confidence that our implementation is interoperable with other implementations. Can you run our tests against Firefox and see that we get the same results? Also, could you see if Firefox has any tests that we fail? You can report the results on the bugs directly so reviewers have that information. > > > Are there any other implementations of the APIs? Besides the time-based > > requirement of dropping vendor prefixes when a specification goes to > > Candidate Recommendation status, unprefixing also implies operability > with > > both the specification and other implementations. It'll be good to > confirm > > that. > > Firefox already implements these APIs. > https://wiki.mozilla.org/WebAPI > https://developer.mozilla.org/en/DOM/window.navigator.battery > https://developer.mozilla.org/en/DOM/window.navigator.battery > > And these APIs have been entered CR as you know. > > BR, > Kihong. > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Add support for CSS3 text-decoration* properties
Hi Ryosuke, Indeed. On the proposed implementation I've assured that the original "text-decoration" from CSS 2.1 spec remains with exactly same behavior as before (though I've managed to get some shared code to avoid duplication). Layout tests results from my local run points no new failing tests due to these changes so far. As for the editing & execCommand, these will be handled later (you can see none of the patches touches any files inside Source/WebCore/editing directory). I know there are some management with CSSPropertyTextDecoration and CSSPropertyWebkitTextDecorationsInEffect going on there, but these stay untouched (in edting) until I acquire more information about -webkit-text-decorations-in-effect usage. On Tue, Jul 31, 2012 at 10:40 PM, Ryosuke Niwa wrote: > Please make sure the new text decoration values don't break editing (rich > text editing & execCommand). In particular, we probably need to update > ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. > > On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader > wrote: >> >> Hi all :) >> >> As suggested by Ojan, I am writing a mail to you about my intention to >> implement all updated and missing text-decoration* properties from >> CSS3 spec (currently in development), named below: >> >> -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration >> Status: Proposed patch / pending review >> >> -webkit-text-decoration-line ( >> https://bugs.webkit.org/show_bug.cgi?id=90959 ) >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-line >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-line >> Status: Proposed patch / pending review >> >> -webkit-text-decoration-style ( >> https://bugs.webkit.org/show_bug.cgi?id=90958 ) >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-style >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-style >> Status: Proposed patch / pending review >> >> -webkit-text-decoration-color ( >> https://bugs.webkit.org/show_bug.cgi?id=91638 ) >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-color >> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration-color >> Status: Proposed patch / pending review >> >> -webkit-text-decoration-skip ( >> https://bugs.webkit.org/show_bug.cgi?id=92801 ) >> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration-skip >> Status: Work in progress >> >> As each patch touches similar places and sometimes requires previous >> work, this patch series requires the patches to be reviewed / commited >> in the same order as described above ( 92000, 90959, 90958, 91638 and >> 92801 ). >> The decision to use "-webkit-" prefix was suggested by Alexis on >> https://bugs.webkit.org/show_bug.cgi?id=90959#c13 . There is also a >> suggestion to use a specific flag to enable this feature at compile >> time, however other CSS3 properties such as text-emphasis, for >> example, do not use such flags, so I am a bit uncertain about it >> still. >> >> I am really looking forward for comments and review on the proposed >> patches :) >> >> Best regards, >> >> -- >> Bruno de Oliveira Abinader >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev > > -- Bruno de Oliveira Abinader ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can we remove webkit prefix from Battery Status API and from Vibration API?
I have made bugs. https://bugs.webkit.org/show_bug.cgi?id=92839 https://bugs.webkit.org/show_bug.cgi?id=92840 Kihong 2012/8/1 Kihong Kwon : >> Has a test suite been published we can test against? > > I didn't see a test suite which is opened to everyone yet. > Is this a problem for dropping prefix? > >> Are there any other implementations of the APIs? Besides the time-based >> requirement of dropping vendor prefixes when a specification goes to >> Candidate Recommendation status, unprefixing also implies operability with >> both the specification and other implementations. It'll be good to confirm >> that. > > Firefox already implements these APIs. > https://wiki.mozilla.org/WebAPI > https://developer.mozilla.org/en/DOM/window.navigator.battery > https://developer.mozilla.org/en/DOM/window.navigator.battery > > And these APIs have been entered CR as you know. > > BR, > Kihong. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
