Re: [webkit-dev] StyleBuilder vs StyleResolver

2013-04-12 Thread Antti Koivisto
On Fri, Apr 12, 2013 at 7:36 AM, Dirk Schulze dschu...@adobe.com wrote: Hi, The style of CSS properties is either set in StyleBuilder/CSSProperty or in StyleResolver (alias CSSStyleSelector). StyleResolver has a giant switch statement to handle all CSS property values and set the style. It

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Sergio Villar Senin
En 12/03/13 18:31, Ryosuke Niwa escribiu: That doesn't work. At a bidi-level boundary, offset can jump from one place to another. Consider a much simpler example; the same sequence of letters, in logical order, ABC123 in a RTL block, which will be rendered as: 123CBA with logical/DOM offsets

[webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Jochen Eisinger
Hi, currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example to create pop-unders. In order to restrict the number of new windows to one per user gesture, a port needs to invoke

Re: [webkit-dev] StyleBuilder vs StyleResolver

2013-04-12 Thread Antti Koivisto
On Fri, Apr 12, 2013 at 4:50 PM, Dirk Schulze dschu...@adobe.com wrote: On Apr 12, 2013, at 1:08 AM, Antti Koivisto koivi...@iki.fi wrote: On Fri, Apr 12, 2013 at 7:36 AM, Dirk Schulze dschu...@adobe.com wrote: Hi, The style of CSS properties is either set in StyleBuilder/CSSProperty

Re: [webkit-dev] Adding __FILE__ and __LINE__ to CRASH() macro

2013-04-12 Thread Darin Adler
Is this for debug builds or for production builds? If it is for debug builds, then adding file and line seems fine; we should do it in a way that shares code with assertion macros. If it is for production builds, then how do you debug other crashes? -- Darin

[webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Hudson, Rick
I'm assuming that we agree that JavaScript must evolve to leverage the hardware's power stingy parallelism. For completeness there seems to be the following approaches. 1) Add nothing to the language and rely on increasingly sophisticated compilers to detect opportunities to safely

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 4:40 AM, Sergio Villar Senin svil...@igalia.comwrote: En 12/03/13 18:31, - R. Niwa escribiu: That doesn't work. At a bidi-level boundary, offset can jump from one place to another. Consider a much simpler example; the same sequence of letters, in logical order,

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin svil...@igalia.comwrote: I know that WK follows the NSTextView implementation but FF for example does not show the remote insert issue. Yes, it does. Firefox simply uses heuristics to guess which type of character LTR/RTL you're about to

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 10:00 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin svil...@igalia.comwrote: I know that WK follows the NSTextView implementation but FF for example does not show the remote insert issue. Yes, it does. Firefox

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Shezan Baig
On Fri, Apr 12, 2013 at 6:01 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 10:00 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin svil...@igalia.com wrote: I know that WK follows the NSTextView implementation but FF for example

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 10:07 AM, Shezan Baig shezbaig...@gmail.com wrote: On Fri, Apr 12, 2013 at 6:01 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 10:00 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin svil...@igalia.com

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 8:36 AM, Hudson, Rick rick.hud...@intel.com wrote: I'm assuming that we agree that JavaScript must evolve to leverage the hardware's power stingy parallelism. True, but there is also the question of how high of a priority we should give to this relative to other project

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Sergio Villar Senin
En 12/04/13 19:00, Ryosuke Niwa escribiu: On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin svil...@igalia.com Well, I have a pretty compact patch more or less ready to be uploaded to bz that in the case of the caret being placed at (3) just draws the classical 1px width bar (it

Re: [webkit-dev] Overtype mode in WebKit for editable content?

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 11:59 AM, Sergio Villar Senin svil...@igalia.comwrote: En 12/04/13 19:00, Ryosuke Niwa escribiu: On Fri, Apr 12, 2013 at 9:50 AM, Sergio Villar Senin svil...@igalia.com Well, I have a pretty compact patch more or less ready to be uploaded to bz that in the

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Brady Eidson
On Apr 12, 2013, at 5:05 AM, Jochen Eisinger joc...@chromium.org wrote: Hi, currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example to create pop-unders. In order to restrict the number of new windows

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Jarred Nicholls
Argh, sending from the right address this time. On Fri, Apr 12, 2013 at 4:39 PM, Jarred Nicholls jarred.nicho...@gmail.comwrote: On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 8:36 AM, Hudson, Rick rick.hud...@intel.com wrote: I'm assuming that

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 1:39 PM, Jarred Nicholls jarred.nicho...@gmail.com wrote: On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 8:36 AM, Hudson, Rick rick.hud...@intel.com wrote: I'm assuming that we agree that JavaScript must evolve to leverage the

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 5:05 AM, Jochen Eisinger joc...@chromium.orgwrote: currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example to create pop-unders. In order to restrict the number of new windows to one

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:39 PM, Jarred Nicholls jarred.nicho...@gmail.com wrote: On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo fpi...@apple.com wrote: For as little worth as it is, I agree with you Filip that providing

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Jochen Eisinger
On Fri, Apr 12, 2013 at 10:40 PM, Brady Eidson beid...@apple.com wrote: On Apr 12, 2013, at 5:05 AM, Jochen Eisinger joc...@chromium.org wrote: Hi, currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Jochen Eisinger
On Fri, Apr 12, 2013 at 10:58 PM, Benjamin Poulain benja...@webkit.orgwrote: On Fri, Apr 12, 2013 at 5:05 AM, Jochen Eisinger joc...@chromium.orgwrote: currently, WebKit allows for an arbitrary number of new windows to be created in response to a single user gesture. This is used for example

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:39 PM, Jarred Nicholls jarred.nicho...@gmail.com wrote: On Fri, Apr 12, 2013 at 2:54 PM, Filip Pizlo fpi...@apple.com wrote:

[webkit-dev] on coding-style

2013-04-12 Thread Karen Shaeffer
Hello, Was reading the coding-style documentation. Have just one question concerning C++ null pointer value. Quoting the coding-style docs, In C++, the null pointer value should be written as 0. My question is: Doesn't xcode clang now support features like nullptr? Shouldn't the coding-style

Re: [webkit-dev] on coding-style

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 3:33 PM, Karen Shaeffer shaef...@neuralscape.comwrote: Was reading the coding-style documentation. Have just one question concerning C++ null pointer value. Quoting the coding-style docs, In C++, the null pointer value should be written as 0. My question is: Doesn't

Re: [webkit-dev] on coding-style

2013-04-12 Thread Allan Sandfeld Jensen
On Saturday 13 April 2013, Karen Shaeffer wrote: Hello, Was reading the coding-style documentation. Have just one question concerning C++ null pointer value. Quoting the coding-style docs, In C++, the null pointer value should be written as 0. My question is: Doesn't xcode clang now support

Re: [webkit-dev] on coding-style

2013-04-12 Thread Karen Shaeffer
On Fri, Apr 12, 2013 at 03:41:17PM -0700, Benjamin Poulain wrote: On Fri, Apr 12, 2013 at 3:33 PM, Karen Shaeffer shaef...@neuralscape.comwrote: Was reading the coding-style documentation. Have just one question concerning C++ null pointer value. Quoting the coding-style docs, In C++,

Re: [webkit-dev] on coding-style

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 4:09 PM, Karen Shaeffer shaef...@neuralscape.comwrote: Of course, I understand that. But there is a huge opportunity cost to webkit. The c++11 standard also rewrites the entire standard library. I have been using g++ 4.7.2 using -stdc++11 in my work with linux. And

Re: [webkit-dev] on coding-style

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 4:09 PM, Karen Shaeffer shaef...@neuralscape.comwrote: On Fri, Apr 12, 2013 at 03:41:17PM -0700, Benjamin Poulain wrote: On Fri, Apr 12, 2013 at 3:33 PM, Karen Shaeffer shaef...@neuralscape.comwrote: Was reading the coding-style documentation. Have just one

Re: [webkit-dev] on coding-style

2013-04-12 Thread Darin Adler
On Apr 12, 2013, at 3:33 PM, Karen Shaeffer shaef...@neuralscape.com wrote: Shouldn't the coding-style documentation be updated to use nullptr? We may want to update the guidelines to tell people to use nullptr where it works. We definitely put some effort into making it usable in certain

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

2013-04-12 Thread Alexey Proskuryakov
12 апр. 2013 г., в 13:58, Benjamin Poulain benja...@webkit.org написал(а): In https://bugs.webkit.org/show_bug.cgi?id=114379 I add this for WK2 and for WK1 mac/win. Are other ports interested in this behavior? If not, I'd just skip the corresponding tests. I am confused. Why do you

[webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Maciej Stachowiak
On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote: Of course, I understand that. But there is a huge opportunity cost to webkit. The c++11 standard also rewrites the entire standard library. I have been using g++ 4.7.2 using -stdc++11 in my work with linux. And

Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote: As others have said, we are definitely eager to use C++11 across the board but are limited by compiler support requirements. One thing that

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Maciej Stachowiak
On Apr 12, 2013, at 2:13 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:39 PM, Jarred Nicholls jarred.nicho...@gmail.com wrote: On

Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Roger Fong
From the CMake thread, I got that MSVC 2010 will soon be the oldest version supported. Is that correct? It looks like that might be the case although I still need to test cmake on the AppleWin port to confirm that’s it’s okay. Assuming that we do make use of cmake I’m still not quite sure

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Dirk Pranke
On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: I'm curious: would you want to use ParallelArray, if you had the flexibility of building a different abstraction? I find ParallelArray to be an awkward abstraction to begin with. I like work queues and such. The whole

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Zoltan Herczeg
A message passing model a la Web Workers has some advantages compared to threads with shared mutable state and locks: - No possibility of deadlock - No possibility of corrupting data structures due to races - No performance penalty from correctly supporting fine-grained concurrent access to

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Rik Cabanier
On Fri, Apr 12, 2013 at 9:39 PM, Zoltan Herczeg zherc...@webkit.org wrote: A message passing model a la Web Workers has some advantages compared to threads with shared mutable state and locks: - No possibility of deadlock - No possibility of corrupting data structures due to races - No

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 6:35 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 12, 2013, at 2:13 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12,

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 9:46 PM, Rik Cabanier caban...@gmail.com wrote: On Fri, Apr 12, 2013 at 9:39 PM, Zoltan Herczeg zherc...@webkit.org wrote: A message passing model a la Web Workers has some advantages compared to threads with shared mutable state and locks: - No possibility of

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Ryosuke Niwa
On Fri, Apr 12, 2013 at 2:13 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:39 PM, Jarred Nicholls jarred.nicho...@gmail.com wrote: On

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 10:43 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 2:13 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12, 2013, at 1:59 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: On Apr 12,

Re: [webkit-dev] Parallel JavaScript: Why a separate ParallelArray types

2013-04-12 Thread Filip Pizlo
On Apr 12, 2013, at 7:03 PM, Dirk Pranke dpra...@chromium.org wrote: On Fri, Apr 12, 2013 at 1:50 PM, Filip Pizlo fpi...@apple.com wrote: I'm curious: would you want to use ParallelArray, if you had the flexibility of building a different abstraction? I find ParallelArray to be an awkward

Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Patrick Gansterer
Am 13.04.2013 um 03:22 schrieb Benjamin Poulain: On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote: As others have said, we are definitely eager to use C++11 across the board but are limited