Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.
Hi, [.] The feature does not seem very invasive so if some people really invest time in maturing this, it could be worth experimenting with this and provide feedback to the W3C working group. I think everything should be behind a feature flag, and have the -webkit- prefix. As usual with experimental features, you will have to remove it if it turns out the experiment is not successful. I wouldn't characterize the nav-* properties as experimental, given their fairly widespread implementation among Television oriented profiles of HTML/CSS, going back at least to 1999 [1]. See also specifications from 2001 and 2003 [2][3]. As such, it seems somewhat questionable to use a -webkit- prefix. If we're not prefixing it, then it's very important for the initial implementation to pass all compatibility tests W3C and/or it matches other vendors' implementations. Agreed. Working on making W3C pass in the initial implementation was already the idea, as I mentioned in my original mail when I pointed out the tests that Opera has recently submitted [1]. Anyway, it seems to me that there are no major issues blocking this try to get this feature integrated in WebKit, besides those doubts and concerns related to how specifically execute the task. In that regard, it's my understanding a good way to proceed now might be: * Polish the patch and update it to match the current codebase properly. * Put these changes behind a feature flag. To be enabled in WebKitGTK+. * Ensure the patch passes W3C tests[1]. Include the tests with the patch. * Submit the patch for review. About the prefix, I'd personally prefer to move on without it for now and leave that decision for a further step, once this work has been fleshed out a bit more. Is anyone against this plan? Thanks, Mario [1] http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
Hi, On 07/26/2013 06:04 PM, Anders Carlsson wrote: Hi everyone, when Oliver landed his “let’s break everything” patches in JSC the other day, I noticed that some of the follow-up build fixes by other ports were removing use of C++11 features (mainly nullptr). Are there any ports that aren’t building as C++11? If so, why not? - Anders No, I don't have objections. :) I absolutely support switching to c++11, and I'm happy to add back the removed nullptrs and scoped enum values _after_ all ports switched to c++11. - cmake port did the switch by http://trac.webkit.org/changeset/153315 - GTK did the switch by http://trac.webkit.org/changeset/150445 - Qt and Win confirmed that they are going to do the switch, but I'm not sure if they already did it or not. Let the EWS bots notice us. :) Patch is coming soon in https://bugs.webkit.org/show_bug.cgi?id=119266 But I suprised how c++11 became mandatory. If you had announced it before pushing the FTL patches, we would have easily avoid the tons of buildfixes removing c++11 features. br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
Hi Patrick, On Jul 29, 2013, at 10:42 AM, Patrick East patri...@bsquare.com wrote: There is support for C++11 on Windows Embedded Compact 2013 using the newer VC11 compiler, but for CE 5, 6, or WEC 7 they will not be able to support it since they are limited to the VC9 compiler. Afaik there doesn’t appear to be any plans from Microsoft to back-port the newer compiler and run time to support older versions of CE. That’s too bad. Can you give me an idea of how big a ‘market’ we are talking about for these older OS releases? Are these targets likely to need or benefit from access to a ToT WebKit build? I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it’s possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. I think the goal is to (at least initially) conditionalize the use of various C++11 idioms. But I think we will soon reach a critical mass where we will assume the compiler supports the newer language constructs. -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
On Jul 30, 2013, at 9:23 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: No, I don't have objections. :) I absolutely support switching to c++11, and I'm happy to add back the removed nullptrs and scoped enum values _after_ all ports switched to c++11. - cmake port did the switch by http://trac.webkit.org/changeset/153315 - GTK did the switch by http://trac.webkit.org/changeset/150445 - Qt and Win confirmed that they are going to do the switch, but I'm not sure if they already did it or not. Let the EWS bots notice us. :) Patch is coming soon in https://bugs.webkit.org/show_bug.cgi?id=119266 Excellent! But I suprised how c++11 became mandatory. If you had announced it before pushing the FTL patches, we would have easily avoid the tons of buildfixes removing c++11 features. To clarify, this decision isn’t final yet - and has not yet been announced. I sent this e-mail because I was under the impression that most/all ports were already building as C++11 and it came a surprise to find that this was not the case. Regards, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
On Jul 30, 2013, at 10:52 AM, Brent Fulgham bfulg...@apple.com wrote: I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it’s possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. I think the goal is to (at least initially) conditionalize the use of various C++11 idioms. But I think we will soon reach a critical mass where we will assume the compiler supports the newer language constructs. We’re already using C++11 features conditionally in WebKit. The plan is to move forward and make some features a requirement. Patrick, given the broad support for this proposal from other ports/contributors we are going to ahead and move forward with it. Regards, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
Hi Brent, For a ballpark of the market size we have customers with millions of devices, and we believe there are several million other WinCE devices that are also utilizing WebKit. The target platforms do benefit quite a bit having access to the latest builds, nearly all of our customers push for having the latest performance enhancements, features, and bug fixes. Patrick East | Software Engineer +1 425.519.5912 | patri...@bsquare.commailto:patri...@bsquare.com Bsquare │Forging Smart Connections www.bsquare.comhttp://www.bsquare.com/ From: Brent Fulgham [mailto:bfulg...@apple.com] Sent: Tuesday, July 30, 2013 10:53 AM To: Patrick East Cc: Anders Carlsson; WebKit Development Subject: Re: [webkit-dev] Ports not building as C++11? Hi Patrick, On Jul 29, 2013, at 10:42 AM, Patrick East patri...@bsquare.commailto:patri...@bsquare.com wrote: There is support for C++11 on Windows Embedded Compact 2013 using the newer VC11 compiler, but for CE 5, 6, or WEC 7 they will not be able to support it since they are limited to the VC9 compiler. Afaik there doesn't appear to be any plans from Microsoft to back-port the newer compiler and run time to support older versions of CE. That's too bad. Can you give me an idea of how big a 'market' we are talking about for these older OS releases? Are these targets likely to need or benefit from access to a ToT WebKit build? I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it's possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. I think the goal is to (at least initially) conditionalize the use of various C++11 idioms. But I think we will soon reach a critical mass where we will assume the compiler supports the newer language constructs. -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Ports not building as C++11?
Thanks Anders. I look forward to the changes for our WEC2013 builds! Patrick East | Software Engineer +1 425.519.5912 | patri...@bsquare.commailto:patri...@bsquare.com Bsquare │Forging Smart Connections www.bsquare.comhttp://www.bsquare.com/ From: Anders Carlsson [mailto:ander...@apple.com] Sent: Tuesday, July 30, 2013 2:02 PM To: Brent Fulgham Cc: Patrick East; WebKit Development Subject: Re: [webkit-dev] Ports not building as C++11? On Jul 30, 2013, at 10:52 AM, Brent Fulgham bfulg...@apple.commailto:bfulg...@apple.com wrote: I realize that CE 5, 6, and 7 are probably not top priorities for the community, but these changes will basically force dropping support for those platforms. We do have some interest in keeping WebKit working for our downstream build, so if it's possible to make this change over to using C++11 in a way that can allow for building without the new features that would be ideal. If there is anything we can do that help make this happen let me know. I think the goal is to (at least initially) conditionalize the use of various C++11 idioms. But I think we will soon reach a critical mass where we will assume the compiler supports the newer language constructs. We're already using C++11 features conditionally in WebKit. The plan is to move forward and make some features a requirement. Patrick, given the broad support for this proposal from other ports/contributors we are going to ahead and move forward with it. Regards, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
