[webkit-dev] Do we need subpixel layout (Was: Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?)

2013-07-31 Thread Balazs Kelemen
I think first we should clarify some more basic questions about subpixel layout. 1. Is it actually mantained? 2. Do any port really need it? Please correct me if these questions are too obvious or have been resolved before. Note that I am not a fan of subpixel layout, neither an enemy of it -

Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-07-31 Thread Ryosuke Niwa
Can't we encounter the same bug if we you multiplied the same height by 64 even if the sub pixel layout is not turned off? Or is there some parser and other component that prevents such an overflow to happen? - R. Niwa On Wed, Jul 31, 2013 at 1:35 PM, Benjamin Poulain wrote: > On Wed, Jul 31,

Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-07-31 Thread Benjamin Poulain
On Wed, Jul 31, 2013 at 4:34 AM, Javier Fernandez wrote: > While looking into the bug #118595 I've found out that the root cause > was an arithmetic overflow during the layout process, at least in the > case of the WebKitGtk+ port, but I guess other ports have similar root > cause. Notice that web

[webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?

2013-07-31 Thread Javier Fernandez
Hi, While looking into the bug #118595 I've found out that the root cause was an arithmetic overflow during the layout process, at least in the case of the WebKitGtk+ port, but I guess other ports have similar root cause. Notice that webkitgtk+ port enables the SUBPIXEL-LAYOUT by default. Later,